Date: Tue, 8 Jan 2008 09:04:19 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64: enable irq in default_idle
Message-ID: <20080108080419.GD31838@elte.hu>
References: <4782984F.3050601@ct.jp.nec.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4782984F.3050601@ct.jp.nec.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 789
Lines: 25


* Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:

> Hi Ingo,
> 
> I think local_irq_enable() is missing in default_idle() on x86_64. 
> It's for recent x86 tree.
> 
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> Subject: [PATCH] x86_64: enable irq in default_idle
> 
> local_irq_enable() is missing after sched_clock_idle_wakeup_event().

thanks Hiroshi, applied.

The effects of this bug should be increased latencies on 64-bit. Did you 
notice these latencies, or did you find the bug in some other way (code 
review)?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/