Received-SPF: pass (google.com: domain of linux-kernel+bounces-102610-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <f1fd3dbf-a4a3-419e-9092-ff7f9302c874@intel.com>
Date: Wed, 13 Mar 2024 15:46:28 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 1/2] x86/resctrl: Rename pseudo_lock_event.h to trace.h
Content-Language: en-US
To: Haifeng Xu <haifeng.xu@shopee.com>, <james.morse@arm.com>
CC: <fenghua.yu@intel.com>, <babu.moger@amd.com>, <tglx@linutronix.de>,
	<mingo@redhat.com>, <bp@alien8.de>, <dave.hansen@linux.intel.com>,
	<hpa@zytor.com>, <peternewman@google.com>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>, <corbet@lwn.net>, <linux-doc@vger.kernel.org>
References: <20240308074132.409107-1-haifeng.xu@shopee.com>
 <20240308074132.409107-2-haifeng.xu@shopee.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240308074132.409107-2-haifeng.xu@shopee.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkJ5VFJvb09UNnpsMHhleUpDdys2M2dLeDBsMkI3K21OQ0V6NENVWmd1UHNE?=
 =?utf-8?B?dWlPZ0U1V3VxckRCSjIzRE9TcUM4K28xR3FHUnV6bG52dnFNQ2NZWEs1bnFJ?=
 =?utf-8?B?MDdNNjlaakJPdG9JS21MZEw5c1RmdDlxUWRUNGFBYkhqY0hVNEl0ZGJydk5Q?=
 =?utf-8?B?aWowdTd2dHNBeVd1YUNtZWFEb3VUWUNheTBjRmp4bFFUR0FKUGR3UmhuM2tz?=
 =?utf-8?B?OTlGUW5ucXhhK05YYnpadXcvTzIrTVhwMG96dG91NVFiSHNETEx6b3FpQllR?=
 =?utf-8?B?VnUzbUxDNEFwRzdNcUZlbnJpYmp0UzR2N0oveENxSXFMZjgrOG1tRzFjWElI?=
 =?utf-8?B?MDFWbWw0L29PVVhJbDdFUWkwdG0xNWZzTURJbDY3c25nSnBJNmQ1d2VZZTk3?=
 =?utf-8?B?eTFyMzlZYzdMNGJNcysvNGhUVFdLL0ZuTUVSKzZFaitWWDVSZlNSeFJOZkh4?=
 =?utf-8?B?ZWZsdTRhYkh6Y0UyZFB3c3gzQjhUd0dIZHlyaHh4bExyeFVqS0pncWVTRFAz?=
 =?utf-8?B?MFdXRmFQY1N4c0VNd2tPSXp2cUM1MmVsSTd1VEUwaHQxWm4wTVNPSGdVZmhD?=
 =?utf-8?B?VnAxL0U1UkFKMHhaYU80cThneFlRbGxrZTVBL21lcml6M0NDQVowZlpLYkdI?=
 =?utf-8?B?ZWNOZ1N1Y3kxZlJmQXpveUtjR0Z3TGtPUWVaK3pKN1NSdDhHdFpnQXBRVkk1?=
 =?utf-8?B?SGcyS2RpcW9mOHVzM2Jwd1FOaExEc0sybnZHKzh5SjNQSlp3K3hFUjZjMzFv?=
 =?utf-8?B?ek9DZ3JjS1FTUE8yTjlBdWhMcm1ZSUR4N2RmZEcxWW4rb0wxS2F5WkNVMWVR?=
 =?utf-8?B?amZtNlJneDZnMFkvQkhCZCtTbWR4dnVTVEk4NmdpeFgxeXRsN3RxWnU1WG1Q?=
 =?utf-8?B?TVQrSFVKWkNvdzF3L1UwdnVUcU9uT1llS1dTdFVqYjJLZGdJbkJVL2l3c21t?=
 =?utf-8?B?MlorWFFyUHhXbXlIZUduWUdMbVlEU09MZFFNd25aSVFZZVRnRjFOTGtxcnd1?=
 =?utf-8?B?UGhnNGRncWx1OENlL1JkdTVJR3R3Zjh1SE8vRUhzemFjTWcwU0hzR1pNSkJy?=
 =?utf-8?B?NjU1ZHdYQUp1U1QzVDErNjhTUzJuemJ3TGR5azNPMjRHem9pb3BuSTQ4UXQz?=
 =?utf-8?B?S2Q4ekVUdW5yVzYrdmdRcWR6UHIyOTdDR1NiSm5FTUFxZjBvU1QycVplckFV?=
 =?utf-8?B?RzMzcW9NWEJFTStJZWNwcDA0VEVwaWFtRmtPazRFOHNrRmdaVUExUFF5M0Fx?=
 =?utf-8?B?ejFkYTh2VWRHOFJuN1YrMzNud3h2YUxteGNvekp0NjQ1eWZzaGg1dlNIUGx5?=
 =?utf-8?B?c2lqYmdOTXUyUTF1ejhMYkFLMkI4UnppR1YrbjN4blo2NWxOdVdQWUhNczdZ?=
 =?utf-8?B?QVg4TXBzVVNQU252WlIxSDQwc0tsZDR5NVN5VitkdENOWENEdFhzNmZFRGdS?=
 =?utf-8?B?Z2xyREt6WlViK2s4TllMYWttTC9EaHFndkJ1ZmdjZmhDZDdIdnRCckhoMWNr?=
 =?utf-8?B?dEZvekJ6VTBCNFpSZlBLS3FLUTFieitMWlNSclNlbnQ2b09HQnVGTWpOK3hF?=
 =?utf-8?B?SVhiZWo2WVA1R1V0dURkTGlwRDhweXhKb3Nnb1dBcXFCbzhNTXA4RjN2ZGpD?=
 =?utf-8?B?NUpjdXc4T1ppMnozU29IODRGSVYveEVBSFBRWDlFN2NSZGxLSDlaNGpEVkRG?=
 =?utf-8?B?M2ExMjUrZFRiRTNvRjduM0NlQzRSUG5WNzl3YTdEMFRwOHVLN2J0SEtSNHVt?=
 =?utf-8?B?WnFTc0lnNWVBb1ZRRStTL1owN0J2Y2NzWW1ERk8yRll2ejNVYWVYQ0ExM2tv?=
 =?utf-8?B?Y0FwMnBTRXVPN3RkRU1VUFg5d0h3cDNVclg3SVhDZWVDNnhsSVQvWHpMV2c3?=
 =?utf-8?B?MnR4eWpvS2NRMmhhaHEzOUczekVVa0JwWUdLYitBVDdmMnA4aGd5VHE5Yko1?=
 =?utf-8?B?L0puUzFoSWFYT1cyOXFlbHIvZ3ZzdTMrWk11dEZGRndPTFRuRUk3QmZ2VTg3?=
 =?utf-8?B?eXgyRGZrR0MybEFwQnN4aTdPSnlEVjF3dGwrcGc1UGhkSHhVeUJHck1uWG1F?=
 =?utf-8?B?bUx2aFR1cmtMTytzZUFLek9QYTZ2VzQyMUpzNlF2QkpWenJ5d242Ui9VZEd0?=
 =?utf-8?B?MkJ6NU9xRDNleXBVWWhIU0NwVVRhY3BqRXFBSVhzVTVQSU9oaWc3OTkvMk5L?=
 =?utf-8?B?cFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b29c1cd-db65-4a6d-d6f2-08dc43af7112
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 22:46:37.6964
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KD/r2aGzWxTmXsb6WMJ5YICmW+Q71eO4nN5uCHArLSyenzS5citUAAWh6zNryfL1fxuc0m+EviTqnoipcgmW0eSwALuqsEw/jPClkt6nGJ0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6140
X-OriginatorOrg: intel.com

Hi Haifeng,

On 3/7/2024 11:41 PM, Haifeng Xu wrote:
> Now only pseudo-locking part uses tracepoints to do event tracking, but
> other parts of resctrl may need new tracepoints. It is unnecessary to
> create separate header files and define CREATE_TRACE_POINTS in different
> c files which fragments the resctrl tracing.
> 
> Therefore, give the resctrl tracepoint header file a generic name to
> support its use for tracepoints that are not specific to pseudo-locking.
> 
> No functional change.
> 
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> ---
>  arch/x86/kernel/cpu/resctrl/pseudo_lock.c                   | 2 +-
>  .../x86/kernel/cpu/resctrl/{pseudo_lock_event.h => trace.h} | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
>  rename arch/x86/kernel/cpu/resctrl/{pseudo_lock_event.h => trace.h} (88%)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
> index 884b88e25141..492c8e28c4ce 100644
> --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
> +++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c
> @@ -31,7 +31,7 @@
>  #include "internal.h"
>  
>  #define CREATE_TRACE_POINTS
> -#include "pseudo_lock_event.h"
> +#include "trace.h"
>  
>  /*
>   * The bits needed to disable hardware prefetching varies based on the
> diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock_event.h b/arch/x86/kernel/cpu/resctrl/trace.h
> similarity index 88%
> rename from arch/x86/kernel/cpu/resctrl/pseudo_lock_event.h
> rename to arch/x86/kernel/cpu/resctrl/trace.h
> index 428ebbd4270b..ed5c66b8ab0b 100644
> --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock_event.h
> +++ b/arch/x86/kernel/cpu/resctrl/trace.h
> @@ -2,7 +2,7 @@
>  #undef TRACE_SYSTEM
>  #define TRACE_SYSTEM resctrl
>  
> -#if !defined(_TRACE_PSEUDO_LOCK_H) || defined(TRACE_HEADER_MULTI_READ)
> +#if !defined(_TRACE_RESCTRL_H) || defined(TRACE_HEADER_MULTI_READ)
>  #define _TRACE_PSEUDO_LOCK_H

The above #define should match the new name also.

>  
>  #include <linux/tracepoint.h>
> @@ -35,9 +35,9 @@ TRACE_EVENT(pseudo_lock_l3,
>  	    TP_printk("hits=%llu miss=%llu",
>  		      __entry->l3_hits, __entry->l3_miss));
>  
> -#endif /* _TRACE_PSEUDO_LOCK_H */
> +#endif /* _TRACE_RESCTRL_H */
>  
>  #undef TRACE_INCLUDE_PATH
>  #define TRACE_INCLUDE_PATH .
> -#define TRACE_INCLUDE_FILE pseudo_lock_event
> +#define TRACE_INCLUDE_FILE trace
>  #include <trace/define_trace.h>

The rest looks good.

Thank you.

Reinette