Received-SPF: pass (google.com: domain of linux-kernel+bounces-102669-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 13 Mar 2024 17:16:23 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Abhishek Chauhan <quic_abchauha@quicinc.com>
Cc: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Halaney
 <ahalaney@redhat.com>, Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
 Martin KaFai Lau <martin.lau@kernel.org>, Martin KaFai Lau
 <martin.lau@linux.dev>, Daniel Borkmann <daniel@iogearbox.net>,
 kernel@quicinc.com
Subject: Re: [PATCH net-next v1] Revert "net: Re-use and set
 mono_delivery_time bit for userspace tstamp packets"
Message-ID: <20240313171623.51ebb7bd@kernel.org>
In-Reply-To: <20240313235003.1354814-1-quic_abchauha@quicinc.com>
References: <20240313235003.1354814-1-quic_abchauha@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 13 Mar 2024 16:50:03 -0700 Abhishek Chauhan wrote:
> Subject: [PATCH net-next v1] Revert "net: Re-use and set mono_delivery_time bit for userspace tstamp packets"
> Date: Wed, 13 Mar 2024 16:50:03 -0700
> X-Mailer: git-send-email 2.25.1
> 
> This reverts commit 30bb896b98fce7d823a96fc02cd69be30384a5cc.
> 
> Signed-off-by: Abhishek Chauhan <quic_abchauha@quicinc.com>
> ---
> Reason for revert - 
> https://lore.kernel.org/netdev/bc037db4-58bb-4861-ac31-a361a93841d3@linux.dev/

> 1. Fallback to design proposed in version 1 to have a seperate user_delivery_time
> bit 
> 2. Keep mono_delivery_time as ease
> 3. Add user_delivery_time as a new bitfield will be a seperate patch 
> 4. do not reset the time if either mono_delivery_time or user_delivery_time is set
> 5. we will need a user_delivery_time bit and use that to look at sk_clockid

Could you please spell this out a bit more in the commit message and
add the link as a:

Link: https://lore.kernel.org/netdev/bc037db4-58bb-4861-ac31-a361a93841d3@linux.dev/

in the commit message rather than the "throw away notes" ?

(feel free to repost asap, without usual netdev's 24h)
-- 
pw-bot: cr