Received-SPF: pass (google.com: domain of linux-kernel+bounces-102671-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
References: <20240223192658.45893-1-rrameshbabu@nvidia.com>
 <20240309084440.299358-1-rrameshbabu@nvidia.com>
 <20240309084440.299358-7-rrameshbabu@nvidia.com>
 <20240312165544.75ced7e1@kernel.org>
User-agent: mu4e 1.10.8; emacs 28.2
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: ahmed.zaki@intel.com, aleksander.lobakin@intel.com,
 alexandre.torgue@foss.st.com, andrew@lunn.ch, corbet@lwn.net,
 davem@davemloft.net, dtatulea@nvidia.com, edumazet@google.com,
 gal@nvidia.com, hkallweit1@gmail.com, jacob.e.keller@intel.com,
 jiri@resnulli.us, joabreu@synopsys.com, justinstitt@google.com,
 kory.maincent@bootlin.com, leon@kernel.org, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, liuhangbin@gmail.com,
 maxime.chevallier@bootlin.com, netdev@vger.kernel.org, pabeni@redhat.com,
 paul.greenwalt@intel.com, przemyslaw.kitszel@intel.com,
 rdunlap@infradead.org, richardcochran@gmail.com, saeed@kernel.org,
 tariqt@nvidia.com, vadim.fedorenko@linux.dev, vladimir.oltean@nxp.com,
 wojciech.drewek@intel.com
Subject: Re: [PATCH RFC v2 6/6] tools: ynl: ethtool.py: Output timestamping
 statistics from tsinfo-get operation
Date: Wed, 13 Mar 2024 17:22:50 -0700
In-reply-to: <20240312165544.75ced7e1@kernel.org>
Message-ID: <87plvxbqwy.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?mXbHSTeCXQZtxzWgP207vNZt8obetJJdLuYBNLUW9nxYkpqV57EAzkMMreJA?=
 =?us-ascii?Q?GRQYBR6ghgWqyt2BtYhlE277onsNMT7Krv2CNRdxuXmk2PKMCKM8+y2Eti2g?=
 =?us-ascii?Q?TmDY6GPOnWqJgELHEtvBHRiwZF89gAdOHnCKiQpEjcOebX3o/D9XoTwe3bHA?=
 =?us-ascii?Q?jn7kxgxqe0xS+bxfNvut+jdasUGHGFGLWPRRa1mu1iRGTPPmPojHMQaECbq6?=
 =?us-ascii?Q?cLd3SQnuzGa0voysgC/x60TOi6dV3H1gt6LkWlTWPp7GN7IcfjBZbq6yN6j/?=
 =?us-ascii?Q?fIYYAFYumAdgLhdrTvjb7IkiwtOH6pYTjylD7ofcrr5HKdcdkm4TL7NEfoy5?=
 =?us-ascii?Q?aAoENNFrTyhJPCagUiyas6lKzZieYJ2VzNZn82yJyp4C6sAnZbMMnqnJ/NbP?=
 =?us-ascii?Q?AmmCODrwUBr6rnZAAhdaTUXh7sEqvT5I2rfpqGqly6eZj+19fdBBezVetAj/?=
 =?us-ascii?Q?lrUS6TzIhTg+meBEdTAbGhw9zhO/SrdZy5YsENkohWDH3WdTe0Wq3irTJdoG?=
 =?us-ascii?Q?wHjDT/9RHWuD4O2OYXee7B8tnhCZQx9rTil+8sbeiRIPVGnXj34zFxI6ECrf?=
 =?us-ascii?Q?FPepHzW9ocDsaRY1Ev3yD3vJ+C6CVtr6WvS4SpOFwydTyGRYcF+Tt+YqXoYK?=
 =?us-ascii?Q?O/r5PKzthpYCDjX6Q17IfggQKXrLLg9DK05wGHWoqDH7u8WNmM4hBRfPEXbT?=
 =?us-ascii?Q?WVS+aUmQjGitnkXU5BjFYI7qGy0ywjpKjYJ0U/gR0bpHLdj5z/EJF2kW2aHK?=
 =?us-ascii?Q?s5dXvBLUUVj29LVWhSTo+d60kNyHRdHUjJTj8yF0UOy3lV+Gh8aflI4JR+ZA?=
 =?us-ascii?Q?FAi9GYMuA8mehW09Ifv/q1g5vF9DP/o6j65DJ6Vdc52nIPBHYCqPqttZz/xW?=
 =?us-ascii?Q?kVvWkmHrHGGufPfrhP992VmMtVjENMC0bCXBcONI55vLMgL7LrftI/LTGclw?=
 =?us-ascii?Q?xoA4ZGoobMP4odXLWLiQVgnm0HUcQcUHEKGrYa5mxJ9MvFMHBID2IPdXPAL1?=
 =?us-ascii?Q?XUvJnsM+txp+kjUOIQ1omgfTuQRMPAmJjKTzf+gy4VYcDpC0ILbYnraNkKCG?=
 =?us-ascii?Q?7NtrrynjGfw/6Vwt6Wwwuq4TCgpbrxIPEUc77enZh9wiUvmx0rWMUj6helkC?=
 =?us-ascii?Q?BKmTTiWd7L+0hnK4g1N2GDo65vg92+1YS+dulC2XRCcQAmI2m+kOotUzDuEU?=
 =?us-ascii?Q?xZirDk9E8twniNirjSECqMcaSM4Jmg0Xmwk0PDb4MI0BSm9le3Grpd0Plh59?=
 =?us-ascii?Q?KTAhDc4urXI5U1NllU0WYfo3RXfZVB5S/lVT9AAfLxdQe92IRzlV896Bp8vz?=
 =?us-ascii?Q?Pm5FfMCqlkqiRZGJiGPuJb+WMFjmS1+q4U1x6o54q4l6loI8sc8PkYtBuk/i?=
 =?us-ascii?Q?Y6yyvR4JQ4/KuR+dKMGRqPiwBEZwpprby1tF2thZrAA7Bshcsc1A5QPifUqV?=
 =?us-ascii?Q?O+vskeBD7hRpjqPmB2wbrjSoAKFWC/3LXseuFFdnUcCJHuCiKmScFa1d3aIZ?=
 =?us-ascii?Q?i1XYwx1u39JRHn3ZPalb3Urj5fiGOaIhGUMixpi751xbttF0nNeK2DGNPC1P?=
 =?us-ascii?Q?UibQemUpyPdNWkL9h1L53HGzXYNz9oN7emuishjQkhmVzOSoIwm2xj9Zlo92?=
 =?us-ascii?Q?Og=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 570863be-835b-45f4-7e9b-08dc43bd4401
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 00:25:35.0042
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9vXujXcbAp00sFDax3lSbWt2zQSJULG6JHDONTMOa5UkE1zVLv94DOO+uVXKel/3px9/b6MGTTw0Zkk4mnCRWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7840


On Tue, 12 Mar, 2024 16:55:44 -0700 Jakub Kicinski <kuba@kernel.org> wrote:
> On Sat,  9 Mar 2024 00:44:40 -0800 Rahul Rameshbabu wrote:
>> +        req = {
>> +          'header': {
>> +            'flags': 1 << 2,
>> +          },
>> +        }
>
> You should be able to use the name of the flag instead of the raw value.
> Jiri added that recently, IIRC.

I think this is for 'flag' type attributes. Not for the "header" flags
for the ethtool request, so I believe this cannot be done here, since
the header flags are a u32 type, not a flag type.

  https://lore.kernel.org/netdev/20240222134351.224704-2-jiri@resnulli.us/

  -
    name: header
    attributes:
      -
        name: dev-index
        type: u32
      -
        name: dev-name
        type: string
      -
        name: flags
        type: u32

vs

  -
    name: bitset-bit
    attributes:
      -
        name: index
        type: u32
      -
        name: name
        type: string
      -
        name: value
        type: flag

So I believe Jiri's change applies for the latter, not the former (could
be wrong here).

--
Thanks,

Rahul Rameshbabu