Received-SPF: pass (google.com: domain of linux-kernel+bounces-102691-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <8d542410-d8e1-4243-939c-6ce7743a66f1@amd.com>
Date: Thu, 14 Mar 2024 11:59:18 +1100
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH kernel v3] PCI/DOE: Support discovery version 2
Content-Language: en-US
To: Sathyanarayanan Kuppuswamy Natarajan
 <sathyanarayanan.nkuppuswamy@gmail.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
 Bjorn Helgaas <bhelgaas@google.com>, Ira Weiny <ira.weiny@intel.com>,
 Dan Williams <dan.j.williams@intel.com>,
 Jonathan Cameron <Jonathan.Cameron@huawei.com>,
 Lukas Wunner <lukas@wunner.de>
References: <20240307022006.3657433-1-aik@amd.com>
 <32ac2ee6-26b1-4f37-bd88-db1ef2a31267@linux.intel.com>
 <16120a31-c3d6-48a8-9355-7b063e28d242@amd.com>
 <CAC41dw9x8H2m=YB66+PA-GwiVkpCyT0PobdWvFXLHpAsQOE0ew@mail.gmail.com>
From: Alexey Kardashevskiy <aik@amd.com>
In-Reply-To: <CAC41dw9x8H2m=YB66+PA-GwiVkpCyT0PobdWvFXLHpAsQOE0ew@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V1BGK2s0Ulh0SXBCKzdUTCs0NWJSM1k5Y3doNzZ1R0xsNGtVRVJEbjZTaGY5?=
 =?utf-8?B?WjBDZW45Z1YyQWgwTDlXejhpR3RJcWo3MXVIRDNla3BGT2Y2dDVwV3BBZm0v?=
 =?utf-8?B?T0djazk0cWp0N2xENU5kanRtL2krbjVxQ2lMc2VVY2RBNk45Q3JwcHFTZHRF?=
 =?utf-8?B?eVBBYlBINmU0Qjk3SEJjT25DR2FzSkZpRDg3NU56SVNQbTJIbGZ1R09kbUhl?=
 =?utf-8?B?cnpYMTFmR3lYMEsvMlVsSkNOUnhDOFJhUlBHeTdFSUR5MVlQUElMQmZZd0M4?=
 =?utf-8?B?NGk0dDBEU1BnSEFmVUk1V3d0bTNkdDlnbGxOdGpJRDhtVDlzMGw5N2FlMXlG?=
 =?utf-8?B?eHQ3WmR0OWZ1aGRIUThyTTQxNThQKzZ3UEtQa3FvZ1hTOUtzSTY0VmZsOHNt?=
 =?utf-8?B?dDhRMjJ4K0hMMEtKdW9PMDg5WWpTZ3BreFIxN29PcnlGVVhybDV3YVNvSjBk?=
 =?utf-8?B?c2hMMU1PRVJjL0tmK3A0WFV2dFViUzhNbDdBaTN3YmpEcnRka0ZhQitoZzJD?=
 =?utf-8?B?ZTZSUVpxUDRUblNYOXFVb1hvV04wVGNWeldHYkRhS08yZEsxNVNpalFDZ2hF?=
 =?utf-8?B?SytON05CQmt1WnhBVk43L3ZENkxuNFBaNVBXN2ZITUt2NktsZW94YVJvN0Ey?=
 =?utf-8?B?WC8xcEVFdFVCRHJhMExzNDY1VlVGUWNxeE42Q0pDUmU5dHJmOE94cjNWSlhV?=
 =?utf-8?B?ZjY1Z3R5TU54cVg4RUpiUjJldmdZRzBjREtaeFUzanp5L0dBY2MyYmFPWnFF?=
 =?utf-8?B?OW1WMHl5NGx4VTRGNGkrYVhmN1hkWFE2dkU4bFdPZTlVQndTOXNqVnpaTDI2?=
 =?utf-8?B?dTVESHZMS2VDQUV6TmhDRzF6UWZUdjVJTWNtTTB2YjBaNFo0dDlaa285bVpN?=
 =?utf-8?B?YWFRbnU2SWxqamZjbnVFOUlSc0pSeTg1cTBBRTFkdjFLSEU0Zk5wL3UrVjlu?=
 =?utf-8?B?aG5RbGhYZWJxSEgxNzZzRXVpc0t2aGo1ZGZUdTV2ZXh0UDByT1pEdmlZc3FT?=
 =?utf-8?B?SFhxVSszTVkyZ2pXT0RWN3BYRnNxQWxTSlAyZi9oWUhIaGtkRG9VYUhRK3ZV?=
 =?utf-8?B?d0pHTFEzU2xIT0RYN3VKVThRSWlhNGtnbUJkY2ZHT1A0RUg1TTBEaHJtUmpu?=
 =?utf-8?B?SElpY0hxV0IrbHNENmszdFNVSFovQTZibnhNbTJCNWxNcFZ2blFFdklvckZZ?=
 =?utf-8?B?S1pWWXNhd21JWjBCSm1vQVlHUEFZZWFzQmtyejlZT295eDB3bXBJeHhYTFBo?=
 =?utf-8?B?ZGpjNFlxTHArSEN4bkJJdThjUTZjbWRNNkM5dWs5TU50L3lNNTVTNDY5aFpl?=
 =?utf-8?B?c1FpVDZCNWJQL2w5VUEvT1pzUXZrOFM0aVhZWG9UQkx5QlA2R0F3Wnh4Z1Jx?=
 =?utf-8?B?cjcrQWRnN2tvSWYyRlBYb0FuQzAvUFVUa1c3S3BJVTRkbStadTN0WERzVHJm?=
 =?utf-8?B?YzUzZkN0WHN3MjR4b1JSUjNpdVBTUDlodzdoM2ZWdUtUS3p1MVpnbldZTDZ6?=
 =?utf-8?B?QURia0hiNXJoUXMvZVlGZHA4cGlTRWV3SDZFZ3lpZFJCMU9VOEN0Q1VCOFJl?=
 =?utf-8?B?Y0RFL1FwTG8wdlRNdlZGeXdQNE9XVWhQeGYzalFpcC9LNGx0dVMyMGJ3U2lm?=
 =?utf-8?B?Q1NKY1VDQTZSU2tJRDdyYkg0TG1MVDI2VTFMaHRwMzc3WVV3VEZma1hJaUd3?=
 =?utf-8?B?VW5sbS9WV0EwUE5kZ29GdmpXOGJ5N21qSmtwdnUvMXFxaUI0S3RJanU4aTNx?=
 =?utf-8?B?QVlpcllCN2tjaGI5NXloVVQ3R2o0d29qVVl2VTJJWTI3ajZVZE8rQ05uNnI3?=
 =?utf-8?B?V21NWVFjZk1pRFdTQWhXN05MSER6Rm8vT1ZQZGxhdWlrZDQxNlE5cFI5TWRT?=
 =?utf-8?B?bWV0eXVhY2dFRmtOS0k2aVlHMDgwYlNQS1RNRjU4ejFMRk84WG1kMFJ1Rjdl?=
 =?utf-8?B?VnRiYW1LMG13YkxMMTVaNjdXTytuSkpxYmMwbEdDTGVmZWtZVUwySFJ1NzVT?=
 =?utf-8?B?SG5uRXVpbHBPUmxTZzhPYXMvU0ROdWlrVFpWS05sb1hWVWFxTzBNQUZVcndx?=
 =?utf-8?B?TVU4R3VZTnM5OFh6SXk5aG41dTRLSXY0TjRIUURMMFVVQU9jQVlhZUwzK0dX?=
 =?utf-8?Q?ewJ2clymIQgnG0GVzuetznaeU?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0ba8196-64d3-4c95-b81d-08dc43c1fdd1
X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9194.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 00:59:24.9221
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bnf6rNpVi66bsc3GLnF7t/cmXO4leXGY8OtSDZW/Zt2fZ0ELlFD84ViRCkzHVn7wju61ptlWKauWwYMqwn6DeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7422


On 7/3/24 17:22, Sathyanarayanan Kuppuswamy Natarajan wrote:
> On Wed, Mar 6, 2024 at 10:09 PM Alexey Kardashevskiy <aik@amd.com> wrote:
>>
>>
>>
>> On 7/3/24 16:06, Kuppuswamy Sathyanarayanan wrote:
>>>
>>> On 3/6/24 6:20 PM, Alexey Kardashevskiy wrote:
>>>> PCIe r6.1, sec 6.30.1.1 defines a "DOE Discovery Version" field in
>>>> the DOE Discovery Request Data Object Contents (3rd DW) as:
>>>>
>>>> 15:8 DOE Discovery Version – must be 02h if the Capability Version in
>>>> the Data Object Exchange Extended Capability is 02h or greater.
>>>
>>> Does this change fix any functional issue? If yes, please add Fixes:
>>> tag and probably CC stable?
>>
>> The issue is that before this patch the DOE driver was following PCIe
>> r6.0 and it was not working on a device with DOE cap v2 added in r6.1.
>> Is it "fixes"?
>>
> 
> Since you are enabling support for the newer spec version, I think it will not
> fall under bug fix. But it might be qualified for the stable branch.
> It depends on
> whether you want to support this device in older(stable) kernels.


I am going to need lot more stuff (TSM, IDE, TDISP) in addition to this 
but it is coming much later so there is no point in pushing this alone 
to older kernels. Thanks,


-- 
Alexey