Received-SPF: pass (google.com: domain of linux-kernel+bounces-102733-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <3d2e488f-6191-4844-b5a7-2563898d4670@amlogic.com>
Date: Thu, 14 Mar 2024 11:04:10 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/4] arm64: dts: add support for A4 based Amlogic BA400
Content-Language: en-US
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Neil Armstrong <neil.armstrong@linaro.org>,
 Jerome Brunet <jbrunet@baylibre.com>, Kevin Hilman <khilman@baylibre.com>,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org
References: <20240312-basic_dt-v1-0-7f11df3a0896@amlogic.com>
 <20240312-basic_dt-v1-3-7f11df3a0896@amlogic.com>
 <CAFBinCAvT6-gfZQH--AVJAxiVM9bv5=agYzJ-u3NZUGFvp2vZA@mail.gmail.com>
From: Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <CAFBinCAvT6-gfZQH--AVJAxiVM9bv5=agYzJ-u3NZUGFvp2vZA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bU8zLzN2S0VINGk5NWp6c21VM1VlajhLY2dUdEhoU1Blc21xT000TXJ0VEhn?=
 =?utf-8?B?TUN4T3psQnVLZmJ5V054OEJYbGhodU5MUEx2VUVMSUI1bTQ0ZXhLZHJmTHhw?=
 =?utf-8?B?bE9pend3dzlrVlJ3bEFxL094b09NM1I2OW1WYUlWem96cmRoU0dXOVNDT01x?=
 =?utf-8?B?MUMxaFJkakxwaFZnUktFWTlIMGFuYUZ0TVlsQjZSSE04SWdkOXpCL2RYTlNP?=
 =?utf-8?B?eDExNGZiTTZiNnplUUNQOEFEdGp6QVY1djdEanE1V0hUWFd2aElxckxUTXdQ?=
 =?utf-8?B?S1FvbkhxQWVZbCtHMUNqMUtQbTNrUDBlZ0F4S2o4SUVBNmpoc0NKbHoyc0hZ?=
 =?utf-8?B?Z2IxVzdrVXdycEJWYzJyRzE1UjlGNjh0MjQxL1I5dUVUWE5kMWJwWFFWM1Iv?=
 =?utf-8?B?MGMzT01vQ0M4a1RMSDNaUnhtaTVOUlhkcXcwT0pkNUZQZVNsRDhsN0pwV2tE?=
 =?utf-8?B?U0tabiszY2N1WXRPbTMvTzhLVXNPYVZvb2ZRd0F4V1hsa3N6aEJyTVk5TUpp?=
 =?utf-8?B?VVVEdHZ4b3VOUGJ2WVAvTVVHUjNoNU5qQnRhdHJaNEFRSWV1aW90bE11Y2dl?=
 =?utf-8?B?Vkw0SXd2S1BycXpIUFpZVXh3azhJd1djWXo0UHVNanRVTVh6a25zMWYrRFVV?=
 =?utf-8?B?T1lxYklrRlVhc2NJRTdYR05veEFNQlhJL3Y3N0lkTERpZUZYRTdxMmdsZTc4?=
 =?utf-8?B?c3I4K0tUbzRYdXdmNjBTeDhWMHFvZ2ttOE5WOFBQb3dJclVjeGFaUVROTmJK?=
 =?utf-8?B?UXRRRlg2TjdDQ25wSmZ4R1o2RExkWGdzNWdFVU1uSW90UGtRUFRxalVEWHpL?=
 =?utf-8?B?M002MnA1enJCcUlvbm1iTWtrRnNuaE0xaE9qSWxnU2p5U3lNclNiSlg1ais4?=
 =?utf-8?B?VEJVeEkrRGxteWZ2cE9FUVFwWWxkdFMxRWpHdU1BWGxWL1kraVJHVHpIOVJy?=
 =?utf-8?B?QURBUHJjR0V4cWVKalpURFlaVzNvalgxRFd6RTNaSWpxbUJqL0xYTFdkQlht?=
 =?utf-8?B?L1ZBTDl6cU9YQ0gxOEdIVzc2WEs1RE1JeHVoSlVURzg0Y21uVXpkcUEzN0dP?=
 =?utf-8?B?MFd2TzZLZisvRlkzMmIyWnpLbmFNSjFET3F5U0tWdVk3ai93ZlhuNDJVOWpv?=
 =?utf-8?B?YWVHQ09ibXB4M2g2emc5YWtKcXlBVks3Yit5WGlLcEt6QkNkSEVVU3crOFF1?=
 =?utf-8?B?UDZTUlBUMGxReHVYaVlGV3FWcnNaUEpjcHJxZnBFWFA4am91RVl6c0FlUkZt?=
 =?utf-8?B?N2VYbC9zbGg0bnV6TUJKbno5YUtwWldzalJmclQwcFh4NEVORTFNR25XTHJN?=
 =?utf-8?B?ZUUzRXNkZnNrcGJlQjZRZjk4bTNqbERsVVZnR01DOC9seGxUMTNpM3k3dEpV?=
 =?utf-8?B?eWJhZ1RadldTSk8xR2J5L3c0ckhadkZsUS9qQVV4ZDNwWVIvQkJmQmIwRWtU?=
 =?utf-8?B?NGpCdUsyOFJDS1VjOXA3elFzTmVKRHZlUzBaaUo3cWhKT0hqSDJYT0MzTXpF?=
 =?utf-8?B?STBiN2xtOTJWdzZPRDVUMXhQYlRESmN1QlZYS2hCSDRzbW1pSXRCWmJremZX?=
 =?utf-8?B?UlV6VXlxWXNZTk9mTFo4bzhHUUR3SE9QT2hSK2xwREN5cGY1bUhYTjRnbmJ6?=
 =?utf-8?B?eWVWWnJqYXdrNk0xQ0JnWGV4TE5LZDFvMlU1UlZPeG1JWGJ6cXN0WHVQL0Qy?=
 =?utf-8?B?SFRubUxjZmo2b0NTSTFqbUFFT0xDSTBKNWd5cDhzU2ZPaTVHclZibUY5SUdD?=
 =?utf-8?B?YWMzN1NRTWpwdlFQSnhaT2pOL01pYlRZMERxY1dNN0ovdldYQTlkZGFETGRm?=
 =?utf-8?B?NDl4cU9YRlJmSkk2TmExd09WUlV5YkQ4NEdJYUY5aVFBRzVBTnI1RFNOVWhQ?=
 =?utf-8?B?c040RkZ1S2R3Q05qa052YitVVnExY2NPTHRiQ1A4anVhRWVHNDdTTllVMjJh?=
 =?utf-8?B?L3NmZ2VKcExQMjNqRC9STzFUc1BpVkp2Y0xvcVJoQjYxOG1hZnI1dkZwMEs3?=
 =?utf-8?B?a054NTlyL0RsWDhEYWVkZ1p5YmZHNDhjVDBoV1VQQUJUOUE1YU9xcWZPVU9q?=
 =?utf-8?B?OFVlbXJsYnZML0t4TFhxV2JBQVhKc25YVmlMWHN5L0lRZU53bjVZczkrUWVm?=
 =?utf-8?B?cVh3Y1Rwd0U0a2QrTGsxSHFBQVJNb2FLSWlyaFJCNW9GZDdmT3N6Y0RvbUlN?=
 =?utf-8?B?Smc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d216171-a401-4b05-e8d9-08dc43d36f05
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6896.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 03:04:16.1321
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jF8YoY7OzdgaSYkjpLYJ1lXS6P6ym7ARzPyqSdm6FE6caVA6vRjIFOhWwJq0Bl5x4LCPFEGfmmnUmpAZ4nNjEG0NPPT/ctuBWtwbUSaITMI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR03MB7430

Hi Martin,
    Thanks for your review.

On 2024/3/13 01:29, Martin Blumenstingl wrote:
> [ EXTERNAL EMAIL ]
> 
> On Tue, Mar 12, 2024 at 10:19 AM Xianwei Zhao via B4 Relay
> <devnull+xianwei.zhao.amlogic.com@kernel.org> wrote:
> [...]
>> +               apb@fe000000 {
> Node names need to be generic - since this is a bug it needs to be:
>    bus@fe000000 {
> Or if you want to make it clear how this bus is called then you can use:
>    apb: bus@fe000000 {
> 
Will fix it.
> The same comment applies to the amlogic-a5.dtsi patch (4/4).
> And while here, I fully agree with Jerome: having a bit more details
> would be great so we can judge on whether a common .dtsi makes sense.
> For this it would be helpful to know how many IP blocks those two SoCs
> have in common and how many are different.
> 
They are mostly the same, but the follow-on series is unclear, and I 
would like to wait for the follow-on chips to come out before 
considering a merger with common dtsi file.
> 
> Best regards,
> Martin