Received: by 2002:ab2:5c0e:0:b0:1ef:a325:1205 with SMTP id i14csp145365lqk; Wed, 13 Mar 2024 20:47:13 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXnGXKTalkaiKpqHdhGU3HUcrtnZkk91Zjf2LrOo69UJ/+uEbiu2+A+dYRVIM6afk9nTzfo1m0DxHkWc77VU/CWETgrVv6SzYcwPA5UpQ== X-Google-Smtp-Source: AGHT+IHBE6SOR5jKF1mNJETYDhZT8t7XOFppvZwSDPurXuJIS5MlHVzIkoA0jxJke/vTmeUGAjRS X-Received: by 2002:a17:906:b257:b0:a46:4c8e:18a8 with SMTP id ce23-20020a170906b25700b00a464c8e18a8mr295021ejb.51.1710388033062; Wed, 13 Mar 2024 20:47:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710388033; cv=pass; d=google.com; s=arc-20160816; b=MIHR2VLI4X2LqihyWG77XRWsdoW6DtUGi7bNCS7P8KCg0EInjc+6xVqC2k3OQikyVS 6PeXtdCV8MkC9Y93CR8v8lwTdo+NZ0aYl/nzFGhkZbVrfSMO0ghCw0SSZGTdaNTDXnIH oEmF34WQaOEHe1AGjsb3ReRtCePDgHVqjoYKttIfvwPFUSukIu3mh6Y1o8PjZ1zR4uML XU/scNqM2u789up0Y5q+5Ga+wXyTcSz2OfHBSFgseJqkbkV1m76rd+FfjyUobAZMJx+I vKhS2xXfDuiqXFhuhaaUGnmIkhosU9cRV+ffYjKTAM/F7KsDMhIuy+FdWK/JnVTl3eFD Khig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TuxkWK7dMQI2KIPAcDcm4V21xNZ8im/k/MzYg+G5fkA=; fh=7LV3CBdra5WOd/zL8EJjGFqlIVecEZ8ajdraNh/LTxA=; b=z1NrdoHBx3yiB12K22EkzUiab2f/gk9P4FZY1nd77QUUwAlKzcw4eigTnJm76hqRJV cNsgn5OPFU9uo+ot0Nk3gegMhprhJdPThdtC3GtBF9wHzBDx8wcSh6KGSHmRD71XgB3O WhqeyOX/pwtUKvGXCXm69OtrFeA+cOvGKbdAiiqqkcZ6DLNHwls73lSEFrIHH5luW0Nl BiCwVK24FN/XZUSKAB1dSsWmnpaLeYQfmgkqnKdBQ4C2dV8ewcMxYebvJJl+6VnrSuI/ 7mTvUVc2GHpidWPiHUC5YMAwxjRgaFwe/ChYHhmbIDDZSkfnW3/mbow+lKSHb3MFY589 ISoQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WVadQJjb; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-102755-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-102755-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id lx9-20020a170906af0900b00a465f67da9csi313252ejb.453.2024.03.13.20.47.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Mar 2024 20:47:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-102755-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WVadQJjb; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-102755-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-102755-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3B6A81F23A8B for ; Thu, 14 Mar 2024 03:39:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 570D75CBD; Thu, 14 Mar 2024 03:39:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WVadQJjb" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59339C13B; Thu, 14 Mar 2024 03:39:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710387579; cv=none; b=T9hLTrqtk1d8UaBVgFpJVQsbEUFTHj76Hvq+GmbL9W0DbQS/HJu9DFGx7i/+4SVju/3o9PxIl7u5dDdsz+MmS9dqmfSDsPjJqTajkyNCUgd9EV1zcLlNUhw+tX9GvmHxy/Z/SR+k6bjaO0uwf3PNkwWJxaweZx22HcahIAki7UY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710387579; c=relaxed/simple; bh=TuxkWK7dMQI2KIPAcDcm4V21xNZ8im/k/MzYg+G5fkA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HDlWPR8z7wTFtbJ8teIuifCQEUqRV5ptaRi1TiK4aRXHM4y/U3EcDpEj33c261P5FdMWXlSZD9rtFWXs5uopUGMpl5GxSO0AlApu3FNwaxcKuIha4qZbBbteOGR7aXW9wxcW045HhFRyZM5zKa+IeT3QUcuLv8nmPYzBC/Pn30M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WVadQJjb; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 821A1C433C7; Thu, 14 Mar 2024 03:39:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710387579; bh=TuxkWK7dMQI2KIPAcDcm4V21xNZ8im/k/MzYg+G5fkA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WVadQJjbFZWBHG8GHuRdNgykOmEZ6ttbZpUFa7bbjwG33qWdzE9Ps3YMtBVDcmDrT AZhleZ2b5KGHZn6mlT+Ppl91rUD3fmzePpss0CcononvFMwAVQWsJueQXgOAcWisW6 17TNVXGujlARAFx0dOClWZVRo9M5ZdB8GrztoFCUfZ6mOc4ioQL7YyrbNJJYsMUY2q 2QHvBR6ErUNomLNV7PYbHWa+EUGBF8CzpjKQY9a4ulHPZ//c+BMcSOcLBEDYj5eXxA 4vVRN7V0xAFFYJtaN07PZu3jgBrVyMmttjepaDsCj0AJQlm/w3phUmnxLOKmeyXXra IrNmeu+2wKGkQ== Date: Wed, 13 Mar 2024 21:39:34 -0600 From: Keith Busch To: Kevin Xie Cc: Lorenzo Pieralisi , Palmer Dabbelt , Minda Chen , Conor Dooley , "kw@linux.com" , "robh+dt@kernel.org" , "bhelgaas@google.com" , "tglx@linutronix.de" , "daire.mcnamara@microchip.com" , "emil.renner.berthing@canonical.com" , "krzysztof.kozlowski+dt@linaro.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-pci@vger.kernel.org" , Paul Walmsley , "aou@eecs.berkeley.edu" , "p.zabel@pengutronix.de" , Mason Huo , Leyfoon Tan Subject: Re: [PATCH v15,RESEND 22/23] PCI: starfive: Offload the NVMe timeout workaround to host drivers. Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 13, 2024 at 08:51:29PM -0600, Keith Busch wrote: > I suppose we could quirk a non-posted transaction in the interrupt > handler to force flush pending memory updates, but that will noticeably > harm your nvme performance. Maybe if you constrain such behavior to the > spurious IRQ_NONE condition, then it might be okay? I don't know. Hm, that may not be good enough: if nvme completions can be reordered with their msi's, then I assume data may reorder with their completion. Your application will inevitably see stale and corrupted data, so it sounds like you need some kind of barrier per completion. Ouch!