Received-SPF: pass (google.com: domain of linux-kernel+bounces-102767-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <ZeHr+PH8spL5F+iZ@debian-BULLSEYE-live-builder-AMD64>
In-Reply-To: <ZeHr+PH8spL5F+iZ@debian-BULLSEYE-live-builder-AMD64>
From: Steve French <smfrench@gmail.com>
Date: Wed, 13 Mar 2024 23:15:09 -0500
Message-ID: <CAH2r5msT=tSRkpZq2+f1gLL5Fcq-ohpKzD0kBioirZH-fXwq=w@mail.gmail.com>
Subject: Re: [PATCH] cifs: open_cached_dir(): add FILE_READ_EA to desired access
To: Eugene Korenevsky <ekorenevsky@astralinux.ru>, linux-cifs@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Tentatively merged into cifs-2.6.git for-next pending additional review/tes=
ting

Let me know if any updates to this

On Fri, Mar 1, 2024 at 8:54=E2=80=AFAM Eugene Korenevsky
<ekorenevsky@astralinux.ru> wrote:
>
> Since smb2_query_eas() reads EA and uses cached directory,
> open_cached_dir() should request FILE_READ_EA access.
>
> Otherwise listxattr() and getxattr() will fail with EACCES
> (0xc0000022 STATUS_ACCESS_DENIED SMB status).
>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=3D218543
> Signed-off-by: Eugene Korenevsky <ekorenevsky@astralinux.ru>
> ---
>  fs/smb/client/cached_dir.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/smb/client/cached_dir.c b/fs/smb/client/cached_dir.c
> index 3de5047a7ff9..a0017724d523 100644
> --- a/fs/smb/client/cached_dir.c
> +++ b/fs/smb/client/cached_dir.c
> @@ -239,7 +239,8 @@ int open_cached_dir(unsigned int xid, struct cifs_tco=
n *tcon,
>                 .tcon =3D tcon,
>                 .path =3D path,
>                 .create_options =3D cifs_create_options(cifs_sb, CREATE_N=
OT_FILE),
> -               .desired_access =3D  FILE_READ_DATA | FILE_READ_ATTRIBUTE=
S,
> +               .desired_access =3D  FILE_READ_DATA | FILE_READ_ATTRIBUTE=
S |
> +                                  FILE_READ_EA,
>                 .disposition =3D FILE_OPEN,
>                 .fid =3D pfid,
>                 .replay =3D !!(retries),
> --
> 2.30.2
>
>


--=20
Thanks,

Steve