Received-SPF: pass (google.com: domain of linux-kernel+bounces-102768-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
References: <20240223192658.45893-1-rrameshbabu@nvidia.com>
 <20240309084440.299358-1-rrameshbabu@nvidia.com>
 <20240309084440.299358-2-rrameshbabu@nvidia.com>
 <20240312165346.14ec1941@kernel.org> <87le6lbqsa.fsf@nvidia.com>
 <20240313174107.68ca4ff1@kernel.org> <87h6h9bpm1.fsf@nvidia.com>
 <20240313184017.794a2044@kernel.org>
User-agent: mu4e 1.10.8; emacs 28.2
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: ahmed.zaki@intel.com, aleksander.lobakin@intel.com,
 alexandre.torgue@foss.st.com, andrew@lunn.ch, corbet@lwn.net,
 davem@davemloft.net, dtatulea@nvidia.com, edumazet@google.com,
 gal@nvidia.com, hkallweit1@gmail.com, jacob.e.keller@intel.com,
 jiri@resnulli.us, joabreu@synopsys.com, justinstitt@google.com,
 kory.maincent@bootlin.com, leon@kernel.org, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, liuhangbin@gmail.com,
 maxime.chevallier@bootlin.com, netdev@vger.kernel.org, pabeni@redhat.com,
 paul.greenwalt@intel.com, przemyslaw.kitszel@intel.com,
 rdunlap@infradead.org, richardcochran@gmail.com, saeed@kernel.org,
 tariqt@nvidia.com, vadim.fedorenko@linux.dev, vladimir.oltean@nxp.com,
 wojciech.drewek@intel.com
Subject: Re: [PATCH RFC v2 1/6] ethtool: add interface to read Tx hardware
 timestamping statistics
Date: Wed, 13 Mar 2024 21:19:26 -0700
In-reply-to: <20240313184017.794a2044@kernel.org>
Message-ID: <871q8dh25r.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?CfkUmmHt2Qh1taLAERrcn3XKI06LHlEm1qKZXMLpzZQoVBIYiw5lMIGxWtFO?=
 =?us-ascii?Q?sQshjiqY/UpE9iunJpTrZALEi46r1vchE12Z5CLS9Jgtr6PIMI9OZuliRSg/?=
 =?us-ascii?Q?ZiS7cegq9zeg/kKnRUJjpjexwz5OYIeqSo3EZA7jcNFkxEFI9+BXkv2XnwRl?=
 =?us-ascii?Q?H4Z/46vPb7uKN60AC2/Cx/7kB1VLe1Yy4Rl0YlGgirde5/5jtaJnNmT+5QLD?=
 =?us-ascii?Q?CiFd+OjCuvWzmcNvPMCV1KWHseU1xmCKyl5j+azM5cFE3mpmlQ8X2wmBMARc?=
 =?us-ascii?Q?ImLNkt8dNn2r04yKAooydnj+dAg2P04V4qUWq8Aq01Ab6D/zugKJ2e/Rqecr?=
 =?us-ascii?Q?3l1Ht74/lH2tyDq+wDf8MAa7f/Hn5AJdbmhVsLLHzWhmsAO/41kKHOJFXIr3?=
 =?us-ascii?Q?CwbXVJ25+aKCKj8FH6yByEMvtp8z1SqZE6qXp2vXZ8PrwjxW6lgQ1IpkENf9?=
 =?us-ascii?Q?fmMjaR7QshrKficWVMiMX/VdIBlZ56oztX20YPW3DTSWDjsPYBxt2mmebyTf?=
 =?us-ascii?Q?InNAiKZe31OZRx3AwQU3XZeZz0QT2ern46z4sPL+x6SPJSJY6Rp0zBkdgp3e?=
 =?us-ascii?Q?lVfdyXNSChrch1K/ja6/X057pPoZ6X00riiPIC19cIhJPZ7ZCQJOhUhwAyRX?=
 =?us-ascii?Q?0/R1pmIkOrnJXG9+f6H/KZJ0OeThCEjDdB1IGWxpgd/yarPXYyeHtmM4Xkz4?=
 =?us-ascii?Q?1R8MAm6mHvqVSwZnDSr6z50DFzXkoObg4DkXRY2LrMS1ZrjNsb6Xiz5eK1z2?=
 =?us-ascii?Q?2jVik4Q59PZThedXbgfRN9pIvrtlyYr+4K+nrWB+C0yp/uUp2RmQDb26mtX3?=
 =?us-ascii?Q?FS2l8hzqDArirUwO/VO1HzFnnJ39NjDJnSTQ9yDhKEX1DSvqI2NdohJw72gG?=
 =?us-ascii?Q?mvZtQcuOh0W/W9X4v5I1uzUCyMjJE5qntvWEfrMQg+KNNiOjqY3sCfID8+4T?=
 =?us-ascii?Q?IMOO45L3miO/Wy97dHkJs0+wg9wT7i18210tLYcJt7BfUcjBDA0/L142sWgL?=
 =?us-ascii?Q?DPy/sfZGfihx7R6eu3AkApgD7nRLR4KJfJI7BpiwOgQLZqwPdb7/KyoALFb3?=
 =?us-ascii?Q?WNCTK8xAc4So95VwWZ6HbpFJfx9UWHd/57/KMXa5KfyRT5BE6N8jnwTKpQvu?=
 =?us-ascii?Q?up18zZFfxS2F4Z00muxcqLVOXffbjWox5/aIGHZ/X5706xgUFS/Pe4Acr/PX?=
 =?us-ascii?Q?6BUxQNFHDuxDEhNoWwvrMayH23TWZa3XpMrvrJUIyuaFKpFN266v8M/J02Ag?=
 =?us-ascii?Q?nQ4LPYxxrRnEvB0Um2eigJG1eyqUCdvq5bGSaI3ekcxFu9dHphoA7Vo+HQ7g?=
 =?us-ascii?Q?igrvk4L+jljidXDEPkLJPS3ttUwbDGVWJvTowIohCCQdiazROEl5LQG2yJcK?=
 =?us-ascii?Q?c+FTdx75fF1+xEVN4nLihk8D94Zee03uuXUGgyXUUByGPDt574u4RT2Gs+0h?=
 =?us-ascii?Q?bzHwRGS/1Z2xsvhMReCjGYU27cPHSj8FbKTkBO0HLvEYccOeMq3JWcFyiw+V?=
 =?us-ascii?Q?SmSsQX5nWBXZRQoP2r7JGIJ8xliDVA9YNts7lV7jf68sP/YSF6fR71RJIn5v?=
 =?us-ascii?Q?XHW5dN5eU/f8Tnd9I2ANKsVSaDq+xjrW57397cdT?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1e52e3d-6a27-4f71-1f87-08dc43de89e1
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 04:23:45.7166
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wNeKAsq9YtS9g72BVlkWtJG3QdDw1bUwJGZNYgmd5i1SjpKaDhVMqt81TfUO8/BCLupFM8BcpfMiB9DRGKBvkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6683


On Wed, 13 Mar, 2024 18:40:17 -0700 Jakub Kicinski <kuba@kernel.org> wrote:
> On Wed, 13 Mar 2024 17:50:39 -0700 Rahul Rameshbabu wrote:
>> > Should we give some guidance to drivers which "ignore" time stamping
>> > requests if they used up all the "slots"? Even if just temporary until
>> > they are fixed? Maybe we can add after all the fields something like:
>> >
>> >   For drivers which ignore further timestamping requests when there are
>> >   too many in flight, the ignored requests are currently not counted by
>> >   any of the statistics.  
>> 
>> I was actually thinking it would be better to merge them into the error
>> counter temporarily. Reason being is that in the case Intel notices that
>> their slots are full, they just drop traffic from my understanding
>> today. If the error counters increment in that situation, it helps with
>> the debug to a degree. EBUSY is an error in general.
>
> That works, too, let's recommend it (FWIW no preference whether
> in the entry for @err or somewhere separately in the kdoc).

  /**
   * struct ethtool_ts_stats - HW timestamping statistics
   * @tx_stats: struct group for TX HW timestamping
   *	@pkts: Number of packets successfully timestamped by the hardware.
   *	@lost: Number of hardware timestamping requests where the timestamping
   *		information from the hardware never arrived for submission with
   *		the skb.
   *	@err: Number of arbitrary timestamp generation error events that the
   *		hardware encountered, exclusive of @lost statistics. Cases such
   *		as resource exhaustion, unavailability, firmware errors, and
   *		detected illogical timestamp values not submitted with the skb
   *		are inclusive to this counter.
   */

Here is my current draft for the error counter documentation.

--
Thanks,

Rahul Rameshbabu