Received-SPF: pass (google.com: domain of linux-kernel+bounces-102797-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 14 Mar 2024 11:18:59 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To: Perry Yuan <perry.yuan@amd.com>
Cc: rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com,
	viresh.kumar@linaro.org, Ray.Huang@amd.com, Borislav.Petkov@amd.com,
	Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
	Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/6] cpufreq:amd-pstate: fix the nominal freq value set
Message-ID: <ZfKPy7hlwiYm++AM@BLR-5CG11610CF.amd.com>
References: <cover.1710323410.git.perry.yuan@amd.com>
 <08ed1f9f76a6a1c401efd8f426bdeb9681c4b4e9.1710323410.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <08ed1f9f76a6a1c401efd8f426bdeb9681c4b4e9.1710323410.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Nan/JIyQabBHaaTwp0mol9AnUg6HS0sodsuylKDqETFEVpzmX6AfHMsPRL/3?=
 =?us-ascii?Q?/cgDypkzxKxPYcw40uuAvJNXJjtzgDKsIosHwgWCgyejacQfuRe4Af+GQQfn?=
 =?us-ascii?Q?0Xti9mdB0nxE6RUz0xn+evsb8VkZK8XLz/b5ioVi7DZIrWw+TjqDBXkWyYsP?=
 =?us-ascii?Q?2A1V3G8spiV+hD5YIlHdmCFSZ9rzzo1mOZW8jSRftcLCPv1YjxmjZ8E9pZo7?=
 =?us-ascii?Q?6IUZemOTXvWgpbmdFFOGbZnwFETMdIQlAz0pprxuYFaIOATGQCDUcuXhnq6S?=
 =?us-ascii?Q?7gQ857xINBXE5uBB52upvV0Apdd7RUz0chSQ5YEu4jX5WIq9D3K9Nl0/8Rwt?=
 =?us-ascii?Q?k+tCBoiZn/oerP2/q0OVURs6TYvOneRtgFoS8vDQEAgEPSFUePYKL+GfTdZ6?=
 =?us-ascii?Q?dT5XoJuagZQq0/tl99gnb8E9iIM7dwU+KcDvbFdGX1khwSl/wWH/m8K8tobt?=
 =?us-ascii?Q?YKmikazVbpzWNKA7F5n3TS2p2nHTaKYy839W5uu6QnQF6B6xWH7iB9IVVn9s?=
 =?us-ascii?Q?EDYHZE7Scj9xSROaFjJrzDP4c6OYiVkdNItDK+dZdc5ZU06SItWUYfMvFQLG?=
 =?us-ascii?Q?eD/3h37UzMdUAlNkwKmJX4U+1+N1oO7WNFmh9JT2EFAun1/prQ739YOVzW1n?=
 =?us-ascii?Q?pheCNqlWi0RyrvFJwDHhTACt1HpYAvLaJ+F8xMpp/rwGW4ReEd0fZdbwqLdr?=
 =?us-ascii?Q?98/VXrSjQ/lbk37IzG09dM40ansXPQoyek22MomTUJiKkrXcNd5P53ShGXt8?=
 =?us-ascii?Q?2+1+3wbUDTYQTxkuBkQmgqbHE1oN2dU7JWF8eKUEnyg8T+cDxIr+BkBXsKfv?=
 =?us-ascii?Q?AZqemeM/OGsLYsOHTb09/Yv3qqQK8E11MorDWlg4QXz//AuTilkSrGeArJQn?=
 =?us-ascii?Q?LVfHMUjj9dJl4ci2dsMZsVABVV7EpO4HnpG8SdcjR5E4NStZwt02uUcE/XRS?=
 =?us-ascii?Q?Lv4B5PNQ+I8juAmDvlPe9obL2ThNFzODlcK4q9rtENiqSjC8NFAz8kdVEwe9?=
 =?us-ascii?Q?tBn9xzKGMh53A2vQ4Oia2WQT7E3B6x0PWzdQb1GiqErpDfVzmzLoueAD+2Pr?=
 =?us-ascii?Q?pPqBSpmNbXiUb/aiwFiVYkrK6I4g2wmWC8U/Gal5dgnF0arJHSffBg3RpIRB?=
 =?us-ascii?Q?8mZCqtAyL0fAY+xfqgLcYbj2l3ePWqv0obtO/QiZvWtBO4/HOyCIxa1QF9JR?=
 =?us-ascii?Q?OpF4AYlkTXxrhAzvdc2Gmusd3wP/OicEwtP+eK+IWx5ZFlHJBm6EG3Jl79tm?=
 =?us-ascii?Q?L/TkdENxI5MTDOdbTu3RDCBFwl/DrrXBFaibXE5iQ7L0WwtpzyJQIlcOI65j?=
 =?us-ascii?Q?dOIuH9Tq25RoEFY2vyv9wexwtNywVBPSmZzMj7QnAdaeNgJI5Yk1NfdbTdhh?=
 =?us-ascii?Q?YgThLG7uahxWDE7CGjfsfO4hGB/1EMcopWqQJ58uMc4Nq7WTcszzSmlZV0WP?=
 =?us-ascii?Q?p1rzFkbnzdCjg9iEs556wj3IosY+dz8MxJX5CcLSTEMJnZVfAuNKkVRgCMgr?=
 =?us-ascii?Q?UUFcRWsr/TX2EF4QBpZ36A3p5Iun4oKhezcSQW2eSMF5t9NUyvi1psLpxKLf?=
 =?us-ascii?Q?dF0ggiBm25LFTkMjDIo7fCnsVEnaYvEIKYHvZ8DE?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9aecf057-2618-43da-3d15-08dc43ea78ae
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB8252.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 05:49:10.7329
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 19XfhQ6SRllHtkAu/WPApmvo9WTqA0DF6ssOqk/V/8IzECY/FfIx0XXE5tUHWJmAlGpqYalToVVYe9RiG6YKIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5672

Hello Perry,

On Wed, Mar 13, 2024 at 05:59:13PM +0800, Perry Yuan wrote:
> Address an untested error where the nominal_freq was returned in KHz
> instead of the correct MHz units, this oversight led to a wrong
> nominal_freq set and resued, it will cause the max frequency of core to
> be initialized with a wrong frequency value.

As I had mentioned in my review comment to v6 [1], cpudata->max_freq,
cpudata->min_freq, cpudata->lowest_non_linear_freq are all in
khz. With this patch, cpudata->nominal_freq will be in mhz.

As Dhananjay confirmed [2], this patch breaks the reporting in
/sys/devices/system/cpu/cpufreq/policyX/*_freq as some of them will be
reported in mhz while some others in khz which breaks the expectation
that all these sysfs values should be reported in khz.

[cpufreq]# grep . *freq
amd_pstate_lowest_nonlinear_freq:1804000   <----- in khz
amd_pstate_max_freq:3514000                <----- in khz
cpuinfo_max_freq:2151                      <----- in mhz                 
cpuinfo_min_freq:400000                    <----- in khz
scaling_cur_freq:2151                      <----- in mhz
scaling_max_freq:2151                      <----- in mhz
scaling_min_freq:2151                      <----- in mhz
[cpufreq]# pwd        
/sys/devices/system/cpu/cpu0/cpufreq

What am I missing ?

[1] https://lore.kernel.org/lkml/ZcRvoYZKdUEjBUHp@BLR-5CG11610CF.amd.com/)
[2] https://lore.kernel.org/lkml/1aecf2fc-2ea4-46ec-aaf2-0dbbb11b5f8b@amd.com/

>
> Cc: stable@vger.kernel.org
> Fixes: ec437d71db7 ("cpufreq: amd-pstate: Introduce a new AMD P-State driver to support future processors")
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>

--
Thanks and Regards
gautham.


> ---
>  drivers/cpufreq/amd-pstate.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 2015c9fcc3c9..3faa895b77b7 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -647,8 +647,7 @@ static int amd_get_nominal_freq(struct amd_cpudata *cpudata)
>  	if (ret)
>  		return ret;
>  
> -	/* Switch to khz */
> -	return cppc_perf.nominal_freq * 1000;
> +	return cppc_perf.nominal_freq;
>  }
>  
>  static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata)
> -- 
> 2.34.1
>