Received-SPF: pass (google.com: domain of linux-kernel+bounces-102871-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 14 Mar 2024 11:53:45 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To: Perry Yuan <perry.yuan@amd.com>
Cc: rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com,
	viresh.kumar@linaro.org, Ray.Huang@amd.com, Borislav.Petkov@amd.com,
	Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
	Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 3/6] cpufreq:amd-pstate: get pstate transition delay
 and latency value from ACPI tables
Message-ID: <ZfKX8QbKuJBAdJs/@BLR-5CG11610CF.amd.com>
References: <cover.1710323410.git.perry.yuan@amd.com>
 <705e1a21a6a9d91a7ac67526c55c2961318ad678.1710323410.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <705e1a21a6a9d91a7ac67526c55c2961318ad678.1710323410.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?0R5z0bqREyVWVXveCqWHr7BDsgl4OeN2UsOUWtOKAkcN5uxM89AjDGS1CHhl?=
 =?us-ascii?Q?LZdCMRanWCEZqUdV3CmOqkZPBwKBeJcOKuhyYuUlgIIk016G6WtO9i0dfCKW?=
 =?us-ascii?Q?2xDzCb9V+XUye2NyuUk0+m90HDYcBDPGbsBvEhh43PBD/qvSmRZybWWxKxzl?=
 =?us-ascii?Q?Eds2NzSghGPC8Y072pDO81eh/8i2sTkV1/IcxqLEzqsu8kwQxwTdze9DO2MI?=
 =?us-ascii?Q?wUY+cZWAFJUQSi7d921wyTNhGDHe9kOlwCQ/fwev/yPqaaKoGahfrpIDUX4V?=
 =?us-ascii?Q?Om7an43VmnP8MfSQnV8F2CHJ0pxOyFA1BEOlL1hkjTDjPKEF8WkP0cNoB7C1?=
 =?us-ascii?Q?8IsJqrkzk9Oxem1Kl6+egq1KxxVD/bF/ZvbANl2TZbbCzAoSwosH9KR2MrXy?=
 =?us-ascii?Q?9MaIZQ34vO9MazLCM7l1X8JiFmFUnqy7zpVxhOLXrsXhQZLGBLuV2TA4SW+N?=
 =?us-ascii?Q?txFNgI4alUIx/WQtHDj18BYOO0oE6OOe1G93mDyUxtHSLOKedT7mfbKknDuh?=
 =?us-ascii?Q?5rAfpLPqtdSS7L6eoDb+yD4n/4pCGpbW78iEX9gLxfKiSSR2Fh9uwfy4MEgp?=
 =?us-ascii?Q?aMWx9JwafINZdShnMccxix2rOuyaw5RSmAzQVokp7wpW8VV9rsulWgVNwu/6?=
 =?us-ascii?Q?3bTL563RXnyNy/mzzIVx9RTuJBMkumOQO4TZagUvcI0VYYKZQaWeGn8v4263?=
 =?us-ascii?Q?otoobCHa+iAhgcs1pbTBn/R3ovdPeXZf7O+Hlv6dn4srEP419YWl74O3MM0a?=
 =?us-ascii?Q?9H3xJeCGX1SrZ2Fto1IvjNZaQtmhl6p/xosx3nF5tmOkqmF5OnhJyICfvtTY?=
 =?us-ascii?Q?FDUUXZ4cff1C0XPS/+Au3aCc5V8yHE1uO9dmjNw4TOW7uwD2Egttd+nFwqoo?=
 =?us-ascii?Q?BC4ga3zP9EhU3/otLHWWU16hkFOiw94bNhXN9mcLVNo1OlUQ52mk5/3gj3ZV?=
 =?us-ascii?Q?Ji29nwE2WsdM6yaPo8Uwx4AA1/BmmoclmTz+msNQiXmB9rd4Diz1bJiNhcxu?=
 =?us-ascii?Q?WtlIjorHH3aRYQcjtfWBzIj0rv7ZTCDiqocqXiP9JSWrwvUjhXSY87mxsneg?=
 =?us-ascii?Q?6WHQAUK0gK2RwhDv2kqCGWuUUmEb/obHFR1axTaW/4X9iLWfmSAqJE0JvzpU?=
 =?us-ascii?Q?8cQCk43MA6fdDSTDc7Dj5t08JDpPIE1gLx8yKwraU1DzxbrXPeC4dj7ecz/g?=
 =?us-ascii?Q?hNTerbgcRS4rn7Oi2wVmAvdjsS/rN0ZlV1haA/gXp6AzNFy/VsVzzVTrVvrN?=
 =?us-ascii?Q?QDBw1bLHgsx/ODTk3ewxWbctpxK5MjAiEAj5sfQhCXxxJtPrfOKlRQn45TNh?=
 =?us-ascii?Q?WY7M6o2YPPM6K32QNbNP580vh5FIBYnPcklhjpFNYCCzM02nd6v4mky+R4EV?=
 =?us-ascii?Q?yXg8l65NXz6e3LZMaEavdEwyuVFMzBskqUfIXNdXhhOOmhW1e+aeH0xc6Gsg?=
 =?us-ascii?Q?9YAddIuxVwxI/Ec3kjTKjazF22XLCkbdbYwLdZuD02bHygLKykdmzD1y057g?=
 =?us-ascii?Q?ZmYo1bjU5OUTfLrs2D/WkLATScveNuzT7M91VdqZeZerU0Ef627oQnMxOMja?=
 =?us-ascii?Q?WvzocXZOYpyfn/AZ0zUPJHOR2LEFpKHFLDCDftn4?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2965a2ca-aefb-4911-c572-08dc43ef520e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB8252.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 06:23:53.6347
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oMGCMsseNoCUOskxd/QHVIEQoI1Q8NNc4E3vFbzE2MQS+WyAQfgh2kQ3f/0PI9ZnffiHC1J0LxNyoSUxfMhE5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5685


On Wed, Mar 13, 2024 at 05:59:15PM +0800, Perry Yuan wrote:
> make pstate driver initially retrieve the P-state transition delay and latency
> values from the BIOS ACPI tables which has more reasonable delay and latency
> values according to the platform design and requirements.
> 
> Previously there values were hardcoded at specific value which may
> have conflicted with platform and it might not reflect the most accurate or
> optimized setting for the processor.
> 
> [054h 0084   8]                Preserve Mask : FFFFFFFF00000000
> [05Ch 0092   8]                   Write Mask : 0000000000000001
> [064h 0100   4]              Command Latency : 00000FA0
> [068h 0104   4]          Maximum Access Rate : 0000EA60
> [06Ch 0108   2]      Minimum Turnaround Time : 0000
> 
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>

Looks good to me.

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

> ---
>  drivers/cpufreq/amd-pstate.c | 34 ++++++++++++++++++++++++++++++++--
>  1 file changed, 32 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 6db9256f42c0..ec6259957d25 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -827,6 +827,36 @@ static void amd_pstate_update_limits(unsigned int cpu)
>  	mutex_unlock(&amd_pstate_driver_lock);
>  }
>  
> +/**
> + * Get pstate transition delay time from ACPI tables that firmware set
> + * instead of using hardcode value directly.
> + */
> +static u32 amd_pstate_get_transition_delay_us(unsigned int cpu)
> +{
> +	u32 transition_delay_ns;
> +
> +	transition_delay_ns = cppc_get_transition_latency(cpu);
> +	if (transition_delay_ns == CPUFREQ_ETERNAL)
> +		return AMD_PSTATE_TRANSITION_DELAY;
> +
> +	return transition_delay_ns / NSEC_PER_USEC;
> +}
> +
> +/**
> + * Get pstate transition latency value from ACPI tables that firmware set
> + * instead of using hardcode value directly.
> + */
> +static u32 amd_pstate_get_transition_latency(unsigned int cpu)
> +{
> +	u32 transition_latency;
> +
> +	transition_latency = cppc_get_transition_latency(cpu);
> +	if (transition_latency  == CPUFREQ_ETERNAL)
> +		return AMD_PSTATE_TRANSITION_LATENCY;
> +
> +	return transition_latency;
> +}
> +
>  static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>  {
>  	int min_freq, max_freq, nominal_freq, lowest_nonlinear_freq, ret;
> @@ -867,8 +897,8 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>  		goto free_cpudata1;
>  	}
>  
> -	policy->cpuinfo.transition_latency = AMD_PSTATE_TRANSITION_LATENCY;
> -	policy->transition_delay_us = AMD_PSTATE_TRANSITION_DELAY;
> +	policy->cpuinfo.transition_latency = amd_pstate_get_transition_latency(policy->cpu);
> +	policy->transition_delay_us = amd_pstate_get_transition_delay_us(policy->cpu);
>  
>  	policy->min = min_freq;
>  	policy->max = max_freq;
> -- 
> 2.34.1
>