Received-SPF: pass (google.com: domain of linux-kernel+bounces-102889-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <8d076ed4-5c3c-499a-bca0-9bd51d5454cc@linux.intel.com>
Date: Wed, 13 Mar 2024 23:49:22 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH kernel v3] PCI/DOE: Support discovery version 2
Content-Language: en-US
To: Alexey Kardashevskiy <aik@amd.com>,
 Sathyanarayanan Kuppuswamy Natarajan <sathyanarayanan.nkuppuswamy@gmail.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
 Bjorn Helgaas <bhelgaas@google.com>, Ira Weiny <ira.weiny@intel.com>,
 Dan Williams <dan.j.williams@intel.com>,
 Jonathan Cameron <Jonathan.Cameron@huawei.com>,
 Lukas Wunner <lukas@wunner.de>
References: <20240307022006.3657433-1-aik@amd.com>
 <32ac2ee6-26b1-4f37-bd88-db1ef2a31267@linux.intel.com>
 <16120a31-c3d6-48a8-9355-7b063e28d242@amd.com>
 <CAC41dw9x8H2m=YB66+PA-GwiVkpCyT0PobdWvFXLHpAsQOE0ew@mail.gmail.com>
 <8d542410-d8e1-4243-939c-6ce7743a66f1@amd.com>
From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
In-Reply-To: <8d542410-d8e1-4243-939c-6ce7743a66f1@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 3/13/24 5:59 PM, Alexey Kardashevskiy wrote:
>
>
> On 7/3/24 17:22, Sathyanarayanan Kuppuswamy Natarajan wrote:
>> On Wed, Mar 6, 2024 at 10:09 PM Alexey Kardashevskiy <aik@amd.com> wrote:
>>>
>>>
>>>
>>> On 7/3/24 16:06, Kuppuswamy Sathyanarayanan wrote:
>>>>
>>>> On 3/6/24 6:20 PM, Alexey Kardashevskiy wrote:
>>>>> PCIe r6.1, sec 6.30.1.1 defines a "DOE Discovery Version" field in
>>>>> the DOE Discovery Request Data Object Contents (3rd DW) as:
>>>>>
>>>>> 15:8 DOE Discovery Version – must be 02h if the Capability Version in
>>>>> the Data Object Exchange Extended Capability is 02h or greater.
>>>>
>>>> Does this change fix any functional issue? If yes, please add Fixes:
>>>> tag and probably CC stable?
>>>
>>> The issue is that before this patch the DOE driver was following PCIe
>>> r6.0 and it was not working on a device with DOE cap v2 added in r6.1.
>>> Is it "fixes"?
>>>
>>
>> Since you are enabling support for the newer spec version, I think it will not
>> fall under bug fix. But it might be qualified for the stable branch.
>> It depends on
>> whether you want to support this device in older(stable) kernels.
>
>
> I am going to need lot more stuff (TSM, IDE, TDISP) in addition to this but it is coming much later so there is no point in pushing this alone to older kernels. Thanks,
>
>
Got it.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>


-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer