Received-SPF: pass (google.com: domain of linux-kernel+bounces-102910-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 14 Mar 2024 08:07:35 +0100
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: linux-spi@vger.kernel.org, Michael Walle <mwalle@kernel.org>, Pratyush
 Yadav <pratyush@kernel.org>, Mark Brown <broonie@kernel.org>, Michael Walle
 <michael@walle.cc>, "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>,
 Mika Westerberg <mika.westerberg@linux.intel.com>,
 linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH v2] spi: Fix error code checking in spi_mem_exec_op()
Message-ID: <20240314080735.5fe5b405@xps-13>
In-Reply-To: <20240313194530.3150446-1-florian.fainelli@broadcom.com>
References: <20240313194530.3150446-1-florian.fainelli@broadcom.com>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi Florian,

florian.fainelli@broadcom.com wrote on Wed, 13 Mar 2024 12:45:30 -0700:

> After commit cff49d58f57e ("spi: Unify error codes by replacing -ENOTSUPP with
> -EOPNOTSUPP"), our SPI NOR flashes would stop probing with the following
> visible in the kernel log:
> 
> [    2.196300] brcmstb_qspi f0440920.qspi: using bspi-mspi mode
> [    2.210295] spi-nor: probe of spi1.0 failed with error -95
> 
> It turns out that the check in spi_mem_exec_op() was changed to check
> for -ENOTSUPP (old error code) or -EOPNOTSUPP (new error code), but this
> means that for drivers that were converted, the second condition is now
> true, and we stop falling through like we used to. Fix the error to
> check for neither error being neither -ENOTSUPP *nor* -EOPNOTSUPP.
> 
> Fixes: cff49d58f57e ("spi: Unify error codes by replacing -ENOTSUPP with -EOPNOTSUPP")
> Reviewed-by: Michael Walle <mwalle@kernel.org>
> Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>

Thanks for the fix!

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>