Received-SPF: pass (google.com: domain of linux-kernel+bounces-102922-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <ea5d5bb6-32a5-4161-95cd-3dc916576bf7@linux.alibaba.com>
Date: Thu, 14 Mar 2024 15:19:45 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/3] mm/compaction: add and use
 for_each_populated_zone_pgdat() helper
To: Luis Chamberlain <mcgrof@kernel.org>, akpm@linux-foundation.org,
 jhubbard@nvidia.com, vbabka@suse.cz, mgorman@suse.de, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, dave@stgolabs.net, p.raghav@samsung.com,
 da.gomez@samsung.com
References: <20240314005436.2962962-1-mcgrof@kernel.org>
 <20240314005436.2962962-3-mcgrof@kernel.org>
From: Baolin Wang <baolin.wang@linux.alibaba.com>
In-Reply-To: <20240314005436.2962962-3-mcgrof@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2024/3/14 08:54, Luis Chamberlain wrote:
> We can just wrap most of the work done on fragmentation_score_node()
> into a pgdat helper for populated zones. Add the helper and use it.
> 
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>   include/linux/mmzone.h | 8 ++++++++
>   mm/compaction.c        | 9 ++-------
>   2 files changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index a497f189d988..1fd74c7100ec 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -1597,6 +1597,14 @@ extern struct zone *next_zone(struct zone *zone);
>   			; /* do nothing */		\
>   		else
>   
> +#define for_each_populated_zone_pgdat(zone, pgdat)	\
> +	for (zone = pgdat->node_zones;			\
> +	     zone;					\
> +	     zone = next_zone(zone))			\
> +		if (!populated_zone(zone))		\
> +			; /* do nothing */		\
> +		else

I think this will break the original logics, since the next_zone() will 
iterate over all memory zones, instead of only the memory zones of the 
specified node.

>   static inline struct zone *zonelist_zone(struct zoneref *zoneref)
>   {
>   	return zoneref->zone;
> diff --git a/mm/compaction.c b/mm/compaction.c
> index b961db601df4..023a09d0786d 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -2151,16 +2151,11 @@ static unsigned int fragmentation_score_zone_weighted(struct zone *zone)
>   static unsigned int fragmentation_score_node(pg_data_t *pgdat)
>   {
>   	unsigned int score = 0;
> +	struct zone *zone;
>   	int zoneid;
>   
> -	for (zoneid = 0; zoneid < MAX_NR_ZONES; zoneid++) {
> -		struct zone *zone;
> -
> -		zone = &pgdat->node_zones[zoneid];
> -		if (!populated_zone(zone))
> -			continue;
> +	for_each_populated_zone_pgdat(zone, pgdat)
>   		score += fragmentation_score_zone_weighted(zone);
> -	}
>   
>   	return score;
>   }