Received-SPF: pass (google.com: domain of linux-kernel+bounces-102959-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <9a38fd52-5eea-468d-bd7c-29a505503268@amlogic.com>
Date: Thu, 14 Mar 2024 16:08:33 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/4] arm64: dts: add support for A4 based Amlogic BA400
Content-Language: en-US
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Neil Armstrong <neil.armstrong@linaro.org>,
 Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
 Kevin Hilman <khilman@baylibre.com>, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-amlogic@lists.infradead.org
References: <20240312-basic_dt-v1-0-7f11df3a0896@amlogic.com>
 <20240312-basic_dt-v1-3-7f11df3a0896@amlogic.com>
 <1jsf0vephv.fsf@starbuckisacylon.baylibre.com>
From: Xianwei Zhao <xianwei.zhao@amlogic.com>
In-Reply-To: <1jsf0vephv.fsf@starbuckisacylon.baylibre.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ODhYTFZkclpVUVNwclI4L0pKM1FXaEIzV1hpTGRwNFI1MVRtMjRuVWMzbVB3?=
 =?utf-8?B?ejNUNWtOYmRwZU1RU0pweDJMd0VUNWIxelJyNVlDcVd1bU1PdXZiQ2d5OTVo?=
 =?utf-8?B?eWhDVytMZnA4TFlKRnBsbHNTTExQUW10MXpwaWxWZFU5RnNna1FDTnJHVFF4?=
 =?utf-8?B?bnRHRTJIRlZtdHJia1BhaEVCNXdnYk1Ib3B5ak9XaDRVVzJ3dkJFSldiSXpx?=
 =?utf-8?B?d1pneXlwOG85SEZ6bGQ2R2tVSlBKb0VDQkhBRTNLRkVxendKdENuVzhsbCtW?=
 =?utf-8?B?bVRDTEhxVHUwUHpnaWl6VEtRVHJ5cVRJRVFqdGtKQk9YYWZYSXQvSmpuSU5y?=
 =?utf-8?B?VVNtaUd4Nm52YW9xbDM3YTVGMjhKVGhDekxtVmpCVTdaVEwwZXR0dktqaHBr?=
 =?utf-8?B?a2ZGMEpOc0JXUDFFYXZFNC9aMlIwRHlZc21wVEVFblp6eWNXUUdSRjgyOUgz?=
 =?utf-8?B?TkVtZVRkVWFwdEZsaU5wa3RueW5KakxPQUl4Q3MzSmQzUHJjVVBYeStZWldN?=
 =?utf-8?B?Zk01QVAwNVpheXFaeENhVXFzV0Z0d21pQllaWFRGaUtlRE02WVBjUW5uUnNG?=
 =?utf-8?B?eCtzRXd1Rjg0T3lQTWNLdXdjVnhvYnl1UUxLRlJWK1RLaXJwKytFQ3pRN0k4?=
 =?utf-8?B?ZUkyTnYrSncyengxWGpPNTd2aXB6eE81cWRlK2dkcEpldXNpR0tzNmdqblJL?=
 =?utf-8?B?b0xUU1lVN1dNMzF4Q3hKWkhtUHhMY083RkxDcHZ4SXRiN0tzYXJpREJxOFdx?=
 =?utf-8?B?S3l0Rk1ldFIycG5FMHpYby9ucmpGT0xXcURFSTQ2VW5JdEhDd0pleTE3bmNa?=
 =?utf-8?B?aTRWNzQxLzY3REp5MnZqa1lQcGloRGExb2REUHZxaGphaGE4Y3FNRWF2VWFK?=
 =?utf-8?B?S0JHaC9CMHVEN0FOaitJMG5nanVwT2N4RTY0VjkxcGdtd3RrQ0I2dTZMZ2xF?=
 =?utf-8?B?S282Y2VudUdlc283QjJ1RXVKVE0vY2d0VVlQaVB5aTdXamtZU2Jra0ZCbXor?=
 =?utf-8?B?THBidjVuVDZiOFV2QXhkUTZhTjNZdXdyd1pTWEs4VWxLS1U1bWtCcWE4Mkoz?=
 =?utf-8?B?aUwvRjZnYmlzUXo1WEZQbVhLQUNYNXdGWWo4M2lxcFFyemgzQkhycW9XR3I1?=
 =?utf-8?B?b0NHTEdrOVlxNlBTOEpuWktodlhzaGdDVEhSZUVkaFZYREE2UVRYeEp1ZWY0?=
 =?utf-8?B?Mm9TMUFOWnVQbHkyQ0VBK3RlVjdpL2NjOTd6N1M1WG43MVNqUEc4cEZjdDkv?=
 =?utf-8?B?QXVhWkJkaHFxV3VWbVdOWnp3Si9waWNGWFN1bGVNbElWS0RNanJ3U0dGS3o1?=
 =?utf-8?B?bUNONTZEQ0RrM21QRnNZaFNHWWx4QjlzNHNUL3FPekZjTlR6bGhjajV0cWQ5?=
 =?utf-8?B?SFBvNzhYMDFQa3dlTXhKWnNpNHRxMWNtSEdsMVpmTXV2SjNRcDZBYjNiTHdD?=
 =?utf-8?B?MnM2K2FBb0VvUVY1WkxrL3FqckRXQmdiMjRZWFZUaUlEUytRUlZWN1E2aFBx?=
 =?utf-8?B?bkozSUJpL1NOd3B5RmcrRDJsK1V0Qjdwc0R4UUdibzVZU3VUYVdTNWU2ZFlG?=
 =?utf-8?B?cG9haUp1SUl4OEFwR0JWZDczNXkyUmJMeTRGQ3VOZUJkeXRHNUdSdndycTJQ?=
 =?utf-8?B?WTNYRGJWcjRtdWs5S2htZVhqaUpHWnNkYUl6eFZOamQ5bmFxcTh4MFJHSXVX?=
 =?utf-8?B?eXNhQ0ZyQzVPaGZQNHZXUEF1VzllKytmeVBrekN1aW9Ob0dSdHlUbElJOTFq?=
 =?utf-8?B?VnJkck1lZkt5dkhZZXdHdUxLZ0VrTlhSbEFRRVRSZ0pLMm1yTDRrL0p2Z2I1?=
 =?utf-8?B?ckVQVTBlL05sMHlBZ2J5cWd4dUpXZUY2RzJDWHhBcGJGczdLdHJ5UE5uVm1O?=
 =?utf-8?B?RTlxcHBSb29CTitydVltbGNVZjdxQWxjUTFsb25kS3FUT1AzM0N2bVY1S1NI?=
 =?utf-8?B?aDV1U3JOZzhEYzBaaFdJTXVhbXNPNi9OdVlkOE0rcGNQcXh3L29Fb1FEaXRz?=
 =?utf-8?B?WXZ0bmdnZlp2eHZxa1RHTGtRaXJtRWZMVUlaZWVEQnZ5b1RicS9neWRsZU4z?=
 =?utf-8?B?OHlyN2M0MXNzYnJQOTc2VExWYnJSMThrbE5qT2E3T3VCUzFtUHQ5U0RjU0pp?=
 =?utf-8?B?TUZSVUg1T2VTaHhncGNocHhRRi9wUTJwS1pWSEthM21zOERQYkVMYVlkMGpF?=
 =?utf-8?B?Umc9PQ==?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98c93cad-d03a-49e2-f0d8-08dc43fdf6c1
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6896.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 08:08:42.7250
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +CEKE9Fu/0UgUR1QRqu+USaUvQNZDG9RI2W2Okzv2+5M2LIL7MNMR63jlNp9F9H1fca6oAEw28mhZfq+fZuzbGvIMXpgsSBoc4OLrAXPeEA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR03MB8544

Hi Jerome,
    Thanks for your review.

On 2024/3/12 17:55, Jerome Brunet wrote:
> [ EXTERNAL EMAIL ]
> 
> On Tue 12 Mar 2024 at 17:18, Xianwei Zhao via B4 Relay <devnull+xianwei.zhao.amlogic.com@kernel.org> wrote:
> 
>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> Amlogic A4 is an application processor designed for smart audio
>> and IoT applications.
>>
>> Add basic support for the A4 based Amlogic BA400 board, which describes
>> the following components: CPU, GIC, IRQ, Timer and UART.
>> These are capable of booting up into the serial console.
>>
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>>   arch/arm64/boot/dts/amlogic/Makefile               |  1 +
>>   .../boot/dts/amlogic/amlogic-a4-a113l2-ba400.dts   | 43 ++++++++++
>>   arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi        | 99 ++++++++++++++++++++++
>>   3 files changed, 143 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
>> index 1ab160bf928a..9a50ec11bb8d 100644
>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>> @@ -1,4 +1,5 @@
>>   # SPDX-License-Identifier: GPL-2.0
>> +dtb-$(CONFIG_ARCH_MESON) += amlogic-a4-a113l2-ba400.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-c3-c302x-aw409.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-an400.dtb
>>   dtb-$(CONFIG_ARCH_MESON) += amlogic-t7-a311d2-khadas-vim4.dtb
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4-a113l2-ba400.dts b/arch/arm64/boot/dts/amlogic/amlogic-a4-a113l2-ba400.dts
>> new file mode 100644
>> index 000000000000..60f9f23858c6
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4-a113l2-ba400.dts
>> @@ -0,0 +1,43 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2024 Amlogic, Inc. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "amlogic-a4.dtsi"
> 
> Could you describe how the a4 and a5 differs from each other ?
> The description given in the commit description is the same.
> 
> Beside the a53 vs a55, I'm not seeing much of a difference.
> Admittedly, there is not much yet but I wonder if a4 and a5 should have
> a common dtsi.
> 
They are mostly the same, A5 include HiFi-DSP and NPU, but A4 is not. 
And  some peripheral modules are different, such as SPI and Ehernet phy.

I would like to wait for the follow-on chips to come out before 
considering a merger with common dtsi file.

>> +
>> +/ {
>> +     model = "Amlogic A113L2 ba400 Development Board";
>> +     compatible = "amlogic,ba400","amlogic,a4";
>> +     interrupt-parent = <&gic>;
>> +     #address-cells = <2>;
>> +     #size-cells = <2>;
>> +
>> +     aliases {
>> +             serial0 = &uart_b;
>> +     };
>> +
>> +     memory@0 {
>> +             device_type = "memory";
>> +             reg = <0x0 0x0 0x0 0x40000000>;
>> +     };
>> +
>> +     reserved-memory {
>> +             #address-cells = <2>;
>> +             #size-cells = <2>;
>> +             ranges;
>> +
>> +             /* 52 MiB reserved for ARM Trusted Firmware */
> 
> That's a lot of memory to blindly reserve.
> Any chance we can stop doing that and have u-boot amend reserved memory
> zone based on the actual needs of the device ?
Yes. U-boot will change size of reserved memory base on actual usage.
> 
>> +             secmon_reserved:linux,secmon {
>> +                     compatible = "shared-dma-pool";
>> +                     no-map;
>> +                     alignment = <0x0 0x400000>;
>> +                     reg = <0x0 0x05000000 0x0 0x3400000>;
>> +             };
>> +     };
>> +};
>> +
>> +&uart_b {
>> +     status = "okay";
>> +};
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> new file mode 100644
>> index 000000000000..7e8745010b52
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> @@ -0,0 +1,99 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2024 Amlogic, Inc. All rights reserved.
>> + */
>> +
>> +#include <dt-bindings/interrupt-controller/irq.h>
>> +#include <dt-bindings/interrupt-controller/arm-gic.h>
>> +#include <dt-bindings/gpio/gpio.h>
>> +/ {
>> +     cpus {
>> +             #address-cells = <2>;
>> +             #size-cells = <0>;
>> +
>> +             cpu0: cpu@0 {
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a53";
>> +                     reg = <0x0 0x0>;
>> +                     enable-method = "psci";
>> +             };
>> +
>> +             cpu1: cpu@1 {
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a53";
>> +                     reg = <0x0 0x1>;
>> +                     enable-method = "psci";
>> +             };
>> +
>> +             cpu2: cpu@2 {
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a53";
>> +                     reg = <0x0 0x2>;
>> +                     enable-method = "psci";
>> +             };
>> +
>> +             cpu3: cpu@3 {
>> +                     device_type = "cpu";
>> +                     compatible = "arm,cortex-a53";
>> +                     reg = <0x0 0x3>;
>> +                     enable-method = "psci";
>> +             };
>> +     };
>> +
>> +     timer {
>> +             compatible = "arm,armv8-timer";
>> +             interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
>> +     };
>> +
>> +     psci {
>> +             compatible = "arm,psci-0.2";
> 
> Really ? still on the that old version ?
> Will fix it. Use psci-1.0
>> +             method = "smc";
>> +     };
>> +
>> +     xtal: xtal-clk {
>> +             compatible = "fixed-clock";
>> +             clock-frequency = <24000000>;
>> +             clock-output-names = "xtal";
>> +             #clock-cells = <0>;
>> +     };
>> +
>> +     soc {
>> +             compatible = "simple-bus";
>> +             #address-cells = <2>;
>> +             #size-cells = <2>;
>> +             ranges;
>> +
>> +             gic: interrupt-controller@fff01000 {
>> +                     compatible = "arm,gic-400";
>> +                     #interrupt-cells = <3>;
>> +                     #address-cells = <0>;
>> +                     interrupt-controller;
>> +                     reg = <0x0 0xfff01000 0 0x1000>,
>> +                           <0x0 0xfff02000 0 0x2000>,
>> +                           <0x0 0xfff04000 0 0x2000>,
>> +                           <0x0 0xfff06000 0 0x2000>;
>> +                     interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
>> +             };
>> +
>> +             apb@fe000000 {
>> +                     compatible = "simple-bus";
>> +                     reg = <0x0 0xfe000000 0x0 0x480000>;
>> +                     #address-cells = <2>;
>> +                     #size-cells = <2>;
>> +                     ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
>> +
>> +                     uart_b: serial@7a000 {
>> +                             compatible = "amlogic,meson-s4-uart",
>> +                                          "amlogic,meson-ao-uart";
>> +                             reg = <0x0 0x7a000 0x0 0x18>;
>> +                             interrupts = <GIC_SPI 169 IRQ_TYPE_EDGE_RISING>;
>> +                             clocks = <&xtal>, <&xtal>, <&xtal>;
>> +                             clock-names = "xtal", "pclk", "baud";
>> +                             status = "disabled";
>> +                     };
>> +             };
>> +     };
>> +};
> 
> 
> --
> Jerome