Received-SPF: pass (google.com: domain of linux-kernel+bounces-102973-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7035e229-569d-4cf5-acc3-6ea575e859b0@amd.com>
Date: Thu, 14 Mar 2024 14:01:04 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] cdx: Convert to platform remove callback returning void
To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Abhijit Gangurde <abhijit.gangurde@amd.com>,
 Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>,
 Puneet Gupta <puneet.gupta@amd.com>, Rob Herring <robh@kernel.org>,
 linux-kernel@vger.kernel.org, kernel@pengutronix.de
References: <5d40f57e978bcce003133306712ec96439e93595.1709886922.git.u.kleine-koenig@pengutronix.de>
Content-Language: en-US
From: "Gupta, Nipun" <nipun.gupta@amd.com>
In-Reply-To: <5d40f57e978bcce003133306712ec96439e93595.1709886922.git.u.kleine-koenig@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QmJHem9QQ3lXeUd3Q3QrWWMySU91YkhnSGhWWU1TRjBLcWdtT0dQbWtuN3pr?=
 =?utf-8?B?N1MzQ3RzV3ovOWloWURpcEhYNGxWUkRNNWltemdROG14WDMybFdLQjJuUnlq?=
 =?utf-8?B?dlptK0tDUWZ2NTlCeExteFJrN203bzYxL3VrUDZlSGN3eEVReFRNTnVleFZj?=
 =?utf-8?B?a0xkRi9HZDVIcitIVTVRZXpGeUw0RXNHUVY4S0tzTVVuSUc0ekIzYWZ6clF2?=
 =?utf-8?B?eEVrTWQxMVdBamZ6V0RocUxmdFExNThsdWs0dEk3aDBHT2ptM1VkMFFmaHdp?=
 =?utf-8?B?UGdjb2tUVDFmNHg3TzhGQ3Y2L0o3NDdYdTRsV3dvZjBHUTM3Z3NhSTc2Yndt?=
 =?utf-8?B?UXN3RU1HV01XbkVhMHlqeTYxMUFnT0d3VW1qSVVTYXgvSnFQV1BIbUVQN3FO?=
 =?utf-8?B?dk5BaXJsYVk0a1g3OG5xNXpoMjhWa0RsR3JudTR1aHJpRm1ranFoMFlScDho?=
 =?utf-8?B?RmVzUlg1NHl1bVd4L2xKR1RodWhkeVMxc21nK3V2Q0w0L2pmV0F5SWhHNDhV?=
 =?utf-8?B?dC9EdWNLc3pMenFWbTlGQnh3ZlJUVmJRKzdlY0xZUkdKdFNuNXEwTGtPcTFU?=
 =?utf-8?B?MG95SldSTEdpelBDNXl1bEtQbkU2a0hkRGJTY0QvbS9SLzhqUGpQTmh4dmda?=
 =?utf-8?B?TGpjWkpIN0kveVF1WC9JcXV4cnRsbnZnZXIyMGJVNXBnTHh2b2ZDb1pKWkdz?=
 =?utf-8?B?QmZBR3YwUTd1emtkMjVPM1l5V0JkQnM3eFhBa2lBcGlSN01WdnBydjN4SExO?=
 =?utf-8?B?U0JEMEpweXZYeklseUYwRnhISnFQWExoZmZveGxrSmdpdlA1aUdPZEkvYlRI?=
 =?utf-8?B?QXowUXhWc3Bvbm8rNlR4YnhhSVlHK0ZSdWZ5QnEzWmhpOGlOVzhlWTYyVnZH?=
 =?utf-8?B?QXc1S0lkOGVSVE43bHV1elF4TGtnY0lzNlNaZWQrZFduWHQrTDZpa3ZIemV6?=
 =?utf-8?B?eExudDBseUthaXUvNTlKZzl2SnFMZGtZdStpVFQ5NXhSWFo0VkVCS0k2M3hQ?=
 =?utf-8?B?ZHVnSnFQUEtaU2ZhN0VsRk9yL3Y1Y3ZZVk1hcDhmNnM5dzVPeHpLZWp3NlRS?=
 =?utf-8?B?SW9HNzFmUXVobG5VM1FQUXhtUWFmejgwb25yRStPT2F4bHRQT2NtV1pRK1pp?=
 =?utf-8?B?ck8yUGFsVHVManQxWW1aT1Rza0NGdG9oVlRCbzVpV2dKaDVoWlVSV0JoZUww?=
 =?utf-8?B?eEwzOVJMcjdLZzB3bkxHSERSZVNQVmZPRlZLdXJJTlkvLzNnRjI4NGdkaWQw?=
 =?utf-8?B?bFlWeHRPK0x2Y2s1M3hIVUE1bStTWjdkai95NW9WTCtQZWJjNmU0MWlZV0ht?=
 =?utf-8?B?VFVZYzJ5QnA1TlR5SUFkK3ErTmZWWU9VMVpBdWNRZkhrVWlVYjZidFBmS0ZF?=
 =?utf-8?B?YzMrdGtZYlVBdG1tMENFR3BHYkdMeUlHSk50ZXQxdTBjRWI1M0tORkgxeVR2?=
 =?utf-8?B?NHd4L1VPdlVlUTZYNHdGeWhTaytxb29vRlNWdksvQXhzTHp1WFQ3MWlGRURt?=
 =?utf-8?B?MGlpK29ucTBkMk8rcmdQa1NnWmVjSXk0aXkxYUpEbSs4S2EraGw4WGk5TWxy?=
 =?utf-8?B?NmZSanhYY2gvOGQ2bEVNL2JDcDhNS05aS1VIdXlzV00vbUdlMnZ3RkkwSmxm?=
 =?utf-8?B?aXFJZGp3ZE9scFFUcVVRQktGaWc5L3FKcHkwWjNrWVZxZ0J5ZUJlb1Rxc0Ri?=
 =?utf-8?B?cVp3K21CTjJrZk4yb3YrQ1g3Wjh1bE5FN3Z5YVo4Yld1eFJ4b0RBWS9yd3NG?=
 =?utf-8?B?d0liMUFXZk9hcmJkay93WENhRzd6SG5ISVBYclR1MHJHdEQ3dmtuQklZOUdX?=
 =?utf-8?B?VXY1OCtCK2p4UWp5OXpiNEppSWtqZW1OOTVIbDliZEo5T2lzN3FHT082aXpt?=
 =?utf-8?B?eWNIMyt1S1M0NDlOUWVEemV6LzNJdkhid0t1Vi9kc09MeUJUQ1g4ay9NR3Fs?=
 =?utf-8?B?bW9ZeXdGK1crN1d5Q2syY3dPb0VsOU1xTUkyZ1RQSDhyNTE4em9CcVhSSXVR?=
 =?utf-8?B?ejFjdDhCMUhzbFgyOGhkU0hKdWFNbTlBQmcva1YwZG9TUjhocUlLd1Rub3Vv?=
 =?utf-8?B?QTM1VUFZRkt2aWRkS0dkY0licTJCT3l0MzBMeStxbmgrMCszZE1KOHgwUkc0?=
 =?utf-8?Q?hhquoE4SdYO7iM33uUm1QVZMx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9f0804a-6a0b-4332-4055-08dc44011ca9
X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9193.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 08:31:15.0104
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FyUJEclSm3KlpCLuoGpO9jRNb31Qy6ESpQUyBISZgU+CsBcwum3yYmuJ7gkE2XL+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6751


On 3/8/2024 2:21 PM, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Acked-by: Nipun Gupta <nipun.gupta@amd.com>