Received-SPF: pass (google.com: domain of linux-kernel+bounces-103040-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <a09941ff-7b43-a964-1bd1-5321913be1a3@quicinc.com>
Date: Thu, 14 Mar 2024 14:49:37 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH 1/3] dt-bindings: clock: qcom: Update SM8150 videocc
 bindings
Content-Language: en-US
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
CC: Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>,
        Rob Herring <robh@kernel.org>,
        "Krzysztof
 Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley
	<conor+dt@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        "Stephen
 Boyd" <sboyd@kernel.org>,
        Ajit Pandey <quic_ajipan@quicinc.com>,
        Imran Shaik
	<quic_imrashai@quicinc.com>,
        Taniya Das <quic_tdas@quicinc.com>,
        "Jagadeesh
 Kona" <quic_jkona@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>
References: <20240313-videocc-sm8150-dt-node-v1-0-ae8ec3c822c2@quicinc.com>
 <20240313-videocc-sm8150-dt-node-v1-1-ae8ec3c822c2@quicinc.com>
 <CAA8EJpo63oRA07QNCdzJdHW_hJJWK6aj-LCpp-XwmPJYf0twZw@mail.gmail.com>
From: "Satya Priya Kakitapalli (Temp)" <quic_skakitap@quicinc.com>
In-Reply-To: <CAA8EJpo63oRA07QNCdzJdHW_hJJWK6aj-LCpp-XwmPJYf0twZw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 3/14/2024 12:50 AM, Dmitry Baryshkov wrote:
> On Wed, 13 Mar 2024 at 13:11, Satya Priya Kakitapalli
> <quic_skakitap@quicinc.com> wrote:
>> Update the videocc device tree bindings for sm8150 to align with the
>> latest convention.
> But why? Bindings already exist. There is nothing wrong with them. And
> sm8150 platform in general uses name-based lookup.


With the new index based lookup introduced we cannot use this bindings, 
hence I moved to the sm8450-videocc bindings.


>> Fixes: 35d26e9292e2 ("dt-bindings: clock: Add YAML schemas for the QCOM VIDEOCC clock bindings")
> It is not a fix, there is no bug that this commit is fixing.


The clocks list needs to be fixed to add both XO and AHB clocks, and we 
are adding required-opps property.


>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml | 1 +
>>   Documentation/devicetree/bindings/clock/qcom,videocc.yaml        | 3 ---
>>   2 files changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
>> index bad8f019a8d3..e00fdc8ceaa4 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
>> @@ -20,6 +20,7 @@ properties:
>>       enum:
>>         - qcom,sm8450-videocc
>>         - qcom,sm8550-videocc
>> +      - qcom,sm8150-videocc
>>
>>     reg:
>>       maxItems: 1
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>> index 6999e36ace1b..28d134ad9517 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>> @@ -17,7 +17,6 @@ description: |
>>       include/dt-bindings/clock/qcom,videocc-sc7180.h
>>       include/dt-bindings/clock/qcom,videocc-sc7280.h
>>       include/dt-bindings/clock/qcom,videocc-sdm845.h
>> -    include/dt-bindings/clock/qcom,videocc-sm8150.h
>>       include/dt-bindings/clock/qcom,videocc-sm8250.h
>>
>>   properties:
>> @@ -26,7 +25,6 @@ properties:
>>         - qcom,sc7180-videocc
>>         - qcom,sc7280-videocc
>>         - qcom,sdm845-videocc
>> -      - qcom,sm8150-videocc
>>         - qcom,sm8250-videocc
>>
>>     clocks:
>> @@ -75,7 +73,6 @@ allOf:
>>             enum:
>>               - qcom,sc7180-videocc
>>               - qcom,sdm845-videocc
>> -            - qcom,sm8150-videocc
>>       then:
>>         properties:
>>           clocks:
>>
>> --
>> 2.25.1
>>
>>
>