Received-SPF: pass (google.com: domain of linux-kernel+bounces-103068-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 14 Mar 2024 15:11:36 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To: Perry Yuan <perry.yuan@amd.com>
Cc: rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com,
	viresh.kumar@linaro.org, Ray.Huang@amd.com, Borislav.Petkov@amd.com,
	Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
	Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/7] cpufreq: amd-pstate: implement cpb_boost sysfs
 entry for boost control
Message-ID: <ZfLGUHRBV+1ICzp4@BLR-5CG11610CF.amd.com>
References: <cover.1710322310.git.perry.yuan@amd.com>
 <42a36c7f788e0fb77d4be7575aab9c937e1773de.1710322310.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <42a36c7f788e0fb77d4be7575aab9c937e1773de.1710322310.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?6ncJQqcvzDCC8RVqmFabxd5rxOsTPj9eMTUySyMltYjXNEsjJe9Eh0Owt4np?=
 =?us-ascii?Q?QuJqu46Lj6C8Kt5UbK6N2ScJMVwn1azdXQthqPM1n8o004Giw70Iqj2bSZnr?=
 =?us-ascii?Q?xD7evTzXF9YtPYyEAC1L3DbmjRUzwtGJe/vPJvC+Xu35t8lxckZwxTsDZ/cp?=
 =?us-ascii?Q?D76dhOxc2o9juEqugbblmbBpRh/Pa/ElDKufgvGeUouhLbg1RQINXWFHFiv9?=
 =?us-ascii?Q?ncIQPB/Xjo6sqbyryXU7Ff7YM8+xlERIralz1GTvRqG0K5iu7s8aEzqBayNK?=
 =?us-ascii?Q?ThzRYjZdykeaW5Binzd0umjAhM4vuiYkZYOZNkkMYbNkxYItfVe/z+49Nc+Q?=
 =?us-ascii?Q?qphTZV7EG1SpdPT3iBHsaLSAWeGKh949MSvET0TB0/AhlkeEUZsWLFLnoXEM?=
 =?us-ascii?Q?FEztMyRRLPfc0lHSOt6BijDl6diQmUzf0/rzWgkPEnc2Bui3X+soBQifRAHF?=
 =?us-ascii?Q?6tF1Ncx7Nhuq5DeRd8ezVlKyGr8t/TkwwZQ7KdwHy83aeKKor+z2KGRpjMSL?=
 =?us-ascii?Q?O1zlCJiQeqjLKDY4VC+suSDEx4UcLH4YiSLay7AkWrzx73GqMxYyB9nwmLOy?=
 =?us-ascii?Q?yn7xkW5dhxlzxu/8rmsnHj98cvkwlDc/tMu7F2yfkoG+D06wVAIkBucxz1GO?=
 =?us-ascii?Q?EHmQDPGURu2MZsPmKm3QIMa/ZvGyPxSGjQwZxMDd3E5wQxl5yP77T6DIUZ3c?=
 =?us-ascii?Q?9P5kvafOHUbMYy1La/oYsrDbQum411J60p2iiv8JQKDT/q07QSzp2CU0B15V?=
 =?us-ascii?Q?KpyrZb+lt5uyxI3taQYoWArZk6c5Skgacq4SCB3lHm8KnDyzlpL8KzHJZHhg?=
 =?us-ascii?Q?sf7LELCX0F4TyQWvGQX9c9wzG2WIET0qJ/lSmRQ/ONN+K59MvmeJCX/+2BV2?=
 =?us-ascii?Q?khk8pwRGiFRyhCgnow8CxdQB09tLKC4jqQ/fd17JJx4xdOfvA994E91sxS/U?=
 =?us-ascii?Q?WnVfK2QZiTny5kZW39p1ZJrlD0pKmcSorkgpNU3ZIh6qKigqfZiWcA9CSAa0?=
 =?us-ascii?Q?wrd3DHwwjHONdjxUbxVT+H9io8JFOv8XUjoaz71DNX/xz1WJSTHIsRe+Iq1W?=
 =?us-ascii?Q?p5e8Fmucsu/tlGtTGD/AIPuwYIMKN/Nb4tQHqdGJkcFONNeeMp6y2bHFwiIq?=
 =?us-ascii?Q?ajZmwymqH4LaVF6Lwh9+6Zm8UVKksPNoa/wS0WM0ymRWG0Tevm2Z+Wg3qjGd?=
 =?us-ascii?Q?fPoOA496mGCjd93JeXnNGYaVGZAVSi1h/dOfs+wjHupbDE5CgWQG0+zto8VG?=
 =?us-ascii?Q?YY2jdwmJww2pOCaVVsxuoMfr1ncRxB0Sk/SPAbs6deSq6lhQ1NtL7Q4irsax?=
 =?us-ascii?Q?NmFl7r1t5OOp4lRg01ccbczCRAvwkX7v/S7AYwDTVibD4PcBsAZ+JXmQ7Qmb?=
 =?us-ascii?Q?wQYalLuHhisWRwDhq///QpxCgzV0xMmo5YBwBC2I+20q4sEMCgDODom4mmQb?=
 =?us-ascii?Q?CIXthndnIjJDHjuCSGLDt+0GIjdIeYvBCS+6l4ACZqG0J+wM2J59n7bVEWi5?=
 =?us-ascii?Q?aeW1GE8vYkUltI3fzMTX+TvqQnJIO7tNaC9ZOtABfzQHzKqCibPRTdEkUvaR?=
 =?us-ascii?Q?86d65p8eprx7GrI7uDKNErrVDdZ+1Oj5BPrzbshW?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74403207-8e02-4c97-b0e1-08dc440af57e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB8252.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 09:41:44.5864
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LxzJk00Ti2IGxGApKPnYmoSF4ChnQv7fSJD8bUVF3znYul56WLBderOYPXtNtniESPUCATMfN9eXPD4Z+vAllw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7162

Hello Perry,


On Wed, Mar 13, 2024 at 06:04:39PM +0800, Perry Yuan wrote:
> From: Perry Yuan <Perry.Yuan@amd.com>
> 
> With this new sysfs entry `cpb_boost`created, user can change CPU boost
> state dynamically under `active`, `guided` and `passive` modes.
> And the highest perf and frequency will also be updated as the boost
> state changing.
> 
> 0): check current boost state
> cat /sys/devices/system/cpu/amd_pstate/cpb_boost

Could you please elaborate on the need for this new interface when
/sys/devices/system/cpu/cpufreq/boost exists and is being used in the
other cpufreq driver namely the acpi-cpufreq driver ?

The semantics of this new interface seems to be identical to the
existing boost interface.

I am ok with the rest of the patch, but please explain the need for a
new interface.

--
Thanks and Regards
gautham.

> 
> 1): disable CPU boost
> sudo bash -c "echo 0 > /sys/devices/system/cpu/amd_pstate/cpb_boost"
> 
> 2): enable CPU boost
> sudo bash -c "echo 1 > /sys/devices/system/cpu/amd_pstate/cpb_boost"
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217931
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217618
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 97 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 97 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index ef6381b48e76..d54399ebb758 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1208,6 +1208,101 @@ static ssize_t prefcore_show(struct device *dev,
>  	return sysfs_emit(buf, "%s\n", str_enabled_disabled(amd_pstate_prefcore));
>  }
>  
> +static int amd_cpu_boost_update(struct amd_cpudata *cpudata, u32 on)
> +{
> +	struct cpufreq_policy *policy = cpufreq_cpu_acquire(cpudata->cpu);
> +	struct cppc_perf_ctrls perf_ctrls;
> +	u32 highest_perf, nominal_perf;
> +	int ret;
> +
> +	if (!policy)
> +		return -ENODATA;
> +
> +	highest_perf = READ_ONCE(cpudata->highest_perf);
> +	nominal_perf = READ_ONCE(cpudata->nominal_perf);
> +
> +	if (boot_cpu_has(X86_FEATURE_CPPC)) {
> +		u64 value = READ_ONCE(cpudata->cppc_req_cached);
> +
> +		value &= ~GENMASK_ULL(7, 0);
> +		value |= on ? highest_perf : nominal_perf;
> +		WRITE_ONCE(cpudata->cppc_req_cached, value);
> +
> +		wrmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, value);
> +
> +	} else {
> +		perf_ctrls.max_perf = on ? highest_perf : nominal_perf;
> +		ret = cppc_set_epp_perf(cpudata->cpu, &perf_ctrls, 1);
> +		if (ret) {
> +			pr_debug("failed to set energy perf value (%d)\n", ret);
> +			return ret;
> +		}
> +	}
> +
> +	if (on)
> +		policy->cpuinfo.max_freq = cpudata->max_freq;
> +	else
> +		policy->cpuinfo.max_freq = cpudata->nominal_freq * 1000;
> +
> +	policy->max = policy->cpuinfo.max_freq;
> +
> +	if (cppc_state == AMD_PSTATE_PASSIVE) {
> +		ret = freq_qos_update_request(&cpudata->req[1],
> +				      policy->cpuinfo.max_freq);
> +	}
> +
> +	cpufreq_cpu_release(policy);
> +
> +	return ret;
> +}
> +
> +static ssize_t cpb_boost_show(struct device *dev,
> +			   struct device_attribute *attr, char *buf)
> +{
> +	return sysfs_emit(buf, "%u\n", amd_pstate_global_params.cpb_boost);
> +}
> +
> +static ssize_t cpb_boost_store(struct device *dev, struct device_attribute *b,
> +			    const char *buf, size_t count)
> +{
> +	bool new_state;
> +	ssize_t ret;
> +	int cpu;
> +
> +	mutex_lock(&amd_pstate_driver_lock);
> +	if (!amd_pstate_global_params.cpb_supported) {
> +		pr_err("Boost mode is not supported by this processor or SBIOS\n");
> +		return -EINVAL;
> +	}
> +
> +	ret = kstrtobool(buf, &new_state);
> +	if (ret)
> +		return -EINVAL;
> +
> +	amd_pstate_global_params.cpb_boost = !!new_state;
> +
> +	for_each_online_cpu(cpu) {
> +
> +		struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);
> +		struct amd_cpudata *cpudata = policy->driver_data;
> +
> +		if (!cpudata) {
> +			pr_err("cpudata is NULL\n");
> +			ret = -ENODATA;
> +			cpufreq_cpu_put(policy);
> +			goto err_exit;
> +		}
> +
> +		amd_cpu_boost_update(cpudata, amd_pstate_global_params.cpb_boost);
> +		refresh_frequency_limits(policy);
> +		cpufreq_cpu_put(policy);
> +	}
> +
> +err_exit:
> +	mutex_unlock(&amd_pstate_driver_lock);
> +	return ret < 0 ? ret : count;
> +}
> +
>  cpufreq_freq_attr_ro(amd_pstate_max_freq);
>  cpufreq_freq_attr_ro(amd_pstate_lowest_nonlinear_freq);
>  
> @@ -1218,6 +1313,7 @@ cpufreq_freq_attr_rw(energy_performance_preference);
>  cpufreq_freq_attr_ro(energy_performance_available_preferences);
>  static DEVICE_ATTR_RW(status);
>  static DEVICE_ATTR_RO(prefcore);
> +static DEVICE_ATTR_RW(cpb_boost);
>  
>  static struct freq_attr *amd_pstate_attr[] = {
>  	&amd_pstate_max_freq,
> @@ -1242,6 +1338,7 @@ static struct freq_attr *amd_pstate_epp_attr[] = {
>  static struct attribute *pstate_global_attributes[] = {
>  	&dev_attr_status.attr,
>  	&dev_attr_prefcore.attr,
> +	&dev_attr_cpb_boost.attr,
>  	NULL
>  };
>  
> -- 
> 2.34.1
>