Received-SPF: pass (google.com: domain of linux-kernel+bounces-103070-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 14 Mar 2024 15:13:21 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To: Perry Yuan <perry.yuan@amd.com>
Cc: rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com,
	viresh.kumar@linaro.org, Ray.Huang@amd.com, Borislav.Petkov@amd.com,
	Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
	Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/7] cpufreq: amd-pstate: fix max_perf calculation for
 amd_get_max_freq()
Message-ID: <ZfLGuSzbTS9vSGfY@BLR-5CG11610CF.amd.com>
References: <cover.1710322310.git.perry.yuan@amd.com>
 <1da9848e022c49fef0a8cc390feba95c74be531d.1710322310.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1da9848e022c49fef0a8cc390feba95c74be531d.1710322310.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?/KYHAlGGoK+UophIbpdQXqPEpQcp6U8qNsLF1ChI/Pbw0CdlDJJsHYcnk0GR?=
 =?us-ascii?Q?MbZACmSiBgYr4Vl+GIh4r0B0eUxXxaroH/gbU/jSY15D8y2OP+dAqYvb2ZG2?=
 =?us-ascii?Q?4oRoAi4gNzu37i3E9t+YKbMiGd+2ZqI3l3SAf/d5b+Yd7BM2VTzT1OXWdEyN?=
 =?us-ascii?Q?P3TKfblqm+TGpu3s8rAeAzsf+b8ZpolFuXtfGb6EfJl9mjau6xnlpyBuZ8Hg?=
 =?us-ascii?Q?UM9UvC65DOvWMPlP7PoeBMOHZ1D1rHfcRJxe+pv0HDfbHXAf9AKH8sxG8Ztl?=
 =?us-ascii?Q?vUsN59BKhh4mRS/DKtkV0u7gnM7YdmNySQ18NI1jhri32665IWCtYFRwvm8o?=
 =?us-ascii?Q?Vm4KLFR34ensh5b0qzXYayMO5ygob8JXzkERaQ/BRO1X2S84tmN27sJsli05?=
 =?us-ascii?Q?5yygq29kC6hSdn+gYxLJuZP0uVW9hyhZtd6BEp/cc58MbfAMY434M8BZ4SyE?=
 =?us-ascii?Q?Dd5+e4FC0OO3q7HPD7Gw0kGSyntir4u7bYnoNyZmsvebwEw9+RFvqGAD1Ex1?=
 =?us-ascii?Q?tWT10w+81V177bkppLB1J5lbPAScQb2R3GREeWVsC7t90Yup6jHhi1sZXYuc?=
 =?us-ascii?Q?gpXAj0xisoRxddVab9lLO47DmBHR91r+X0XFu+MgDolv0kJxFJkAzcUfniFQ?=
 =?us-ascii?Q?gT5/1sBVm1f7sFJewQP5NrzjWO8zOAgFFs1n+9QUcoxb3tVUofyc1znMY6ah?=
 =?us-ascii?Q?exIP1tf0IQjkoi85Bol8EI98lSmlQs6pOzWNU+LozKhO95ZK27DE52cCYk//?=
 =?us-ascii?Q?AgfEmDY/9k42haUPyc26RUJOzK4mUJxxOPJN4LVmnoBvJnQV9ReZbfOKZ6P5?=
 =?us-ascii?Q?I8cGzKhq78Wt/89JJgc1ztEZkjXOw0vh5/6yF513PqXyC2n8GgbqMg+atWM7?=
 =?us-ascii?Q?/gYtBgKDI3jdX9wlf/llIXCveOZKQPjUeMJHq/VgXe1wWV80QCemUN37KtM4?=
 =?us-ascii?Q?sMfi2MuNogXChoxb91OsfIfJ7k8df5tzXTcyLShZjATg5HFHX9XY8kzyj8jr?=
 =?us-ascii?Q?Lu8E5+u/PDM/cV0ztlskrAUi91xRIp9VmNK9c/iQ/H2FJ82OnDUPwntR4hSp?=
 =?us-ascii?Q?Q7j+xPIz/Yoqe0k0LsqFzj+OHKenXPDpUxPtWuo18sr1l8dHRTH0Jax1/CQ2?=
 =?us-ascii?Q?9Va9yvknOIcUmG68uvD4WxnlpowSk4DrwINJe4nLUO146tUnpi5RCf2zN6bu?=
 =?us-ascii?Q?ndkYvWyerbJlq1QhUJ59Nt7g/zZBtujZquv8cyII+3o4Vphwy/0VW/pdYMPf?=
 =?us-ascii?Q?1Vxieb0/ci17QkkhXSLdOpg1pshuNtq88hetr15TnM7jLyp5ZB46ZdcFg+8Q?=
 =?us-ascii?Q?vtCOv2fu3L/STQeBpv3JGIptcK93z3l8amYYTXZFFkRlfCV4Vw7BItXNeMKO?=
 =?us-ascii?Q?+5c6zvzVUpyUldfn0KVbDGSSpkO5vZ3nbdPWEjMycLJoGNdO8a3RI8A8WJuO?=
 =?us-ascii?Q?EHVx4zC3/L4v1WH7o2idqjZDIrdIgVEPQCnCaUX5V0ciirYJjdxFXhjbXXuv?=
 =?us-ascii?Q?JNs0hpNmAYH+afWUs01lvpgmd6TkM8eTfiDCcS4dIXGUeuBqL5sI8kQitUy1?=
 =?us-ascii?Q?6/XpQRZUEXceNSdpu3mIxzqpEa/Bu2UGefuAv6ys?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15ae1c5d-46e9-4176-6c3a-08dc440b34b9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB8252.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 09:43:30.0751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ipiba/PgVDpZ8vC/SYbovogc3Co3qvuE33ZDV7niW2tLpobTwA7QfWBpIHN4W0/+kEt8DC+Nx5dI31JJs4eagA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7162

On Wed, Mar 13, 2024 at 06:04:40PM +0800, Perry Yuan wrote:
> From: Perry Yuan <Perry.Yuan@amd.com>
> 
> When CPU core Precision Boost state changed, the max frequency will also
> need to be updated according to the current boost state, if boost is
> disabled now, the max perf will be limited to nominal perf values.
> otherwise the max frequency will be showed wrongly.
> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>

Looks good to me.

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

> ---
>  drivers/cpufreq/amd-pstate.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index d54399ebb758..0965fbf660dd 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -632,6 +632,10 @@ static int amd_get_max_freq(struct amd_cpudata *cpudata)
>  	nominal_perf = READ_ONCE(cpudata->nominal_perf);
>  	max_perf = READ_ONCE(cpudata->highest_perf);
>  
> +	/* when boost is off, the highest perf will be limited to nominal_perf */
> +	if (!amd_pstate_global_params.cpb_boost)
> +		max_perf = nominal_perf;
> +
>  	boost_ratio = div_u64(max_perf << SCHED_CAPACITY_SHIFT,
>  			      nominal_perf);
>  
> -- 
> 2.34.1
>