Received-SPF: pass (google.com: domain of linux-kernel+bounces-103079-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 14 Mar 2024 05:54:14 -0400
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Abhishek Chauhan <quic_abchauha@quicinc.com>, 
 "David S. Miller" <davem@davemloft.net>, 
 Eric Dumazet <edumazet@google.com>, 
 Jakub Kicinski <kuba@kernel.org>, 
 Paolo Abeni <pabeni@redhat.com>, 
 netdev@vger.kernel.org, 
 linux-kernel@vger.kernel.org, 
 Andrew Halaney <ahalaney@redhat.com>, 
 Willem de Bruijn <willemdebruijn.kernel@gmail.com>, 
 Martin KaFai Lau <martin.lau@kernel.org>, 
 Martin KaFai Lau <martin.lau@linux.dev>, 
 Daniel Borkmann <daniel@iogearbox.net>
Cc: kernel@quicinc.com
Message-ID: <65f2c9468188_3ee617294f9@willemb.c.googlers.com.notmuch>
In-Reply-To: <20240314010813.1418521-1-quic_abchauha@quicinc.com>
References: <20240314010813.1418521-1-quic_abchauha@quicinc.com>
Subject: Re: [PATCH net-next v2] Revert "net: Re-use and set
 mono_delivery_time bit for userspace tstamp packets"
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit

Abhishek Chauhan wrote:
> This reverts commit 30bb896b98fce7d823a96fc02cd69be30384a5cc.

Upstream SHA1 is 885c36e59f46375c138de18ff1692f18eff67b7f ?

> The patch currently broke the bpf selftest test_tc_dtime because
> uapi field __sk_buff->tstamp_type depends on skb->mono_delivery_time which
> does not necessarily mean mono with the original fix as the bit was re-used
> for userspace timestamp as well to avoid tstamp reset in the forwarding 
> path. To solve this we need to keep mono_delivery_time as ease and 

minor typo: as ease -> as is

> introduce another bit called user_delivery_time and fall back to the 
> initial proposal of setting the user_delivery_time bit based on 
> sk_clockid set from userspace.
> 
> Link: https://lore.kernel.org/netdev/bc037db4-58bb-4861-ac31-a361a93841d3@linux.dev/
> Signed-off-by: Abhishek Chauhan <quic_abchauha@quicinc.com>

Reviewed-by: Willem de Bruijn <willemb@google.com>
once the SHA1 is verified/fixed.