Received-SPF: pass (google.com: domain of linux-kernel+bounces-103089-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 14 Mar 2024 15:32:27 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To: Perry Yuan <perry.yuan@amd.com>
Cc: rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com,
	viresh.kumar@linaro.org, Ray.Huang@amd.com, Borislav.Petkov@amd.com,
	Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
	Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/7] cpufreq: amd-pstate: fix the MSR highest perf
 will be reset issue while cpb boost off
Message-ID: <ZfLLM6IUr7vJB6Xt@BLR-5CG11610CF.amd.com>
References: <cover.1710322310.git.perry.yuan@amd.com>
 <faea296aa8eb87374d1980e68d4fc314a48b1453.1710322310.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <faea296aa8eb87374d1980e68d4fc314a48b1453.1710322310.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Ajf9JnUE163yuPSINAzcOQknAtC0HFCQGYrxk5jcs890V/8zY2Y0VE9iSqq/?=
 =?us-ascii?Q?SmV9f0QuwjBijm6flZJpsfSwn19VGPOyq1ib2pq9fBHyhze+v0orgC/hv/2D?=
 =?us-ascii?Q?NA/O5D6bRGfVXir9VZ8RbL1VqsS0qdOfjhgBK6r+OOMbuo0StZ5hHsIgOojv?=
 =?us-ascii?Q?ON8OHQJGLE0FLl4th7MKgOTJNdyONTWM1HosEVfO8hsEZkncVRLAc3crPTFU?=
 =?us-ascii?Q?F959zj0YqJBsF+BAVnyqGV6O6hGTjH/pUuKFNF0Mp+gLZc3vu+ZPzjRzRoCI?=
 =?us-ascii?Q?TTSDYi93AiBRPdmpc/YPxTWUivSqxeya91ysedrCsjHRaBTeOBy5J063qp5F?=
 =?us-ascii?Q?9ECUhaXWbX1ubHGGQv3WAH7z65x54XHjKH71bQSBzYEZ6t9CIXnfffTw1ijN?=
 =?us-ascii?Q?sgGqnj0i5V/Arjo3M3wkPheHeqLOc2c3E3VgO9U2AbHZTuKZWM/YVp8wVrjL?=
 =?us-ascii?Q?3w8R9lyS9JTdjCOlfbxNgb6YCOUcWRbB8kSah5nvd0m246XmX3qHHc8BZVnD?=
 =?us-ascii?Q?XLl3q+QLCkvjpHSzSCElDvUZLeahiwcqvcV2d3YIfaPhB2sKaC3KxUVRt4lX?=
 =?us-ascii?Q?cOdPIEjBVmxsaRyCxEkT3ppJErtWBMxD5FbFkH420x89fy043NKSYNRNwIyQ?=
 =?us-ascii?Q?DSJ9lfeBNuLGhLhxvKC68lKDaEbvFbxQM/BJsW6V6TxPIFJxmXNARZFWiHHR?=
 =?us-ascii?Q?RbWhxXGfaoKmVnpqeM8SHACojI5TFAHLjy7l6v//zKSHjwPaCPhClElGxWqS?=
 =?us-ascii?Q?u1KO8s/1MCv+Ji2ScC3PHQWNIP/oD4gaTdWTKhvXlFjgGu9hpxsL2iaX9A3o?=
 =?us-ascii?Q?eq9yHZh+khQdVUlaS4+4UxD0d57qweWCAhmZOkQ9/pnWZL1AKBK+5wO20p4m?=
 =?us-ascii?Q?hWapVV9sM4P9vi4GvPCerEJk7HUKRaRfWTM6Gw6MSPte5VSdFbjJITzuHOKb?=
 =?us-ascii?Q?YgnEVVJ65tsFL3wEn1XaPpKp+xxvQxtyHDDQclHKchbnsNOoEeIAPSWVih/s?=
 =?us-ascii?Q?y6J1aHTFf7JZuoCr/ZkpoopWqHASYgrWpTx9RqIhpVEvAKm32iz6PRY/HkDY?=
 =?us-ascii?Q?L6/8FufSd9ugQk74OBqIvIUeHOuAO43vgfSiz180knj918qZcsIE168QaqsP?=
 =?us-ascii?Q?J5EyTIHyKj7P6Z+c24bbU/2s6qf90M1fBrGw3M2iNCF0MDbwcfGQ38UgwHWY?=
 =?us-ascii?Q?aA3zll9XPFUXCwn+v/TjQoChUbzfTM9t8JSbN/7qdZTIW+uUV55Wemvxe4Ka?=
 =?us-ascii?Q?DR4tLl2oE7JRwieF9HD8cErthV7YSFPX10n8jnZsF1RihWZNhjD3wwqKpGi4?=
 =?us-ascii?Q?4rBoG2cYEk9/6XaYfr0My0NXJ2/l0HDJ9Bvl9YfepJz3nX60flznexDO3qS0?=
 =?us-ascii?Q?UikNv4mJci2oESHUttqxGl3Sf260IwNLPNbhiFiTR5hCUq7mp8tAYj1JUr51?=
 =?us-ascii?Q?9JloE8lcsj62z5omAjZVEAg8nZA1d4Bsblf1nsnphtWPq3NhCuC467mjw4Mi?=
 =?us-ascii?Q?XlXmHUwJ5BLC53ZEsId4j5TMnVUaF//WvT3dxgCxP3ClcilP6wBG1yOa4h3m?=
 =?us-ascii?Q?Z2qN+cUowKyrk1JWWOFecsohTWSFRh8LhTxVuqb2?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12b7846e-e43d-4e7f-c615-08dc440de04f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB8252.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 10:02:37.2158
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9tI+WV8f5FXIK2FIIfWOU7Oq2ELg1FMjWNHBT9Wd18NfHBYYLVL72ChbuADDr9VL4JeEATAyvgkkumORHdacNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8947

Hello Perry,

On Wed, Mar 13, 2024 at 06:04:41PM +0800, Perry Yuan wrote:
> From: Perry Yuan <Perry.Yuan@amd.com>
> 
> Select the min perf to fix the highest perf value while update pstate
> CPPC request MSR register, here we need to limit the max perf value when
> CPU boost is disabled in case of that highest perf value in the MSR will be
> reset to original highest perf value which cause the BOOST control
> failed.

From the code in this patch, what you are trying to do is limit the
max_perf value to the minimum of the highest_perf and nominal_perf
when boost is disabled. A question : Why not unconditionally set the
max_perf to the nominal_perf ?

--
Thanks and Regards
gautham.

> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 0965fbf660dd..d7afbded6e3d 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -440,6 +440,7 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf,
>  			      u32 des_perf, u32 max_perf, bool fast_switch, int gov_flags)
>  {
>  	u64 prev = READ_ONCE(cpudata->cppc_req_cached);
> +	u32 nominal_perf = READ_ONCE(cpudata->nominal_perf);
>  	u64 value = prev;
>  
>  	min_perf = clamp_t(unsigned long, min_perf, cpudata->min_limit_perf,
> @@ -459,6 +460,10 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf,
>  	value &= ~AMD_CPPC_DES_PERF(~0L);
>  	value |= AMD_CPPC_DES_PERF(des_perf);
>  
> +	/* limit the max perf when core performance boost feature is disabled */
> +	if (!amd_pstate_global_params.cpb_boost)
> +		max_perf = min_t(unsigned long, nominal_perf, max_perf);
> +
>  	value &= ~AMD_CPPC_MAX_PERF(~0L);
>  	value |= AMD_CPPC_MAX_PERF(max_perf);
>  
> -- 
> 2.34.1
>