Received-SPF: pass (google.com: domain of linux-kernel+bounces-103106-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <41889d0b-fe20-4fde-a71c-45d928ede11d@quicinc.com>
Date: Thu, 14 Mar 2024 18:15:06 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: dts: qcom: sm8650: Add three missing
 fastrpc-compute-cb nodes
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>
CC: <quic_ekangupt@quicinc.com>, <kernel@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20240314063334.31942-1-quic_lxu5@quicinc.com>
 <c7ac2b10-eee3-4269-85e4-a68d24c2337a@linaro.org>
 <88c32ccb-fadd-49e8-a8fc-76f93353d204@quicinc.com>
 <46e90e1f-1c93-4e88-b73c-94c165217d98@linaro.org>
From: Ling Xu <quic_lxu5@quicinc.com>
In-Reply-To: <46e90e1f-1c93-4e88-b73c-94c165217d98@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

在 2024/3/14 18:09, Krzysztof Kozlowski 写道:
> On 14/03/2024 11:05, Ling Xu wrote:
>> 在 2024/3/14 14:55, Krzysztof Kozlowski 写道:
>>> On 14/03/2024 07:33, Ling Xu wrote:
>>>> Add three missing cDSP fastrpc compute-cb nodes for the SM8650 SoC.
>>>>
>>>> Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
>>>> ---
>>>>  arch/arm64/boot/dts/qcom/sm8650.dtsi | 29 ++++++++++++++++++++++++++++
>>>>  1 file changed, 29 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
>>>> index ba72d8f38420..c238ad1be0d4 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
>>>> @@ -5084,6 +5084,35 @@
>>>>  							 <&apps_smmu 0x19c8 0x0>;
>>>>  						dma-coherent;
>>>>  					};
>>>> +
>>>> +					/* note: secure cb9 in downstream */
>>>> +
>>>> +					compute-cb@10 {
>>>> +						compatible = "qcom,fastrpc-compute-cb";
>>>> +						reg = <12>;
>>>> +						iommus = <&apps_smmu 0x196C 0x0000>,
>>>> +							 <&apps_smmu 0x0C0C 0x0020>,
>>>> +							 <&apps_smmu 0x19CC 0x0000>;
>>>
>>> Lowercase hex. Please look at the code above, don't copy downstream
>>> code. This applies to all your work: don't send us downstream code, but
>>> clean it up from all of its problems.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> Hi, sorry, do you mean that I should delete this line: /* note: secure cb9 in downstream */?
>> All I sent are upstream codes, I didn't copy cb9 here and I also see this commented line in sm8550.dtsi.
> 
> My comment was about the style. If you send "upstream codes", how could
> you have there uppercase hex? It is even visible in the diff context
> that it should be lowercase!
> 
> Best regards,
> Krzysztof
> 
Sorry for that, I got it. Thanks for your comment.
-- 
Thx and BRs,
Ling Xu