Received-SPF: pass (google.com: domain of linux-kernel+bounces-103111-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Thomas Gleixner <tglx@linutronix.de>
To: Z qiang <qiang.zhang1211@gmail.com>, =?utf-8?B?5p+z6I+B5bOw?=
 <liujingfeng@qianxin.com>
Cc: "richardcochran@gmail.com" <richardcochran@gmail.com>,
 "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "syzkaller@googlegroups.com" <syzkaller@googlegroups.com>,
 "secalert@redhat.com" <secalert@redhat.com>
Subject: Re: memory leak in posix_clock_open
In-Reply-To: <CALm+0cW8HutqzcrfxysLWoOVyzh70RT3G0gaALRbnS=8Lw2f=g@mail.gmail.com>
References: <ef6a91ac20d8441bad9956c15caaafef@qianxin.com>
 <CALm+0cW8HutqzcrfxysLWoOVyzh70RT3G0gaALRbnS=8Lw2f=g@mail.gmail.com>
Date: Thu, 14 Mar 2024 11:20:35 +0100
Message-ID: <87frwtm7ws.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On Mon, Mar 11 2024 at 17:46, Z qiang wrote:
>
> diff --git a/kernel/time/posix-clock.c b/kernel/time/posix-clock.c
> index 9de66bbbb3d1..71d9d8c394fa 100644
> --- a/kernel/time/posix-clock.c
> +++ b/kernel/time/posix-clock.c
> @@ -137,6 +137,8 @@ static int posix_clock_open(struct inode *inode,
> struct file *fp)
>
>         if (!err) {
>                 get_device(clk->dev);
> +       } else {
> +               kfree(pccontext);
>         }
>  out:
>         up_read(&clk->rwsem);

Looks about right. Can you please send a proper patch?