Received-SPF: pass (google.com: domain of linux-kernel+bounces-103139-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 14 Mar 2024 11:40:25 +0100
From: Marek =?UTF-8?B?QmVow7pu?= <kabel@kernel.org>
To: George Stark <gnstark@salutedevices.com>
Cc: <andy.shevchenko@gmail.com>, <pavel@ucw.cz>, <lee@kernel.org>,
 <vadimp@nvidia.com>, <mpe@ellerman.id.au>, <npiggin@gmail.com>,
 <christophe.leroy@csgroup.eu>, <hdegoede@redhat.com>,
 <mazziesaccount@gmail.com>, <peterz@infradead.org>, <mingo@redhat.com>,
 <will@kernel.org>, <longman@redhat.com>, <boqun.feng@gmail.com>,
 <nikitos.tr@gmail.com>, <kabel@kernel.org>, <linux-leds@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
 <kernel@salutedevices.com>
Subject: Re: [PATCH v6 1/9] locking/mutex: introduce devm_mutex_init
Message-ID: <20240314114025.1e27399e@thinkpad>
In-Reply-To: <20240314084531.1935545-2-gnstark@salutedevices.com>
References: <20240314084531.1935545-1-gnstark@salutedevices.com>
	<20240314084531.1935545-2-gnstark@salutedevices.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, 14 Mar 2024 11:45:23 +0300
George Stark <gnstark@salutedevices.com> wrote:

> Using of devm API leads to a certain order of releasing resources.
> So all dependent resources which are not devm-wrapped should be deleted
> with respect to devm-release order. Mutex is one of such objects that
> often is bound to other resources and has no own devm wrapping.
> Since mutex_destroy() actually does nothing in non-debug builds
> frequently calling mutex_destroy() is just ignored which is safe for now
> but wrong formally and can lead to a problem if mutex_destroy() will be
> extended so introduce devm_mutex_init()
>=20
> Signed-off-by: George Stark <gnstark@salutedevices.com>
> Suggested by-by: Christophe Leroy <christophe.leroy@csgroup.eu>

Reviewed-by: Marek Beh=C3=BAn <kabel@kernel.org>