Received-SPF: pass (google.com: domain of linux-kernel+bounces-103143-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Michael Ellerman <mpe@ellerman.id.au>
To: Herve Codina <herve.codina@bootlin.com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
 <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Yury Norov
 <yury.norov@gmail.com>, Andy Shevchenko
 <andriy.shevchenko@linux.intel.com>, Rasmus Villemoes
 <linux@rasmusvillemoes.dk>, linux-kernel@vger.kernel.org,
 netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andrew Lunn
 <andrew@lunn.ch>, Mark Brown <broonie@kernel.org>, Ratheesh Kannoth
 <rkannoth@marvell.com>, Christophe Leroy <christophe.leroy@csgroup.eu>,
 Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v7 1/5] net: wan: Add support for QMC HDLC
In-Reply-To: <20240314081200.5af62fab@bootlin.com>
References: <20240307113909.227375-1-herve.codina@bootlin.com>
 <20240307113909.227375-2-herve.codina@bootlin.com>
 <87ttl93f7i.fsf@mail.lhotse> <20240314081200.5af62fab@bootlin.com>
Date: Thu, 14 Mar 2024 21:51:01 +1100
Message-ID: <87r0gd2iju.fsf@mail.lhotse>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Herve Codina <herve.codina@bootlin.com> writes:
> Hi Michael,
>
> On Thu, 14 Mar 2024 10:05:37 +1100
> Michael Ellerman <mpe@ellerman.id.au> wrote:
>
>> Hi Herve,
>>=20
>> Herve Codina <herve.codina@bootlin.com> writes:
> ..
>> This breaks when building as a module (eg. ppc32_allmodconfig):
>>=20
>>   In file included from ../include/linux/device/driver.h:21,
>>                    from ../include/linux/device.h:32,
>>                    from ../include/linux/dma-mapping.h:8,
>>                    from ../drivers/net/wan/fsl_qmc_hdlc.c:13:
>>   ../drivers/net/wan/fsl_qmc_hdlc.c:405:25: error: =E2=80=98qmc_hdlc_dri=
ver=E2=80=99 undeclared here (not in a function); did you mean =E2=80=98qmc=
_hdlc_probe=E2=80=99?
>>     405 | MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
>>         |                         ^~~~~~~~~~~~~~~
>>=20
>>=20
>> IIUIC it should be pointing to the table, not the driver, so:
>>=20
>> diff --git a/drivers/net/wan/fsl_qmc_hdlc.c b/drivers/net/wan/fsl_qmc_hd=
lc.c
>> index 5fd7ed325f5b..705c3681fb92 100644
>> --- a/drivers/net/wan/fsl_qmc_hdlc.c
>> +++ b/drivers/net/wan/fsl_qmc_hdlc.c
>> @@ -402,7 +402,7 @@ static const struct of_device_id qmc_hdlc_id_table[]=
 =3D {
>>         { .compatible =3D "fsl,qmc-hdlc" },
>>         {} /* sentinel */
>>  };
>> -MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
>> +MODULE_DEVICE_TABLE(of, qmc_hdlc_id_table);
>>=20
>>  static struct platform_driver qmc_hdlc_driver =3D {
>>         .driver =3D {
>>=20
>>=20
>> Which then builds correctly.
>
> My bad, I missed that one.
> I fully agree with your modification.
>
> Do you want me to make a patch (copy/paste of your proposed modification)
> or do you plan to send the patch on your side ?

Yes if you can please turn it into a proper patch and submit it.

No need to add my SoB, it's trivial.

cheers