Received-SPF: pass (google.com: domain of linux-kernel+bounces-103174-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 14 Mar 2024 12:27:14 +0100
From: David Woodhouse <dwmw2@infradead.org>
To: Sudeep Holla <sudeep.holla@arm.com>
CC: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
 Paolo Bonzini <pbonzini@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
 Marc Zyngier <maz@kernel.org>, Oliver Upton <oliver.upton@linux.dev>,
 James Morse <james.morse@arm.com>, Suzuki K Poulose <suzuki.poulose@arm.com>,
 Zenghui Yu <yuzenghui@huawei.com>, Catalin Marinas <catalin.marinas@arm.com>,
 Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
 Lorenzo Pieralisi <lpieralisi@kernel.org>,
 "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <len.brown@intel.com>,
 Pavel Machek <pavel@ucw.cz>, Mostafa Saleh <smostafa@google.com>,
 Jean-Philippe Brucker <jean-philippe@linaro.org>, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev,
 linux-pm@vger.kernel.org
Subject: =?US-ASCII?Q?Re=3A_=5BRFC_PATCH_2/2=5D_arm64=3A_Use_SYSTEM=5FO?= =?US-ASCII?Q?FF2_PSCI_call_to_power_off_for_hibernate?=
User-Agent: K-9 Mail for Android
In-Reply-To: <ZfLa1_TWArT7tCtb@bogus>
References: <20240312135958.727765-1-dwmw2@infradead.org> <20240312135958.727765-3-dwmw2@infradead.org> <ZfB7c9ifUiZR6gy1@bogus> <520ce28050c29cca754493f0595d4a64d45796ee.camel@infradead.org> <ZfHHlBgSNr8Qm22D@bogus> <ZfLa1_TWArT7tCtb@bogus>
Message-ID: <5A0D0B83-F898-4B5B-893F-7953847ED5CD@infradead.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 14 March 2024 12:09:11 CET, Sudeep Holla <sudeep=2Eholla@arm=2Ecom> wrot=
e:
>On Wed, Mar 13, 2024 at 03:34:44PM +0000, Sudeep Holla wrote:
>> On Tue, Mar 12, 2024 at 04:36:05PM +0000, David Woodhouse wrote:
>> > On Tue, 2024-03-12 at 15:57 +0000, Sudeep Holla wrote:
>> > > Looked briefly at register_sys_off_handler and it should be OK to c=
all
>> > > it from psci_init_system_off2() below=2E Any particular reason for =
having
>> > > separate initcall to do this ? We can even eliminate the need for
>> > > psci_init_system_off2 if it can be called from there=2E What am I m=
issing ?
>> >
>> > My first attempt did that=2E I don't think we can kmalloc that early:
>> >
>>
>> That was was initial guess=2E But a quick hack on my setup and running =
it on
>> the FVP model didn't complain=2E I think either I messed up or somethin=
g else
>> wrong, I must check on some h/w=2E Anyways sorry for the noise and than=
ks for
>> the response=2E
>>
>
>OK, it was indeed giving -ENOMEM which in my hack didn't get propogated
>properly =F0=9F=99=81=2E I assume you have some configs that is resulting=
 in the
>crash instead of -ENOMEM as I see in my setup(FVP as well as hardware)=2E
>
>Sorry for the noise=2E

Fairly stock Fedora config, with a few tweaks=2E
http://david=2Ewoodhou=2Ese/arm-hibernate-config

I note kmalloc_trace() is in the backtrace=2E