Received-SPF: pass (google.com: domain of linux-kernel+bounces-103180-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240314112657.167006-1-krzysztof.kozlowski@linaro.org>
In-Reply-To: <20240314112657.167006-1-krzysztof.kozlowski@linaro.org>
From: Sumit Garg <sumit.garg@linaro.org>
Date: Thu, 14 Mar 2024 17:00:12 +0530
Message-ID: <CAFA6WYOV2Mn_1==67Yxacjp9RR2LC7dQUU4Y5Q3b=yo5yhNVyg@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: qcom: apq8016-sbc: correct GPIO LEDs node names
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, 
	Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
	Conor Dooley <conor+dt@kernel.org>, linux-arm-msm@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Thu, 14 Mar 2024 at 16:57, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Individual LEDs in a GPIO LEDs device node are not addressable, thus
> unit address is not correct.
>
> dtc is also not happy:
>
>   Warning (unit_address_vs_reg): /leds/led@5: node has a unit name, but no reg or ranges property
>
> Reported-by: Sumit Garg <sumit.garg@linaro.org>
> Closes: https://lore.kernel.org/all/CAFA6WYNRwF7GqhBk2B7i-deT3aLxNQckhnOasjip2TYm4HZgAw@mail.gmail.com/
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

-Sumit

> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> index 9ffad7d1f2b6..aba08424aa38 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> @@ -91,7 +91,7 @@ leds {
>
>                 compatible = "gpio-leds";
>
> -               led@1 {
> +               led-1 {
>                         label = "apq8016-sbc:green:user1";
>                         function = LED_FUNCTION_HEARTBEAT;
>                         color = <LED_COLOR_ID_GREEN>;
> @@ -100,7 +100,7 @@ led@1 {
>                         default-state = "off";
>                 };
>
> -               led@2 {
> +               led-2 {
>                         label = "apq8016-sbc:green:user2";
>                         function = LED_FUNCTION_DISK_ACTIVITY;
>                         color = <LED_COLOR_ID_GREEN>;
> @@ -109,7 +109,7 @@ led@2 {
>                         default-state = "off";
>                 };
>
> -               led@3 {
> +               led-3 {
>                         label = "apq8016-sbc:green:user3";
>                         function = LED_FUNCTION_DISK_ACTIVITY;
>                         color = <LED_COLOR_ID_GREEN>;
> @@ -118,7 +118,7 @@ led@3 {
>                         default-state = "off";
>                 };
>
> -               led@4 {
> +               led-4 {
>                         label = "apq8016-sbc:green:user4";
>                         color = <LED_COLOR_ID_GREEN>;
>                         gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
> @@ -127,7 +127,7 @@ led@4 {
>                         default-state = "off";
>                 };
>
> -               led@5 {
> +               led-5 {
>                         label = "apq8016-sbc:yellow:wlan";
>                         function = LED_FUNCTION_WLAN;
>                         color = <LED_COLOR_ID_YELLOW>;
> @@ -136,7 +136,7 @@ led@5 {
>                         default-state = "off";
>                 };
>
> -               led@6 {
> +               led-6 {
>                         label = "apq8016-sbc:blue:bt";
>                         function = LED_FUNCTION_BLUETOOTH;
>                         color = <LED_COLOR_ID_BLUE>;
> --
> 2.34.1
>