Received-SPF: pass (google.com: domain of linux-kernel+bounces-103203-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Thu, 14 Mar 2024 13:55:39 +0200 (EET)
To: Ai Chao <aichao@kylinos.cn>
cc: Hans de Goede <hdegoede@redhat.com>, u.kleine-koenig@pengutronix.de, 
    mario.limonciello@amd.com, jes965@nyu.edu, alexbelm48@gmail.com, 
    onenowy@gmail.com, platform-driver-x86@vger.kernel.org, 
    LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] platform/x86: hp-wmi: use sysfs_emit() instead of
 sprintf()
In-Reply-To: <20240314063703.315841-1-aichao@kylinos.cn>
Message-ID: <ae3ade7d-ca88-e2a5-aba5-9574e16e59c0@linux.intel.com>
References: <20240314063703.315841-1-aichao@kylinos.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323328-1489743920-1710417238=:1017"
Content-ID: <54061eef-325c-57e0-9635-5d60be3f0669@linux.intel.com>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1489743920-1710417238=:1017
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <e59bddc6-0a36-8616-72b7-3fb4b7f7870b@linux.intel.com>

On Thu, 14 Mar 2024, Ai Chao wrote:

> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
>=20
> Signed-off-by: Ai Chao <aichao@kylinos.cn>
> ---

Thanks.

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.
--8323328-1489743920-1710417238=:1017--