Received-SPF: pass (google.com: domain of linux-kernel+bounces-103244-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Heiko =?ISO-8859-1?Q?St=FCbner?= <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, arinc.unal@arinc9.com
Cc: mithat.guner@xeront.com, erkin.bozoglu@xeront.com,
 devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
 =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
Subject:
 Re: [PATCH] arm64: dts: rockchip: set PHY address of MT7531 switch to 0x1f
Date: Thu, 14 Mar 2024 13:31:13 +0100
Message-ID: <4682635.taCxCBeP46@diego>
In-Reply-To:
 <20240314-for-rockchip-mt7531-phy-address-v1-1-743b5873358f@arinc9.com>
References:
 <20240314-for-rockchip-mt7531-phy-address-v1-1-743b5873358f@arinc9.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"

Am Donnerstag, 14. M=C3=A4rz 2024, 13:24:35 CET schrieb Ar=C4=B1n=C3=A7 =C3=
=9CNAL via B4 Relay:
> From: Ar=C4=B1n=C3=A7 =C3=9CNAL <arinc.unal@arinc9.com>
>=20
> The MT7531 switch listens on PHY address 0x1f on an MDIO bus. I've got two
> findings that support this. There's no bootstrapping option to change the
> PHY address of the switch. The Linux driver hardcodes 0x1f as the PHY
> address of the switch. So the reg property on the device tree is currently
> ignored by the Linux driver.
>=20
> Therefore, describe the correct PHY address on Banana Pi BPI-R2 Pro that
> has this switch.
>=20
> Signed-off-by: Ar=C4=B1n=C3=A7 =C3=9CNAL <arinc.unal@arinc9.com>

=46ixes: c1804463e5c6 ("arm64: dts: rockchip: Add mt7531 dsa node to BPI-R2=
=2DPro board")

> ---
>  arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts b/arch/ar=
m64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> index 7b5f3904ef61..03d6d920446a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
> @@ -525,9 +525,9 @@ &mdio0 {
>  	#address-cells =3D <1>;
>  	#size-cells =3D <0>;
> =20
> -	switch@0 {
> +	switch@1f {
>  		compatible =3D "mediatek,mt7531";
> -		reg =3D <0>;
> +		reg =3D <0x1f>;
> =20
>  		ports {
>  			#address-cells =3D <1>;
>=20
> ---
> base-commit: 0276d797531ea2d1865a04fbe54c659608f5788f
> change-id: 20240314-for-rockchip-mt7531-phy-address-ba6c2fff485f
>=20
> Best regards,
>=20