Received-SPF: pass (google.com: domain of linux-kernel+bounces-103245-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <403e7704-5d87-43c5-b48d-3faca2a9727a@collabora.com>
Date: Thu, 14 Mar 2024 17:33:13 +0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>, kernel@collabora.com,
 linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com
Subject: Re: [PATCH] selftests/mm: virtual_address_range: Switch to
 ksft_exit_fail_msg
Content-Language: en-US
To: Dev Jain <dev.jain@arm.com>, akpm@linux-foundation.org, shuah@kernel.org
References: <07e2e91b-7b0d-4810-a2a1-ed4654ecafb4@collabora.com>
 <20240314122250.68534-1-dev.jain@arm.com>
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <20240314122250.68534-1-dev.jain@arm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Thanks for the patch. The patch should have been sent to a separate new thread.

On 3/14/24 5:22 PM, Dev Jain wrote:
> mmap() must not succeed in validate_lower_address_hint(), for if it does, it
> is a bug in mmap() itself. Reflect this behaviour with ksft_exit_fail_msg().
> While at it, do some formatting changes.
> 
> Signed-off-by: Dev Jain <dev.jain@arm.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

> ---
>  tools/testing/selftests/mm/virtual_address_range.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/testing/selftests/mm/virtual_address_range.c
> index 7bcf8d48256a..426ddfc345fb 100644
> --- a/tools/testing/selftests/mm/virtual_address_range.c
> +++ b/tools/testing/selftests/mm/virtual_address_range.c
> @@ -85,7 +85,7 @@ static int validate_lower_address_hint(void)
>  	char *ptr;
>  
>  	ptr = mmap((void *) (1UL << 45), MAP_CHUNK_SIZE, PROT_READ |
> -			PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
> +		   PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
>  
>  	if (ptr == MAP_FAILED)
>  		return 0;
> @@ -105,13 +105,11 @@ int main(int argc, char *argv[])
>  
>  	for (i = 0; i < NR_CHUNKS_LOW; i++) {
>  		ptr[i] = mmap(NULL, MAP_CHUNK_SIZE, PROT_READ | PROT_WRITE,
> -					MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
> +			      MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
>  
>  		if (ptr[i] == MAP_FAILED) {
> -			if (validate_lower_address_hint()) {
> -				ksft_test_result_skip("Memory constraint not fulfilled\n");
> -				ksft_finished();
> -			}
> +			if (validate_lower_address_hint())
> +				ksft_exit_fail_msg("mmap unexpectedly succeeded with hint\n");
>  			break;
>  		}
>  
> @@ -127,7 +125,7 @@ int main(int argc, char *argv[])
>  	for (i = 0; i < NR_CHUNKS_HIGH; i++) {
>  		hint = hind_addr();
>  		hptr[i] = mmap(hint, MAP_CHUNK_SIZE, PROT_READ | PROT_WRITE,
> -					MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
> +			       MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
>  
>  		if (hptr[i] == MAP_FAILED)
>  			break;

-- 
BR,
Muhammad Usama Anjum