Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp74905lqb; Thu, 14 Mar 2024 06:02:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU+OevHOgKAwZfR8vW7qlGP5GDGJfypEUdz+31d/Y4OU4VtzQy0PpiVme8lw78w0BJxQWPcuGqolikKi4LnR21fJenyuj52gwjbCFcRuw== X-Google-Smtp-Source: AGHT+IHcTwTeU9TeeWkCMeTEPqKO0MOF7yPA43NTAC5jZ7AHjmc9M/LkCc89Eiqlb9Ut8ZUhr9qz X-Received: by 2002:a17:902:e74e:b0:1dd:c70e:9205 with SMTP id p14-20020a170902e74e00b001ddc70e9205mr2272155plf.52.1710421335439; Thu, 14 Mar 2024 06:02:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710421335; cv=pass; d=google.com; s=arc-20160816; b=AmfE7iKyH5+eBgr5to038zHUYAXaWmNFAuufLmXa1Yj+aLXSorlWEptyNKhFva/z/m +tEiyrp1V2z95oMTS1zVKuLMHIAPPefgxJFpYR9x2wBdWEEssFKw8+Rm9SwVdfXOxrql FvVdevn7gsX3o6N9QZChw1hyp4EClsU4pM+yibidgTAUtekCmFQrkiAbKfiG6fQ1GOco 4rh2Y+JN+1zOLcR22ouVh7SyPj2Nk+TfQ+/6dmeYyJpK5LW1OsPGoZAf2RbH2fCsrmFX MkM8BHWIXPLgxOuDf3in7BLFBrza6WlfThlN0WIG9bVsORtF7WzhyJVqQ753y3lrxsNV HVGg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=EVli0OmFTuK34nwbOdblGGUn4WUi0rrQKbNKDtrDklk=; fh=W5W3nZMJZuuRbuYGYToZL9O2KnK5eImnV8Ve5sx0FjY=; b=F3cT0gv+EPMjEUpUwuxbIa9qE31WxBWjFUTPQvUUxKf//g3IiymqJl2ORat9DETxNh nQ/dKTvz0p9FDCM6+/QyzFZthysf15Rx6oHJNb+EP8MjBTXutZZCrDwTOwMj5LkFirv7 pneDdXmh11E9TZyC3jbguhNLknwMxUNiEJV4mm2GKR7DD/jY7l6TbQdeNUfdLFvp1F3V +EYqgku1iQkHO3IRonMXuDoAbaqcyyureuGEsfLvhJX9Bs5odm3EwmVj9Z45x5vviDjH KFYTcKT7yrFFZsfy+0Lo18trIM+AbqC1aXn7S08VGkfWpBftWLOSAvb5uOarbIxZUdBr Epsw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=T6V+5qj0; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-103265-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103265-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id me7-20020a170902fc4700b001dd707d5ff9si1449065plb.370.2024.03.14.06.02.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 06:02:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-103265-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=T6V+5qj0; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-103265-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103265-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1D43F2838F8 for ; Thu, 14 Mar 2024 13:02:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9BEE85A4C6; Thu, 14 Mar 2024 13:02:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="T6V+5qj0" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48EF855C35; Thu, 14 Mar 2024 13:02:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710421325; cv=none; b=FBPC/6F2igJEbU5v42xD01qfVBGGSd0LW6KuKu1Vu4wREBWAZcyNf8OXEnl63V1zgkCon45uHaq1ow1OUn8pqKWCw5m61+hnz1Anft2Y55xY8I1IWwejHdxGaaHLGCtPo55OLot50ZYyPv9OQoWKY1Mpeg5uT3v6Y9xV4atFjps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710421325; c=relaxed/simple; bh=qAQB9FK88epVTyF/LeZpqM5y5+oOyaphSDCBPPScblw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fE5WO93139YKMV9SC9RcA1OdNbZH6272II5iJPXkN7jab6og4WjINCZxkZ9l8GRR+C+9JXdImW38p6vJkkIOaahKSb1Lr58qyi5LAtPlNSnzWWtEL6PYqodVZQitjrVuGWDk9PP1VF8uKabEzaKn10svztxUfJbp9d5AYuc2ge4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=T6V+5qj0; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=EVli0OmFTuK34nwbOdblGGUn4WUi0rrQKbNKDtrDklk=; b=T6V+5qj0xaMOJrB2glYk53Eafv n2/VR9Pnz79XXEteuAxtf0EDuQkLwDObzh8LzRLOh1FS4OF4dSJgvf7QgNMAnzAlaJnKDE2nvAbAE CWrNAPdZzrStDUQ89uzZ8VNUnVwIJLv2lIv6bHeJGUXpQmvvKhu63CuORqIqeCb3L5UU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rkkiy-00AJtH-8f; Thu, 14 Mar 2024 14:02:20 +0100 Date: Thu, 14 Mar 2024 14:02:20 +0100 From: Andrew Lunn To: Alexandra Diupina Cc: Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sebastian Reichel , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH] net: dsa: add return value check of genphy_read_status() Message-ID: <99631ba3-36f9-4eed-80d9-4a663ef46d80@lunn.ch> References: <20240314063008.11214-1-adiupina@astralinux.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240314063008.11214-1-adiupina@astralinux.ru> On Thu, Mar 14, 2024 at 09:30:08AM +0300, Alexandra Diupina wrote: > Need to check return value of genphy_read_status(), > because higher in the call hierarchy is the > dsa_register_switch() function, > which is used in various drivers. I don't understand the commit message. Why is it important to dsa_register_switch()? Andrew