Received-SPF: pass (google.com: domain of linux-kernel+bounces-103302-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 14 Mar 2024 15:30:37 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Lee Jones <lee@kernel.org>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	linux-i2c@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: `intel_lpss_pci_driver_init` takes 23.8 ms
Message-ID: <ZfL7_Uuh0EQrptNG@smile.fi.intel.com>
References: <ebd4dd9d-3710-4cbb-92d1-c3f73b66bc97@molgen.mpg.de>
 <20240208085928.GB689448@google.com>
 <ZcUQen0nYAAtZVw8@smile.fi.intel.com>
 <49d0a968-7570-43ac-963c-47b9c6dcc353@molgen.mpg.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <49d0a968-7570-43ac-963c-47b9c6dcc353@molgen.mpg.de>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Sun, Feb 11, 2024 at 08:38:15PM +0100, Paul Menzel wrote:
> Am 08.02.24 um 18:33 schrieb Andy Shevchenko:
> > On Thu, Feb 08, 2024 at 08:59:28AM +0000, Lee Jones wrote:
> > > On Tue, 06 Feb 2024, Paul Menzel wrote:

..

> > > > On the Dell XPS 13 9360 and Linux 6.8-rc3+, `intel_lpss_pci_driver_init()`
> > > > takes 23.8 ms, making it one of Linux’ longer init functions on this device:
> > 
> > Does it mean on the previous releases it was different?
> > I mean is it a regression or always was like this?

Okay.

..

> but this seems to have a big affect on ACPI/ASL operations, and execution
> time increases to 125 ms. This breaks down to
> 
> 1.  `i2c_acpi_find_bus_speed()` (96.985 ms @ 3.008753), where
> `acpi_walk_namespace()` takes this time.
> 2.  `i2c_dw_probe_master()` (27.161 ms @ 3.105964) →
> i2c_add_numbered_adapter()` → `i2c_add_adapter()` → `i2c_register_adapter()`
> → `i2c_acpi_register_devices()` → `acpi_ns_walk_namespace()` (24.178 ms @
> 3.108927)
> 
> No idea if this is a red herring, and the long time is actually do to
> something else.

Might be related https://github.com/acpica/acpica/pull/897
Wonder if it helps you anyhow.

-- 
With Best Regards,
Andy Shevchenko