Received-SPF: pass (google.com: domain of linux-kernel+bounces-102937-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <ce00c848-16eb-4276-8f8c-03a97fcb4d86@linux.intel.com>
Date: Thu, 14 Mar 2024 15:45:49 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 028/130] KVM: TDX: Add TDX "architectural" error codes
To: Isaku Yamahata <isaku.yamahata@linux.intel.com>, isaku.yamahata@intel.com
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
 isaku.yamahata@gmail.com, Paolo Bonzini <pbonzini@redhat.com>,
 erdemaktas@google.com, Sean Christopherson <seanjc@google.com>,
 Sagi Shahar <sagis@google.com>, Kai Huang <kai.huang@intel.com>,
 chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com,
 Sean Christopherson <sean.j.christopherson@intel.com>,
 Yuan Yao <yuan.yao@intel.com>, Xiaoyao Li <xiaoyao.li@intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <ae0b961d80ab90e43c6eff4a675e00ff80ab3b9f.1708933498.git.isaku.yamahata@intel.com>
 <20240226192757.GS177224@ls.amr.corp.intel.com>
From: Binbin Wu <binbin.wu@linux.intel.com>
In-Reply-To: <20240226192757.GS177224@ls.amr.corp.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2/27/2024 3:27 AM, Isaku Yamahata wrote:
> On Mon, Feb 26, 2024 at 12:25:30AM -0800,
> isaku.yamahata@intel.com wrote:
>
>> diff --git a/arch/x86/include/asm/shared/tdx.h b/arch/x86/include/asm/shared/tdx.h
>> index fdfd41511b02..28c4a62b7dba 100644
>> --- a/arch/x86/include/asm/shared/tdx.h
>> +++ b/arch/x86/include/asm/shared/tdx.h
>> @@ -26,7 +26,13 @@
>>   #define TDVMCALL_GET_QUOTE		0x10002
>>   #define TDVMCALL_REPORT_FATAL_ERROR	0x10003
>>   
>> -#define TDVMCALL_STATUS_RETRY		1
> Oops, I accidentally removed this constant to break tdx guest build.

Is this the same as "TDVMCALL_RETRY" added in the patch? Since both tdx 
guest code and VMM share the same header file, maybe it needs another 
patch to change the code in guest or you just follow the naming style of 
the exist code?
>
> diff --git a/arch/x86/include/asm/shared/tdx.h b/arch/x86/include/asm/shared/tdx.h
> index ef1c8e5a2944..1367a5941499 100644
> --- a/arch/x86/include/asm/shared/tdx.h
> +++ b/arch/x86/include/asm/shared/tdx.h
> @@ -28,6 +28,8 @@
>   #define TDVMCALL_REPORT_FATAL_ERROR    0x10003
>   #define TDVMCALL_SETUP_EVENT_NOTIFY_INTERRUPT  0x10004
>   
> +#define TDVMCALL_STATUS_RETRY          1
> +
>   /*
>    * TDG.VP.VMCALL Status Codes (returned in R10)
>    */