Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp123853lqb; Thu, 14 Mar 2024 07:09:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXD4ilYcz4iEEc6TNK5cLmNojk7PHyN7s3aWxPMMxEZOS+ADW8a1rsE2cdw5zYakESjtSk5ceHWBTp/AaqtKROprp2Jh661e8EgdZQUzg== X-Google-Smtp-Source: AGHT+IHFJwo0YRHwSZ621b9hNKRVgKpCVP3xbvv60JzZd8UhWi982IJW3Unfp6ewBpre7PVp1H9O X-Received: by 2002:a17:90a:df10:b0:29c:579d:b599 with SMTP id gp16-20020a17090adf1000b0029c579db599mr1870601pjb.9.1710425377707; Thu, 14 Mar 2024 07:09:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710425377; cv=pass; d=google.com; s=arc-20160816; b=txLCcQVuyqr/UyhIP/dSOGOXxSrwAmbPvt7BjHsEB4TWEvELMGHDTFdfVL/vPGqyso D/kiHHt8gksI4cC3tGPTDV9JCippo2lXov7yJHqdtM3To9HBQHqjdYCC90b1uK5kNcgi 1qu1YqLNg/ncxLRIZwXYD8e4JIah9VI54HtuSIJBFijyRvRV1O6Wf3B3xB/ZmfxW0ic+ j9I07IpQEYJPLfdvDjB6WLeUG4RWwyg6dGU8UyU34vWD8VoL7gyBmgK2RimWMpzCEoHH 6dz35Tnzrlq8WZfBkpf3OpXCyXaCUCcAaNCfW1V6vcr8WiCkYnjD248H238oH1FJ+ZsI AtLA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=RXOvXSZ2teuejrNSvg4eVnqLQCp7+IzA+LatJX05CoE=; fh=76fY95VCn/tTPDURHIWBg4FyCkia1KFHdPTfdxMrHno=; b=eallsfyzeBcocVdTdTgKZXWK60PIsrT0DR7s3WPZA3dr9QmFTld1pm1xlgrv3Xng39 PbGefHM5JWPaZg5uL7uuNh3SfWVpfPL9Ycwvi15917snBeGnrVcoJW1AfGx/tmFgQOlL 11obR1PkGSA0E+abZlFuQUYRkX+ta6TM24iso1KcsPWqtRM1U3KQIecrgdZiQN8+86if DKlphcgkmIoUm2KUW0PBdyXLLWGWjqoGVDobzM2UdDw1EjlzpPfeTD3HDEw3zkK817Ol jcgyUoBEgo5Xb4badlLL81UmPkjw+kjidx/q0zr42J0b+PofNDbwbgHcnS98tapoO3WK HtqA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-103347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103347-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id h22-20020a17090aa89600b0029c6a7260ddsi710752pjq.51.2024.03.14.07.09.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 07:09:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-103347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-103347-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103347-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 00AF7B2282A for ; Thu, 14 Mar 2024 14:05:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7DCCB70CDC; Thu, 14 Mar 2024 14:04:54 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BD3D471723; Thu, 14 Mar 2024 14:04:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710425093; cv=none; b=Rcv6MKdcR/magn7mo7dL5szW1vEDRmH0OebzcWYZlKg/NC5OaGsEFptAlxc3UaoK0Z9iZ2s7IHhfPJxpk4vU1goL+4Ho+lLKL1SkxjHsYfJ0glbktFwrEwexmHgYoUXV0O9jZRYc876oq1YysvFiJxsdnKe7YOMddTOg/uhLe0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710425093; c=relaxed/simple; bh=rmY1Ezl/4TLieyFpoPKm5P9cmNGH4Ej3lVmVLgRJ0WQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=o2D8N6S3LfPjnMn7747EJIwfGbY/q7loiwtIaZgjCmsJG4Qpps0h4RY+fmvHoldQ53GFtlhm8PKd91A20AEmPQK9JkcUMyQXhlaOJs72WXAi3/OhSXrImezWFrBw2olcjPZ4v182Rkw7OETqWole/ZMrgPZBGBGVx1GRTGDvePA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 11A5F1007; Thu, 14 Mar 2024 07:05:26 -0700 (PDT) Received: from e129166.arm.com (unknown [10.57.13.158]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2C4B53F762; Thu, 14 Mar 2024 07:04:47 -0700 (PDT) From: Lukasz Luba To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: lukasz.luba@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org, rafael@kernel.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org Subject: [PATCH 3/4] PM: EM: Add em_dev_update_chip_binning() Date: Thu, 14 Mar 2024 14:04:20 +0000 Message-Id: <20240314140421.3563571-4-lukasz.luba@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240314140421.3563571-1-lukasz.luba@arm.com> References: <20240314140421.3563571-1-lukasz.luba@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a function which allows to modify easily the EM after the new voltage information is available. The device drivers for the chip can adjust the voltage values after setup. The voltage for the same frequency in OPP can be different due to chip binning. The voltage impacts the power usage and the EM power values can be updated to reflect that. Signed-off-by: Lukasz Luba --- include/linux/energy_model.h | 5 ++++ kernel/power/energy_model.c | 51 ++++++++++++++++++++++++++++++++++++ 2 files changed, 56 insertions(+) diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h index 770755df852f1..d30d67c2f07cf 100644 --- a/include/linux/energy_model.h +++ b/include/linux/energy_model.h @@ -172,6 +172,7 @@ struct em_perf_table __rcu *em_table_alloc(struct em_perf_domain *pd); void em_table_free(struct em_perf_table __rcu *table); int em_dev_compute_costs(struct device *dev, struct em_perf_state *table, int nr_states); +int em_dev_update_chip_binning(struct device *dev); /** * em_pd_get_efficient_state() - Get an efficient performance state from the EM @@ -387,6 +388,10 @@ int em_dev_compute_costs(struct device *dev, struct em_perf_state *table, { return -EINVAL; } +static inline int em_dev_update_chip_binning(struct device *dev) +{ + return -EINVAL; +} #endif #endif diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c index 6960dd7393b2d..1494a909844a4 100644 --- a/kernel/power/energy_model.c +++ b/kernel/power/energy_model.c @@ -808,3 +808,54 @@ static void em_update_workfn(struct work_struct *work) { em_check_capacity_update(); } + +/** + * em_dev_update_chip_binning() - Update Energy Model with new values after + * the new voltage information is present in the OPPs. + * @dev : Device for which the Energy Model has to be updated. + * + * This function allows to update easily the EM with new values available in + * the OPP framework and DT. It can be used after the chip has been properly + * verified by device drivers and the voltages adjusted for the 'chip binning'. + * It uses the "dynamic-power-coefficient" DT property to calculate the power + * values for EM. For power calculation it uses the new adjusted voltage + * values known for OPPs, which might be changed after boot. + */ +int em_dev_update_chip_binning(struct device *dev) +{ + struct em_perf_table __rcu *em_table; + struct em_perf_domain *pd; + int i, ret; + + if (IS_ERR_OR_NULL(dev)) + return -EINVAL; + + pd = em_pd_get(dev); + if (!pd) { + dev_warn(dev, "Couldn't find Energy Model %d\n", ret); + return -EINVAL; + } + + em_table = em_table_dup(pd); + if (!em_table) { + dev_warn(dev, "EM: allocation failed\n"); + return -ENOMEM; + } + + /* Update power values which might change due to new voltage in OPPs */ + for (i = 0; i < pd->nr_perf_states; i++) { + unsigned long freq = em_table->state[i].frequency; + unsigned long power; + + ret = dev_pm_opp_calc_power(dev, &power, &freq); + if (ret) { + em_table_free(em_table); + return ret; + } + + em_table->state[i].power = power; + } + + return em_recalc_and_update(dev, pd, em_table); +} +EXPORT_SYMBOL_GPL(em_dev_update_chip_binning); -- 2.25.1