Received-SPF: pass (google.com: domain of linux-kernel+bounces-103441-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 14 Mar 2024 07:57:48 -0700
From: Alison Schofield <alison.schofield@intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Ayush Tiwari <ayushtiw0110@gmail.com>, Larry.Finger@lwfinger.net,
	florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
	outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: add comment for mutex
Message-ID: <ZfMQbIzZ6lKhxhkM@aschofie-mobl2>
References: <ZfHuokO3pQXMOxcC@ayush-HP-Pavilion-Gaming-Laptop-15-ec0xxx>
 <ZfJhtBrsL3elRve8@aschofie-mobl2>
 <41239f06-596e-4c17-95ed-4bf06ba9f9ec@moroto.mountain>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <41239f06-596e-4c17-95ed-4bf06ba9f9ec@moroto.mountain>

On Thu, Mar 14, 2024 at 10:37:29AM +0300, Dan Carpenter wrote:
> On Wed, Mar 13, 2024 at 07:32:20PM -0700, Alison Schofield wrote:
> > On Wed, Mar 13, 2024 at 11:51:22PM +0530, Ayush Tiwari wrote:
> > > This patch adds descriptive comment to mutex within the struct
> > > gbaudio_codec_info to clarify its intended use and to address
> > > checkpatch checks.
> > 
> > Hi Ayush-
> > 
> > You may be right, but you need to convince your patch reviewers
> > why your comment accurately describes this mutex.
> > 
> > That's always the ask with this kind of patch.
> 
> Heh.  Yeah.  The comment wasn't right in this case.  The lock has
> nothing to do with registers or register access.
> 
> > 
> > BTW - Don't start your commit log with 'This patch...'.
> > 
> 
> Outreachy folk are a more particular about some of this stuff than I am.
> Which is fine.  Could you do me a favor though?  Could you ack patches
> once you're happy with them?

Dan -
Sure. In practice, the patches are often 'Reviewed-by' someone else
by the time I get back around to it (thanks to the different time
zones and plentiful reviewers) But I understand, I'll make it a 
habit of at Ack'ing after I've asked for something to change.
Alison


> 
> regards,
> dan carpenter
>