Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp176046lqb; Thu, 14 Mar 2024 08:20:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVnuF0GDCA+rW5Nf2fEuFC1eBwVUVWzUomoKJuMkrL5ue8T95za6vGnQUWeoRxGG5p1hpxLTXZ8HmjHrL4UKt1AzMJujzYOM6cV719FTQ== X-Google-Smtp-Source: AGHT+IGnq/eLzj0Ll2xJ42u7Ooskm/u2wxukSD+Eu3bAJJXS9A7cyBSSXKVzn6xPCWVlSCWL2odZ X-Received: by 2002:a05:6214:18c4:b0:691:2b87:2814 with SMTP id cy4-20020a05621418c400b006912b872814mr1019894qvb.41.1710429639368; Thu, 14 Mar 2024 08:20:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710429639; cv=pass; d=google.com; s=arc-20160816; b=cKsHdFNkFRVkysS/4WwV+GvX3TegIEPmLvL4TF5FOBNkuHh2Sb1ncF94U/6AqV76nr 7tVpLC0E8IEIt2eMP2JSWHJpAN41tNl1TQuLJ+NIkIhWZBkN9WXGz1KwtwycR/tGBZ7B Fs0qSY1BWVBBDkWhJssALQmjll+xmQ3bT3sFBveyoWgREE0rdX5mnPTWH1k6EDqWbTOZ aRRvBzEipQUkjjBoE4djRO6CixS2EdtgxUorpBGQ8p0YqT3khz6LIly+VzcmnVd+QcEh j9zPwDDvtlLJsGBVy40CL90CJtmyTH2gTFoP9MMVOR0e/D7wvXdn6lRqceYd1X+sU19J tnDQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=CZ1wm2I23Ier3QzpBzTunPIb/7M7WJu360iqVjd6IVA=; fh=c/2JXkKJfBXWtauh0WSEqmc0A2wCdTkG7tCe8SJwVSA=; b=Ilz8XVuFgdb1eyKzO8pJ5DHdH68DY3G/ip8/dta5huGnyQ9xHG7MnDRWcY1cG39fI2 d+0eRWPlKfjpxC5/cU6+s/B/PrrhF2kdpd3lAXF0uDB86w7wfqDWk7anvTWyDhZqp11d EcoT6RBi58q5cLW66Uy3AenREY1pLqAWDqXVFjY2dVNEfpbIjOj9WFEmzL1VS+TgU61H fhaUEUp6v0YPrq2qUNWjsJEbioxFzfNkLkCBMGpHlUwMBXp0c6gGIam52IOZGdFZA8n7 KPOs+4/hI0b1IAx36b+syYyDwSrdsBbKYG5HZndTg5uJtMm/CL3mIK6LhNW59IONiwqk K0kQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-103471-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103471-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id iw7-20020a0562140f2700b006907928dc20si867130qvb.550.2024.03.14.08.20.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 08:20:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-103471-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-103471-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103471-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 18E301C2267A for ; Thu, 14 Mar 2024 15:20:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BE4CF71B31; Thu, 14 Mar 2024 15:20:32 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BA17C7175A; Thu, 14 Mar 2024 15:20:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710429632; cv=none; b=bLugoA9rpjJPHNpUvoaDV3nfO8IhLYhuM5QD2Aff86Rj2SPy43K8a20jUKFBVvMRMlJWGRjeeQA7Wl6RYQ+eRtFUxZMUrGGYClx3WU/5hyNssqJoKMbeHl6NnkMme1QFGYDM5ifEDGOL/h3OrD3hv8M0TQc604tz8wNA5R2khBs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710429632; c=relaxed/simple; bh=dcb/gsF85aoiYODQ+GAmVe2LLHQNrA+u7u1lvW9BxAw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TnGdypv3L/TmI/c/oPGNzxdCWw6gFvmviFUhMbXSEQsO+HNlyD/FV2Ol1Y5sstbHoPDJvrJmYLvsbnVnGCdIdTpl93F2VUK5LiYeAKwOSGnT/J1duwhQ6BhDQAq3ZkA55xgyvJlCJ9HXHZwCSmzEQA9QYxHIQzpCXJp5To34GdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 43CEF1007; Thu, 14 Mar 2024 08:21:06 -0700 (PDT) Received: from e130802.arm.com (e130802.arm.com [10.1.33.51]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AE0AE3F762; Thu, 14 Mar 2024 08:20:26 -0700 (PDT) Date: Thu, 14 Mar 2024 15:20:18 +0000 From: Abdellatif El Khlifi To: Krzysztof Kozlowski Cc: Robin Murphy , Bjorn Andersson , Mathieu Poirier , Rob Herring , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Krzysztof Kozlowski , Conor Dooley , Drew.Reed@arm.com, Adam.Johnston@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org Subject: Re: [PATCH 3/3] dt-bindings: remoteproc: Add Arm remoteproc Message-ID: <20240314152018.GA41711@e130802.arm.com> References: <20240301164227.339208-1-abdellatif.elkhlifi@arm.com> <20240301164227.339208-4-abdellatif.elkhlifi@arm.com> <8c784016-9257-4d8a-b956-a0a406746c76@arm.com> <20240314134928.GA27077@e130802.arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Krzysztof, On Thu, Mar 14, 2024 at 02:56:53PM +0100, Krzysztof Kozlowski wrote: > On 14/03/2024 14:49, Abdellatif El Khlifi wrote: > >> Frankly at the moment I'd be inclined to say it isn't even a remoteproc > >> binding (or driver) at all, it's a reset controller. Bindings are a contract > >> for describing the hardware, not the current state of Linux driver support - > >> if this thing still needs mailboxes, shared memory, a reset vector register, > >> or whatever else to actually be useful, those should be in the binding from > >> day 1 so that a) people can write and deploy correct DTs now, such that > >> functionality becomes available on their systems as soon as driver support > >> catches up, and b) the community has any hope of being able to review > >> whether the binding is appropriately designed and specified for the purpose > >> it intends to serve. > > > > This is an initial patchset for allowing to turn on and off the remote processor. > > The FW is already loaded before the Corstone-1000 SoC is powered on and this > > is done through the FPGA board bootloader in case of the FPGA target. > > Or by the Corstone-1000 FVP model (emulator). > > > > The plan for the driver is as follows: > > > > Step 1: provide a foundation driver capable of turning the core on/off > > Step 2: provide mailbox support for comms > > Step 3: provide FW reload capability > > > > Steps 2 & 3 are waiting for a HW update so the Cortex-A35 (running Linux) can > > share memory with the remote core. > > > > So, when memory sharing becomes available in the FPGA and FVP the > > DT binding will be upgraded with: > > > > - mboxes property specifying the RX/TX mailboxes (based on MHU v2) > > - memory-region property describing the virtio vrings > > > > Currently the mailbox controller does exist in the HW but is not > > usable via virtio (no memory sharing available). > > > > Do you recommend I add the mboxes property even currently we can't do the comms ? > > Bindings should be complete, regardless whether Linux driver supports it > or not. Please see writing bindings document for explanation on this and > other rules. > > So yes: please describe as much as possible/reasonable. I'll do thanks. Cheers, Abdellatif