Received-SPF: pass (google.com: domain of linux-kernel+bounces-103526-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 14 Mar 2024 15:48:24 +0000
From: Jonathan Cameron <jic23@kernel.org>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: linux-iio@vger.kernel.org, Conall O'Griofa <conall.ogriofa@amd.com>,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH] iio: xilinx-ams: Don't include ams_ctrl_channels in
 scan_mask
Message-ID: <20240314154824.37150a54@jic23-huawei>
In-Reply-To: <20240311162800.11074-1-sean.anderson@linux.dev>
References: <20240311162800.11074-1-sean.anderson@linux.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 11 Mar 2024 12:28:00 -0400
Sean Anderson <sean.anderson@linux.dev> wrote:

> ams_enable_channel_sequence constructs a "scan_mask" for all the PS and
> PL channels. This works out fine, since scan_index for these channels is
> less than 64. However, it also includes the ams_ctrl_channels, where
> scan_index is greater than 64, triggering undefined behavior. Since we
> don't need these channels anyway, just exclude them.
> 
> Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>

Hi Sean,

I'd ideally like to understand why we have channels with such large
scan indexes.  Those values should only be used for buffered capture.
It feels like they are being abused here.  Can we set them to -1 instead
and check based on that?
For a channel, a scan index of -1 means it can't be captured via the buffered
interfaces but only accessed via sysfs reads.
I think that's what we have here?

I just feel like if we leave these as things stand, we will get bitten
by similar bugs in the future.  At least with -1 it should be obvious why!

Jonathan


> ---
> 
>  drivers/iio/adc/xilinx-ams.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
> index a55396c1f8b2..4de7ce598e4d 100644
> --- a/drivers/iio/adc/xilinx-ams.c
> +++ b/drivers/iio/adc/xilinx-ams.c
> @@ -414,8 +414,12 @@ static void ams_enable_channel_sequence(struct iio_dev *indio_dev)
>  
>  	/* Run calibration of PS & PL as part of the sequence */
>  	scan_mask = BIT(0) | BIT(AMS_PS_SEQ_MAX);
> -	for (i = 0; i < indio_dev->num_channels; i++)
> -		scan_mask |= BIT_ULL(indio_dev->channels[i].scan_index);
> +	for (i = 0; i < indio_dev->num_channels; i++) {
> +		const struct iio_chan_spec *chan = &indio_dev->channels[i];
> +
> +		if (chan->scan_index < AMS_CTRL_SEQ_BASE)
> +			scan_mask |= BIT_ULL(chan->scan_index);
> +	}
>  
>  	if (ams->ps_base) {
>  		/* put sysmon in a soft reset to change the sequence */