Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp198586lqb; Thu, 14 Mar 2024 08:55:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXZGVjfsEZpFJQFE4drpdphCxPuQU5E0WiyOkGlCA3ka6DC96REikALGG+TSvUbOtzvP0p0Tie8oDFKHqeYIBj4mmIT0AK94Uo9f03OMQ== X-Google-Smtp-Source: AGHT+IHviCBi4PC5uqxhM8GUkXiuGHVA5uO1aJLBscVcv7+630lhHSHItAP5aRippKdRHUUBEvvj X-Received: by 2002:a05:6402:360e:b0:568:a655:49c6 with SMTP id el14-20020a056402360e00b00568a65549c6mr751427edb.8.1710431741242; Thu, 14 Mar 2024 08:55:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710431741; cv=pass; d=google.com; s=arc-20160816; b=0FWUwzQa3/bkzVSHjpL9eJ8Q+Ij7Eympj0wFmb0MNXZ4fZMA8wwhE5R/me6ucQz9J7 nbqH+N3fEVKNeJGV3snixcS1DpHmKcn9JlfY+85+piJutiM2KeRuhXBG/BUzhE+uaEWz U4jYKvdqe4413kSIlNi01hAfz+mOw2xVkZExdQzrFvccEPp6fINRJnxhIIeXv8zzH/pk 6C4acs/O3rDEnD6SzyRg5xzx3WA/U2sZ/yN8ElMk66jgJWNMMeA+DeLsKLaVJpesGpj0 tjnQM2p4IE3Iv75wRO3i8NfrbBKB5N2J5NN188Ecxai6iBcDIvhUiYcTmgNav6D4ygPk KEow== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-filter; bh=Y8/0hqrVxFQTEZ0jmU+lA12CNpebBoKMmCpYIktEhvc=; fh=LRzTKek6quXfzBZO8TcftpcJKZZb5RcNWwGbgb3ii/g=; b=ASKJSNS6iE1iJzIaUXhz6uEB8TZewEtRHreVOXxMGBdMjbIQoFt0tUuFQpmCVGZcsk EETke1mDeW048X8suJdqBEDE6Xb3+RSJ/ffpRC+XrRtjrcE3IBNRqS2JB8O5L7Zp2Ag6 70ZEuRTxTya370iu0KaK9fYyZnb/tZKRH3Kv08BfFIZo0DCVx9dQYCLaurkN8ikilWWP tibTpbHV6IYa6kEc0HyKg7gXIXG5B2vguZ7twBT85CfdPBbQ+3BMUPHxAd7Rbg1eeD5e zuqNr+cpRff6SFBQvvs2oVXrNcSvdwD3haZ0Ho/6tjyJgzZM63GwY23GBF5oq/3bgwwS q0ag==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=tB6Zfcby; arc=pass (i=1 spf=pass spfdomain=ispras.ru dkim=pass dkdomain=ispras.ru dmarc=pass fromdomain=ispras.ru); spf=pass (google.com: domain of linux-kernel+bounces-103532-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103532-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id ew14-20020a056402538e00b005683aa52282si910834edb.113.2024.03.14.08.55.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 08:55:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-103532-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=tB6Zfcby; arc=pass (i=1 spf=pass spfdomain=ispras.ru dkim=pass dkdomain=ispras.ru dmarc=pass fromdomain=ispras.ru); spf=pass (google.com: domain of linux-kernel+bounces-103532-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103532-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id EB3A91F23982 for ; Thu, 14 Mar 2024 15:55:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CECC37318B; Thu, 14 Mar 2024 15:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="tB6Zfcby" Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4517971B51; Thu, 14 Mar 2024 15:55:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710431720; cv=none; b=J56XYMa0aQE2QONp7cSas5JtVnMVLl6K99+ApAeq/03yK5gB7HeIc+T+yBDGw6udxOuyGb9lBYuTeYV8vbJ/w/RG3pEDiwimu/MO/BelykbErr6a3IgvRCv2od2SVjXh12jqrArWnjpjmI0b0LMIJzBzegtXG+/A4VilZ3C2BeU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710431720; c=relaxed/simple; bh=MFV31aSnWDbF3dhvEx83NnYWqwWHNAiaFqx73jZqldY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HhBFhwaS5Vf7wJvMACaasCwhXQkXtEkYpiE6xj+Rmt36px/GDJ7bGvGZD8Lg8xvyv49zHLBwIljH/wzTZm7OevTZ3y2c6NMDIVdcLjsSdpFSxakiWZZcnd4hdrhRG+lU0C01OlpZp/Gn/2zgXPPaKgl+Tvn8bnlOXf1yXlVtZ+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=tB6Zfcby; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Received: from localhost (unknown [46.242.8.170]) by mail.ispras.ru (Postfix) with ESMTPSA id 3FA3F40769D7; Thu, 14 Mar 2024 15:55:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 3FA3F40769D7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1710431708; bh=Y8/0hqrVxFQTEZ0jmU+lA12CNpebBoKMmCpYIktEhvc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tB6ZfcbyRL+Ck+4f5rYjjXdBNU5RA3AgUHOlbTWh06BMz6NubFGXSbXf9CpVAyQbi ueFfSiawWqFsBd2HphfGLsouVJMgv9E0vNzAdwYqLTyRcj2c2Bn9ZX2yliV+Kfvnn+ /WVXEZTA7+vrpKx0+BIWyxHE9CMvPJhIZe8mvjIo= Date: Thu, 14 Mar 2024 18:55:08 +0300 From: Fedor Pchelkin To: Jens Axboe Cc: Pavel Begunkov , Greg Kroah-Hartman , stable@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org, Nikita Zhandarovich , Roman Belyaev Subject: Re: [PATCH 5.10/5.15] io_uring: fix registered files leak Message-ID: References: <20240312142313.3436-1-pchelkin@ispras.ru> <8a9993c7-fd4d-44ff-8971-af59c7f3052c@kernel.dk> <466e842f-66c6-4530-8c16-2b008fc3fbc6-pchelkin@ispras.ru> <085beb85-d1a4-4cb0-969b-e0f895a95738@kernel.dk> <3f17f1d9-9029-4d03-9b0a-9c500cce54e9@kernel.dk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f17f1d9-9029-4d03-9b0a-9c500cce54e9@kernel.dk> On 24/03/13 06:40PM, Jens Axboe wrote: > Hi, > > OK, here they are. Two patches attached for every stable kernel, that > gets rid of the remnants of the SCM related code: > > 5.4 > 5.10 and 5.15 (same patches) > 6.1 > 6.6 > 6.7 > > Would appreciate if Fedor and Pavel could give them a once over, but I > think they are all fine. It's just deleting the code... Thank you, Jens! FWIW, I think it's all good and it eliminates the reported problem obviously. Compiled and tested the repro with my kernel config. Just a minor notice - stable rules declare two common ways for upstream patch mentioning in backports [1]. And the first one starts from lowercase. No big deal here definitely but maybe somebody has some handling of these two variants - by regexps or similar, I actually don't know. But I see in the git history that Greg also applies the variant you've used. [1]: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-3 -- Fedor