Received-SPF: pass (google.com: domain of linux-kernel+bounces-103533-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240314142656.17699-1-anton@tuxera.com> <70261e2a-b87e-462e-964e-95a51ecde978@intel.com>
In-Reply-To: <70261e2a-b87e-462e-964e-95a51ecde978@intel.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Thu, 14 Mar 2024 16:55:31 +0100
Message-ID: <CAJZ5v0hdA2PUc8cmJtCNxW-nzHdWV+pxnTEeVu_7YHsHZTmFLw@mail.gmail.com>
Subject: Re: [PATCH] x86/pm: Fix false positive kmemleak report in msr_build_context().
To: Dave Hansen <dave.hansen@intel.com>
Cc: Anton Altaparmakov <anton@tuxera.com>, "Rafael J . Wysocki" <rafael@kernel.org>, Pavel Machek <pavel@ucw.cz>, 
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, 
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org, 
	"H . Peter Anvin" <hpa@zytor.com>, Chen Yu <yu.c.chen@intel.com>, 
	Pawan Gupta <pawan.kumar.gupta@linux.intel.com>, 
	Catalin Marinas <catalin.marinas@arm.com>, linux-mm@kvack.org, 
	Matthieu Baerts <matthieu.baerts@tessares.net>, 
	Mat Martineau <mathew.j.martineau@linux.intel.com>, 
	"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>, Ingo Molnar <mingo@kernel.org>, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 14, 2024 at 4:05=E2=80=AFPM Dave Hansen <dave.hansen@intel.com>=
 wrote:
>
> On 3/14/24 07:26, Anton Altaparmakov wrote:
> >  /* image of the saved processor state */
> >  struct saved_context {
> > -     /*
> > -      * On x86_32, all segment registers except gs are saved at kernel
> > -      * entry in pt_regs.
> > -      */
> > -     u16 gs;
> >       unsigned long cr0, cr2, cr3, cr4;
> >       u64 misc_enable;
> >       struct saved_msrs saved_msrs;
> > @@ -27,6 +22,11 @@ struct saved_context {
> >       unsigned long tr;
> >       unsigned long safety;
> >       unsigned long return_address;
> > +     /*
> > +      * On x86_32, all segment registers except gs are saved at kernel
> > +      * entry in pt_regs.
> > +      */
> > +     u16 gs;
> >       bool misc_enable_saved;
> >  } __attribute__((packed));
>
> Isn't this just kinda poking at the symptoms?  This seems to be
> basically the exact same bug as b0b592cf08, just with a different source
> of unaligned structure members.
>
> There's nothing to keep folks from reintroducing these kinds of issues
> and evidently no way to detect when they happen without lengthy reproduce=
rs.

This change is fine with me FWIW, but I agree that making it for
kmemleak reasons feels kind of misguided.