Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp201884lqb; Thu, 14 Mar 2024 09:00:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWZm7ZxGnIQ+11ycKDIuGG4Qvy7qkvtrWDkcv0OGNfabJqu8/D0DwBmrTb6Bv4ImBUUQi+CYwLXWHoW1hs+1/Wo6A5MCs4lWMO8/t2uoA== X-Google-Smtp-Source: AGHT+IFXlqROQdTtJz2TRLjB2uWRhIiavaCyzEZuykGJ2rJZwH7+PRF007s6Adufnz8rojPCWwWj X-Received: by 2002:a05:6512:1c7:b0:513:ca0b:6c3e with SMTP id f7-20020a05651201c700b00513ca0b6c3emr444864lfp.30.1710432048456; Thu, 14 Mar 2024 09:00:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710432048; cv=pass; d=google.com; s=arc-20160816; b=WeWuzdqETBqK0vhkw9pHtxJvV4xPc/b6bA5kB0pXWt92GSMe3BTSusl7NxLhxPjD6q WqKVz53+c2nVhzkBK0HBsT4ZWEW6ZdmPqfcgkTVE1ifvd+u1QqOUHxaOYxCYn6nPDY2H vGBYtwfNObNG8OgIu0CdPn/HyGYcGJEpd46ZC58z1qA7GQW4g/pIYWj6guqo1pqqtQNG SFjzrckgSiyyRbm9RFekelxi6iqr2bXw+sUCZN4M2gaoc6ib6kUx84j0CIkVsj7pjyKl VeiP2LPtcx8AA07P4KFGEcRldgmnWAaIXBlSpx8o5knpauCqsCkbz2KgeaS7pCQUrJ9o etZQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=7QjiuBQBRyT+9k4iTSOFxeijm4WCgkFheISPv0kW21k=; fh=I/t3ahxwvkgg935XQWGr2J/+3xSbwu938+qeaDYXAes=; b=fi0ostbH9LJnRXf1hI6kE7Ic6MFUDo1BStnPmEZJOjFyk7D48ZQCbQdCYc8DU99vMl qk3nkuHK3LcA75atHIQ7czS++bhVwHQ++jfO2NX73prZ2ucXRp5+GCr5Z+LeNY2KhPY8 j0Tkyi+T4EDPc6PhZ8O74GKYLdMbuqmkOfCHAnBI1v2WPExWGMy484nibkiZM2ACSWdZ b05eFcH0sO7s3DqI4DrORIAxpa1pn/i3W/oJYtFXndv31M6xWbOFTj1Evpr0Gu/G//hH Hcbw7IhTjdBY5G+Zy/dtVrskmxerDJ/NhtLcJqxC0R+A1W+2pIAFAEThyvcuWnjwFCfn mTIw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=a+NbZ9mQ; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-103540-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103540-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id ck21-20020a170906c45500b00a46620efc8fsi820302ejb.275.2024.03.14.09.00.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 09:00:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-103540-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=a+NbZ9mQ; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-103540-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103540-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2F0BF1F22507 for ; Thu, 14 Mar 2024 16:00:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 58E6C73180; Thu, 14 Mar 2024 16:00:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="a+NbZ9mQ" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFC2673181 for ; Thu, 14 Mar 2024 16:00:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710432032; cv=none; b=qSLB5Azk0fJ+3VuFoRXA7/xX0EnTbklbfqjp0RDFk6xPW7TJRUsuyLtXw6oXtd2jcd0+XGNQnzh2aCq8PlzRzSsGyLgK/R8/fIIRkRMW5AwYJvKDqKK+goeh4HqFDtmKJ94kNpdWwhJciCDvO5nlc/Iwbpql9JcFU/DD4N1JdbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710432032; c=relaxed/simple; bh=7QjiuBQBRyT+9k4iTSOFxeijm4WCgkFheISPv0kW21k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=UEDfYggGD2A4kAc2DEjvmx/R5qUhpwmjP+fjfG6pX91wZMg+IvKyxJTfpUi19j4TybPPpC6RKnfE5Ds/zmf9a+umbJin1ht86bLYcJ3P9k/twusfwpCy2fFjmLqbD20emdTsMXmBxFeZpMdRJo0CZUXtb7B583LziuU6RSdNI5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=a+NbZ9mQ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710432029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7QjiuBQBRyT+9k4iTSOFxeijm4WCgkFheISPv0kW21k=; b=a+NbZ9mQVyrL+wm/YiPDjqALwRDIXpyXbJxPE7ubpajZv0KpjQI/1Kd8Kbf7aATjF8w8Ye JgbaNK4lsJ6Iogviva99mw8gLf1+qYR21jnW56CAxNIOJaLM0TXX4MRMw+b9CbjxGArWqd n/xY9FWOE6Eh/GdQpO/6uNhnUQprlPY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-164-yWhzMBIeN826XPS1AxCOQA-1; Thu, 14 Mar 2024 12:00:25 -0400 X-MC-Unique: yWhzMBIeN826XPS1AxCOQA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40e40126031so5844415e9.0 for ; Thu, 14 Mar 2024 09:00:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710432024; x=1711036824; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7QjiuBQBRyT+9k4iTSOFxeijm4WCgkFheISPv0kW21k=; b=QKdjBJBU9C0MnS1pbdh+s2sCycviypsniq9DcRcazQMilBo7gwHdIcf51cnfUP/Yin CnXqiUBV9+B9NhfeSk7XpBxOmLeJxZDfpGvmYb4bbaFB33oWu0c7mzzgFVOXBaQAA+6M zgW99Ied1wEQt6dCSD9kQvCtkeWjVU54PUKatcJafa5jcRpGfhpIQhxLPm8toFIJHgGE pj6NyMunDBwpFrKzUE0pdOibORwNfjnGaXEsEIt/KegDSljfFKk9J6RqwvpRuOEiuFj4 WghNHap9MIEAqE+48Msd6IHE0AXfeCiWGCo0RsvNYGaH276jm3T6Z/7nCaZZnDz+SPII 0Sow== X-Forwarded-Encrypted: i=1; AJvYcCXsNwk2TXqefgpndlDNCCtpyZDw6WpMsyBGcd3H45lgbNFt/Wue8QtadKAfzNsx2MWMQC/NxHvcZ+4Iu/eyllkdAYNNbYSRLirrfox6 X-Gm-Message-State: AOJu0YwTyRbeo96RnRGC++VBTs83Jz6wlW+2VUGJFJ86Bl4yjw3rtcI6 a/K/idN/B5kriwMpnj4se39ZBfjiLry00VkIyEfcREScz5MGM18+vQzzcW4WR6q8PNfCw8exL2z JgC0ovTyyARuBaLxb8teQ0OR64o64XXVQgRKyev4y+7W0ocI6i2UaHs8HWiyiAQ== X-Received: by 2002:a05:600c:450f:b0:413:286c:4fc0 with SMTP id t15-20020a05600c450f00b00413286c4fc0mr315570wmo.34.1710432024057; Thu, 14 Mar 2024 09:00:24 -0700 (PDT) X-Received: by 2002:a05:600c:450f:b0:413:286c:4fc0 with SMTP id t15-20020a05600c450f00b00413286c4fc0mr315551wmo.34.1710432023735; Thu, 14 Mar 2024 09:00:23 -0700 (PDT) Received: from vschneid-thinkpadt14sgen2i.remote.csb (213-44-141-166.abo.bbox.fr. [213.44.141.166]) by smtp.gmail.com with ESMTPSA id q13-20020a05600c46cd00b00412e5f32591sm2761945wmo.28.2024.03.14.09.00.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 09:00:23 -0700 (PDT) From: Valentin Schneider To: Maxim Moskalets , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , linux-kernel@vger.kernel.org Cc: Maxim Moskalets Subject: Re: [PATCH] kernel/sched: use seq_putc instead of seq_puts In-Reply-To: <20240303110500.15239-1-Maxim.Moskalets@kaspersky.com> References: <20240303110500.15239-1-Maxim.Moskalets@kaspersky.com> Date: Thu, 14 Mar 2024 17:00:22 +0100 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On 03/03/24 14:05, Maxim Moskalets wrote: > Using seq_putc for newline characters is faster and more appropriate > than seq_puts, since only one character is passed and there is no need > to use a more powerful and less fast function > Why not, but then why not do this treewide? A quick grep shows ~340 such sites. That makes for a fairly easy coccinelle patch.