Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp204635lqb; Thu, 14 Mar 2024 09:03:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWQYRB/8dr2zosgolEmMUau3SQ2Kb6DDJXFzKSExEz7x1RI8mIOrnJlLPJKiOn21Whx3WiK21XVK38vT4z4UGB1q1NWLYq4HD5w/rTfjA== X-Google-Smtp-Source: AGHT+IFgH5Hf+/j0eWx/RW0faq5ZfzNJmIFkaefOsOOR1l3WP0dYgEKz79xl9Z2QFnMmUm+uSmZ+ X-Received: by 2002:a17:903:234f:b0:1db:c390:1fdc with SMTP id c15-20020a170903234f00b001dbc3901fdcmr435616plh.1.1710432223853; Thu, 14 Mar 2024 09:03:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710432223; cv=pass; d=google.com; s=arc-20160816; b=YBU/eMQU9rgrddwQ8qzXF+WPTLl4tJRsJjuMzeu3pgRyENGls4Z85eTkPFA8aAqpMI cgq/xa4B3fIrJi3hDq/PoSDtKZrHOCYUsckeiERS3xgMoOltFM+/6scT/+FCXemMW68q qsmLuvrGGjFV4Ci4owsZkBN7TwMtDSZ4RUvAwr7YQorAQ2lz3PW5e39D96pNbTnK5/6/ pwnASoj7d0sP35z9vrkKMT9lqRCoqkYy+Zg8oTzOwl1iJ8HVW/pg2MoByyPxjjzeVXy6 FRKUJL70X3reGQr/TUeCiwZEE31hBI4fnpvPMPKdbRYOIh08FLQRJLh/F1e87kprX7el bUbg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=aMYe/+wuIMRrzJVkoVVY+zCmShtZ6kBSGstMUDAkBRg=; fh=SJTWHMvCzobd8cFUS2fwmCF1WMxJS1FwIpBq5480fok=; b=AszjnXHFNAML5uOI+JZKcZiEsW1RsRW4TcucWjVj35zdAQtXzjkpK6TiNnSoz46cRy naUAZIsFabrTxGJpa3B6Ekfof5cSASD5C7voa/KYDi4/0u06AZdFVUlLz1UT7ziqCtQW EpTkWvBU/A+vqHeSkAYHPzQKqjbcB7YwHZHihY1D2nc9DmYWmvsefGB3qQQ++mLN0Nlj 9Pf6CCerVk2f6jQy3hZ0hD2oN0CljSWGSfUOlBtpQcMS8/mc/SEtpqXIRz1jfBTqm/zf a7wTQMjG7aa7h+zrtyCkv0Otug/YXNNNoZqSGlFZ3EfEbStsRPYorB2AvhGDBBo3s+Gg DR6Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=cCMj+ER0; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-103544-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103544-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id q2-20020a170902eb8200b001dd04d57a22si1748416plg.67.2024.03.14.09.03.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 09:03:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-103544-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=cCMj+ER0; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-103544-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103544-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E4DFB28375B for ; Thu, 14 Mar 2024 16:02:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3D76B7350D; Thu, 14 Mar 2024 16:02:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="cCMj+ER0" Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CF5F73180 for ; Thu, 14 Mar 2024 16:02:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710432167; cv=none; b=JHqjmAKY0hEs3maG0B5p7MWbaVq6bjZmwxX8PglflsP4Dx0rFJ1+q6/1cSbOqVKYZXqyXNPzCU3jd73LVs8G9Wj752OkHDmJEnfz4Apy1aZZiFKsTiNTaXfiNKj+ZUPfxVC01C6pYdyWaU+sptwmeoRpqNqaCOacNpLVmAX026Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710432167; c=relaxed/simple; bh=yPIgt4zoNub9ymm4btsAb/8Wg/W9ZfsIoFT2aUWIRVs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a25P54jmTdNo8paNeMkFu17uyeY6+XT6MApI6ePh+Aun+hdwXH2lkw+xyZTi2BSvOhdOXdjp86Fmp33a9BrZPBLXsyCqAwmE+qKMfb0l2kOFQDolQcfUUZ3ebSQkoFUnV2e3seFLi9BGT8e9jHA3m3PNrBvAqMxh85OFPbrgDg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=cCMj+ER0; arc=none smtp.client-ip=209.85.166.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-366478a02baso1965915ab.0 for ; Thu, 14 Mar 2024 09:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1710432165; x=1711036965; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aMYe/+wuIMRrzJVkoVVY+zCmShtZ6kBSGstMUDAkBRg=; b=cCMj+ER0/3GYlBKCLNANcR9SWcGJuSt/yBEMlHUnkybmV/ozXajBE7jgaMsKup7N4/ C41nAHQKjGLng/ERxX0bAa2ZYmJiT4W6V7Ln0m8UjkOOWmiqSXysjKZePWZqvz0L4U8c 9h38GF589mPwENWJNRDWpeSE4bt1/xi1X2mQYq5j9AGLhrggor9tynqzvx51FBz+oJhW a/aDFNOFCUQA7QKmFCw5Irjxy4Y2XvofFOBaMQFlcOm7LO5dJcJfV7DajaVb1Arcj2oC ciOJYYvzq0xbgseUqc/5kOqC7FiOltQsYtkDM+7EaYZ4mklz27C17uuAauIy6wJQJqcf yHwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710432165; x=1711036965; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aMYe/+wuIMRrzJVkoVVY+zCmShtZ6kBSGstMUDAkBRg=; b=Y48Lg9nPS0DTk6XFuRQrrAeXn76xh7TTORqHLwzpTJYOzHm3LIMbqgp+dFJWlmBhxH TVMvRWDAGR3VW7xs1aY0Bg4XIKzLdsdfS0e2WqqgquDTDDVkqFNYPAnm9yMioxkwuLeY Vdeb+alR/4i7bTHsKETyaSLzKIfGf2jz8xnIFhuHrcBXF+4d1YCULySgMyeWMJxoEBJh /lABzDHW7Am9f65Z3uqBMMD9r3IdtOBc12Za+tmPnPiGeuyFHNfUOTWnHvmqUSOHzD0T /eIDT1cHRYMuZbVWdrflWtpuZDHH5STVpE36mWQQNNrzGaQ+e0CCDPttwVVnwZ7tawIx 0bHA== X-Forwarded-Encrypted: i=1; AJvYcCWIGfh+ziOI5GSrKE0QElXCOSBVJUtg0oRIam7Xi5NQd6nMrqVvkdgfxLeHJDShzvJk1AIFtEH4z9W6E/MyjFzgGs2tAff0NlTCVLUH X-Gm-Message-State: AOJu0YzBnu4MXKtvpnM8RtYrr52cKfYb+nP1Xz0X7fqz9ajmt2Hl/yGw G1vWzzLU0ScXc+C+wZZg8DFpBpSU5bwzg9fJim7FAbhnbE8YWmy14N0eobg7fiE= X-Received: by 2002:a5e:c90e:0:b0:7c8:afe9:b1eb with SMTP id z14-20020a5ec90e000000b007c8afe9b1ebmr2505802iol.1.1710432164535; Thu, 14 Mar 2024 09:02:44 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id hh13-20020a0566021d0d00b007c8b1ace770sm416463iob.39.2024.03.14.09.02.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Mar 2024 09:02:44 -0700 (PDT) Message-ID: <7ac9f1f3-9551-473e-b3ab-329e276aa41f@kernel.dk> Date: Thu, 14 Mar 2024 10:02:43 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5.10/5.15] io_uring: fix registered files leak Content-Language: en-US To: Fedor Pchelkin Cc: Pavel Begunkov , Greg Kroah-Hartman , stable@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org, Nikita Zhandarovich , Roman Belyaev References: <20240312142313.3436-1-pchelkin@ispras.ru> <8a9993c7-fd4d-44ff-8971-af59c7f3052c@kernel.dk> <466e842f-66c6-4530-8c16-2b008fc3fbc6-pchelkin@ispras.ru> <085beb85-d1a4-4cb0-969b-e0f895a95738@kernel.dk> <3f17f1d9-9029-4d03-9b0a-9c500cce54e9@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/14/24 9:55 AM, Fedor Pchelkin wrote: > On 24/03/13 06:40PM, Jens Axboe wrote: >> Hi, >> >> OK, here they are. Two patches attached for every stable kernel, that >> gets rid of the remnants of the SCM related code: >> >> 5.4 >> 5.10 and 5.15 (same patches) >> 6.1 >> 6.6 >> 6.7 >> >> Would appreciate if Fedor and Pavel could give them a once over, but I >> think they are all fine. It's just deleting the code... > > Thank you, Jens! > > FWIW, I think it's all good and it eliminates the reported problem > obviously. Compiled and tested the repro with my kernel config. Great, thanks for checking! > Just a minor notice - stable rules declare two common ways for upstream > patch mentioning in backports [1]. And the first one starts from > lowercase. No big deal here definitely but maybe somebody has some > handling of these two variants - by regexps or similar, I actually don't > know. But I see in the git history that Greg also applies the variant > you've used. Honestly that doesn't matter, as long as the upstream commit is referenced. I always do it this way, not my first stable rodeo. -- Jens Axboe