Received-SPF: pass (google.com: domain of linux-kernel+bounces-103549-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Thu, 14 Mar 2024 18:09:48 +0200 (EET)
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
cc: linux-kselftest@vger.kernel.org, 
    Reinette Chatre <reinette.chatre@intel.com>, Shuah Khan <shuah@kernel.org>, 
    Babu Moger <babu.moger@amd.com>, Fenghua Yu <fenghua.yu@intel.com>, 
    LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 08/13] selftests/resctrl: Add ->init() callback into
 resctrl_val_param
In-Reply-To: <jzyc3lehsspybfa7fjzpwwcw2lgyfftsyqysqmpbrpq37aggln@cbjul5wgozu7>
Message-ID: <78991c6c-2a0e-b7aa-1653-4836921507fa@linux.intel.com>
References: <20240311135230.7007-1-ilpo.jarvinen@linux.intel.com> <20240311135230.7007-9-ilpo.jarvinen@linux.intel.com> <jzyc3lehsspybfa7fjzpwwcw2lgyfftsyqysqmpbrpq37aggln@cbjul5wgozu7>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-2033180368-1710432588=:1017"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-2033180368-1710432588=:1017
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Thu, 14 Mar 2024, Maciej Wieczor-Retman wrote:
> On 2024-03-11 at 15:52:25 +0200, Ilpo J=E4rvinen wrote:
> >diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/=
selftests/resctrl/mbm_test.c
> >index 17398cd3aace..ffbfcecf9bd6 100644
> >--- a/tools/testing/selftests/resctrl/mbm_test.c
> >+++ b/tools/testing/selftests/resctrl/mbm_test.c
> >@@ -8,12 +8,19 @@
> >  *    Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
> >  *    Fenghua Yu <fenghua.yu@intel.com>
> >  */
> >+#include <limits.h>
> >+
> > #include "resctrl.h"
> >=20
> > #define RESULT_FILE_NAME=09"result_mbm"
> > #define MAX_DIFF_PERCENT=098
> > #define NUM_OF_RUNS=09=095
> >=20
> >+#define CON_MON_MBM_LOCAL_BYTES_PATH \
> >+=09"%s/%s/mon_groups/%s/mon_data/mon_L3_%02d/mbm_local_bytes"
> >+
> >+static char mbm_total_path[PATH_MAX];
> >+
> > static int
> > show_bw_info(unsigned long *bw_imc, unsigned long *bw_resc, size_t span=
)
> > {
> >@@ -86,6 +93,20 @@ static int check_results(size_t span)
> > =09return ret;
> > }
> >=20
> >+static int set_mbm_path(const struct resctrl_val_param *param, int doma=
in_id)
> >+{
> >+=09int ret;
> >+
> >+=09ret =3D initialize_mem_bw_imc();
>=20
> I just noticed this. Since there is not only path stuff here but also som=
e imc
> logic maybe the function names could be changed? Something like
>=20
> =09set_mbm_path -> init_mbm
>=20
> The same could apply for all these init functions or at least the mba one=
=2E

Ah yes, I'll rename them.

--=20
 i.

--8323328-2033180368-1710432588=:1017--