Received-SPF: pass (google.com: domain of linux-kernel+bounces-103565-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Received-SPF: Pass (protection.outlook.com: domain of seco.com designates
 20.160.56.83 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.160.56.83; helo=repost-eu.tmcas.trendmicro.com; pr=C
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=seco.com;
Message-ID: <9ac89506-a023-412c-9e7e-49aa515aee86@seco.com>
Date: Thu, 14 Mar 2024 12:22:42 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1 usb-next] Revert "usb: phy: generic: Get the vbus
 supply"
Content-Language: en-US
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240314092628.1869414-1-alexander.stein@ew.tq-group.com>
From: Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <20240314092628.1869414-1-alexander.stein@ew.tq-group.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-Microsoft-Antispam-Message-Info-Original:
 naCSPlPYq3HYfX4D2b4ULNK3wfNFNjKU8WgwPfew07qogBMzRgSPmLZG4oPAByBxhRv1cRkpwFnxq90bxKYYnfau9RIIlQ7ejTqr4Hr9Fp4nTae+/W+pB6c208lH9ae07vGTCdfcu9xa+6/FSArF170jz5NSc6QZqvIMevzDkw5yPoiQGDjSef1trcCFf66iXrzj6WOB5XTBb6DxGFZ9BkiO7a1MeXEl/Zb5DpHL/h8VlA6AGDH3+tvJMAnjMQsVpUwplOjcprtvVnT44RAIOaWMN/iUgwQ5V2vUPNcz/U8OWiOJyn9C+sk8h3tdJK1nLw5WGeAXpD4VDh9SwVRW1cbwovLvqzKccfu1RzxGWvQBx8yeXoYP4l2FSVOX2w31pNQs/XWOgUZhDVHGZ295US7tu6OmS4/sO27ufZIHk5bujXRR0mwY9ox7+KPnHlgS5I7Gb9yEjRHJTtF9wvzCidLhAuLb7/eejsIXuGEigMoRxKrprIwOrjfAiKyNQvAiuwUfKzaBuDGGRqs0sk6RLdLBRwfbRVE53F5J2w+bdqFPNanEfhBfrkHqwswd2BGEzl7dovQ4O9QFy/XZepXLG3edRmPyt3LPPY+/pY/j4c2B4O9F+QoTr/6Po1UiLcrY8YjArItcRJnoy3Iaoxw118OlW17QKe7x9dJBFr4jBWo=
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR03MB8847.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(52116005)(376005)(1800799015)(38350700005);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7533
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DU6PEPF0000B622.eurprd02.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	9149dde1-8cec-40ed-2494-08dc4442fd3a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	6+S0eIu+HaN030lx97ZTYfKLTAFQLeHMD45VCUy9QDuTp87zuYhUrlnGUMXX+37DmTC8IC4XrFBNyb58T2/Fgl0CVEJwRg4hrmFRvq6NFFNEPqJZk5mfxQN9AmUvwKCwo2BnCc3xqFgbl0mFKJEgn+wN38RUbVssmhUjYjorS3lAwKbDHyqgXRtH1QTNCW5Lniy9wfT+9t/Ga+t3i/5V3vK1Ck+cNj4fi5WIUrkdS7LKFO5+p91dzlzvHzRPTrdGt3VXUDvCLf/6zWMxbxvdAb5dB0uPxy98LBZRDa4A17CpA8cTK81sE94iGYnKohPC/JOgFnrIlVfjpeyyPWg2E0h78OAMc4xosP869cJzyY6vKXpE2FwZmI7mm5w8ECqz2j7tIq3cUzHavd4iO+sbUZxD6SsPtTVsxUz1OqTWbhIkk8chWckixiq4+ArPgNkZq2ao25cBpOSw8nyJlV9hBCRQv+sEeyoipo2pCh+VFWD8vWVP+YCjcfOM0KA8EFcpZvBTGj8a5LbWNpiUcUjFWTYYWG8rkIpMA2FAdgPJK6YFYTMm26ZEFJ7yGxuCq2qtUWVz2ilQO31h7fq+vtrLeYtrCreKuajGsVCI/1O4YDiUxbFzfPfGEcy/p5W/q+6RW8ptqVZ3UO9ix8NlyQnZ3bpfXIF07b7KkaCKZ0N7ggql0jgM2nDV7fizpv9/is4FbEiKLtwHp2Twgda55sDxjw==
X-Forefront-Antispam-Report:
	CIP:20.160.56.83;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:repost-eu.tmcas.trendmicro.com;PTR:repost-eu.tmcas.trendmicro.com;CAT:NONE;SFS:(13230031)(376005)(82310400014)(36860700004)(1800799015);DIR:OUT;SFP:1102;
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 16:22:53.1750
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d43de65-dcdc-46e6-6b71-08dc4442fff2
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bebe97c3-6438-442e-ade3-ff17aa50e733;Ip=[20.160.56.83];Helo=[repost-eu.tmcas.trendmicro.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DU6PEPF0000B622.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB10365

On 3/14/24 05:26, Alexander Stein wrote:
> This reverts commit 75fd6485cccef269ac9eb3b71cf56753341195ef.
> This patch was applied twice by accident, causing probe failures.
> Revert the accident.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> See [1] for details. This applies only to usb-next.
>
> [1] https://cas5-0-urlprotect.trendmicro.com:443/wis/clicktime/v1/query?u=
rl=3Dhttps%3a%2f%2flore.kernel.org%2flinux%2dusb%2f3469745.QJadu78ljV%40ste=
ina%2dw%2f&umid=3D6ce55218-6f2d-4fef-81fd-77cdf23523ad&auth=3Dd807158c60b7d=
2502abde8a2fc01f40662980862-4b6d276f4d42a6c6c8fc7d375bba2e12c5da85fa
>
>  drivers/usb/phy/phy-generic.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.=
c
> index 8f735a86cd19..fdcffebf415c 100644
> --- a/drivers/usb/phy/phy-generic.c
> +++ b/drivers/usb/phy/phy-generic.c
> @@ -262,13 +262,6 @@ int usb_phy_gen_create_phy(struct device *dev, struc=
t usb_phy_generic *nop)
>               return dev_err_probe(dev, PTR_ERR(nop->vbus_draw),
>                                    "could not get vbus regulator\n");
>
> -     nop->vbus_draw =3D devm_regulator_get_exclusive(dev, "vbus");
> -     if (PTR_ERR(nop->vbus_draw) =3D=3D -ENODEV)
> -             nop->vbus_draw =3D NULL;
> -     if (IS_ERR(nop->vbus_draw))
> -             return dev_err_probe(dev, PTR_ERR(nop->vbus_draw),
> -                                  "could not get vbus regulator\n");
> -
>       nop->dev                =3D dev;
>       nop->phy.dev            =3D nop->dev;
>       nop->phy.label          =3D "nop-xceiv";

Reviewed-by: Sean Anderson <sean.anderson@seco.com>

[Embedded World 2024, SECO SpA]<https://www.messe-ticket.de/Nuernberg/embed=
dedworld2024/Register/ew24517689>