Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp233759lqb; Thu, 14 Mar 2024 09:48:13 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWmEfffKOe3vgHam1LRX0+3Zu4PQfnCZi05OXvyqk1LEImruJJVGCXZpAkOPHVQpZpNsJ8l/ZRzphbwXUVr2qtOzfPQs77qV6ZKx+Ie+Q== X-Google-Smtp-Source: AGHT+IF4gURPmxwEsRynRyGHBeulF+cSGbMeocl3m2g5MHjhRnk/6tTZcFKhQC3K7YCozLqpo4+o X-Received: by 2002:ac8:5dca:0:b0:430:9f6e:e64a with SMTP id e10-20020ac85dca000000b004309f6ee64amr2235542qtx.40.1710434893435; Thu, 14 Mar 2024 09:48:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710434893; cv=pass; d=google.com; s=arc-20160816; b=Px0Ek6CFYGWsrKso9I+GM4jOo9TSeVHnlMQ1fDgeF2/4dSy0CRVBcJNSpe4Km6+LZb fMzpQdPIZGiBqoIvWp0XnUdgQoAvbrFCRJTm+JXBvzODWVQgIaRm2NM7+7st1viUcJq/ zqyGVKADyM8P90RuFNGV3elK9po0FWISmFpmpywOqH7aGiW2x1QcFLmF6k1Yco7Eh29z csvJNh7/6SgeXW6iZcLTDnFHMLUPkwag9dX3fCA5D4jMPH29aprmEYRUFJlxVGw6qzyw uK3lsUKayw2QYAYSoi6R+qlKTHkM8GIetim58lq/OnEQoDkCkSa5npTYFOIGy9FtanTI 6eyg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=g78ootxx2PKlDyJZWejuTTq3avnhjJaV2s9+bqK75B0=; fh=aYCh0LmHpi0Ho6djaE4jgR4ndn+XfOE1MeztQoCNz8E=; b=pQrGZmzpUujbesbGYKcodygucSrEB9DYXXUlHbvU97AuiaX3YcNSUI0t3dvCfzk68c K76aN12AUQkZ/onn2kvlByVvT/r91ykCx82ONuZvfy3TVOHuc3mgk7CAGdfysmkus4fj korj0L1rYTBna30+1gMk5BXSgo41iW2mXetxP8wOkBUXYVERfzKS6Kp4Ci14Zgk2t1Zm Ymb3zaevUxDlnjZATT1Hj3iqp1ZeeT0tHw+ocRLtFnPel5B9hUxHYCuL0mU+dX5eWpNg 9V2oXulf2ZThFMv0FCH38WSEOs20AMsCy2SBS1ejLLV6ZeltXHMcgVp3vBA7zA/zBXQB jpQw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=n6yryM4S; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-103590-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103590-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id i15-20020ac85e4f000000b00430a78bb3casi585785qtx.351.2024.03.14.09.48.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 09:48:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-103590-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=n6yryM4S; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-103590-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103590-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2D3481C20BAE for ; Thu, 14 Mar 2024 16:48:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 64B5674418; Thu, 14 Mar 2024 16:48:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="n6yryM4S" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D4FD6F524; Thu, 14 Mar 2024 16:48:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710434884; cv=none; b=B6LYnRj8hFdWGpN5oftoqEqXRLZLf4zvOm1OMAWdQFN9Rn8285h5qzvXyFAIOF/NcAxURCAWMGdxASq1B9Et3JCOd5jnqL/fwh6DCZqW2l4/HrOhANl96F+47Q3XBGYzYkuoDP6tzwd9UvA+O002agWmTKIixgI8SA0DohFlF7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710434884; c=relaxed/simple; bh=FsEKtAhsZGo5h1PjChAm7sCz44W0i1u7H/cs7wNigB4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AqOnaU3bFk0pDtISLdHCbdLOnSzUb9zWZGT/YOrqiUXX7CfYN32Lpm2YVB11EBEPyCoQl2mbQnCUq7IouN04NRGBQV1vg9dbZq0+LyCcTvHfqMYYSBqOA+sC7V8f/UQLlhTyiItOgxyqxGmjvqQHaT6RAV+15D6RYURhgMncrMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=n6yryM4S; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710434883; x=1741970883; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FsEKtAhsZGo5h1PjChAm7sCz44W0i1u7H/cs7wNigB4=; b=n6yryM4SdcQVhFextOuoFhAt4FxN4yn+v1ObKiSHJaqluwNVzTJcnT5h 4MvKjZ+rFHue4p3jWNubHaiqGSf/5tO72yoawkEPqEkGByZeuypZiK895 jjOvN+yhJqWJ04WYHh4X5im/HzwshAFeRHkSGimOLCGdRYZmCTuxj7C4w 49KQGT4wg5ksm9fdm+vhuo3aWZGg2s0S/jqNtaqfPmxkNmPUiOrqTT7qa WMgzmncv4XI3TyojKIVLaI7c6ApUMZytpEBY6TG/imdE9FGje72WLesoy LuS0m+ugFTaMkMpTbCDJMUefkfS4svxhRrs0xDPvbul5iWdxPCsTzA7TD g==; X-IronPort-AV: E=McAfee;i="6600,9927,11013"; a="5137319" X-IronPort-AV: E=Sophos;i="6.07,125,1708416000"; d="scan'208";a="5137319" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2024 09:48:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,126,1708416000"; d="scan'208";a="43269551" Received: from ls.sc.intel.com (HELO localhost) ([172.25.112.31]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2024 09:48:02 -0700 Date: Thu, 14 Mar 2024 09:48:01 -0700 From: Isaku Yamahata To: Binbin Wu Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com, Paolo Bonzini , erdemaktas@google.com, Sean Christopherson , Sagi Shahar , Kai Huang , chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com, Sean Christopherson , Xiaoyao Li , isaku.yamahata@linux.intel.com Subject: Re: [PATCH v19 027/130] KVM: TDX: Define TDX architectural definitions Message-ID: <20240314164801.GQ935089@ls.amr.corp.intel.com> References: <522cbfe6e5a351f88480790fe3c3be36c82ca4b1.1708933498.git.isaku.yamahata@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Thu, Mar 14, 2024 at 03:30:43PM +0800, Binbin Wu wrote: > > +#define TDX_TD_ATTRIBUTE_DEBUG BIT_ULL(0) > > +#define TDX_TD_ATTR_SEPT_VE_DISABLE BIT_ULL(28) > It's better to align the style of the naming. > > Either use TDX_TD_ATTR_* or TDX_TD_ATTRIBUTE_*? Good point. I'll adopt TDX_TD_ATTR_* because TDX_TD_ATTR_SEPT_VE_DISABLE is already long. -- Isaku Yamahata