Received-SPF: pass (google.com: domain of linux-kernel+bounces-103594-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Jernej =?utf-8?B?xaBrcmFiZWM=?= <jernej.skrabec@gmail.com>
To: Andre Przywara <andre.przywara@arm.com>,
 Kamil Kasperski <ressetkk@gmail.com>
Cc: wens@csie.org, samuel@sholland.org, linux-arm-kernel@lists.infradead.org,
 linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] dts: arm64: sunxi: add initial support for t95 tv box
Date: Thu, 14 Mar 2024 17:50:49 +0100
Message-ID: <4331305.ejJDZkT8p0@jernej-laptop>
In-Reply-To: <55eda2c6-1bca-463d-a908-1887543a47a5@gmail.com>
References:
 <20240311174750.6428-1-ressetkk@gmail.com> <8344274.T7Z3S40VBb@jernej-laptop>
 <55eda2c6-1bca-463d-a908-1887543a47a5@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Dne =C4=8Detrtek, 14. marec 2024 ob 01:19:28 CET je Kamil Kasperski napisal=
(a):
> Hi Jernej, Andre!

Please no top posting as per rules.

>=20
> Thanks for the reply. My board has a name "H616-T95MAX-AXP313A-v3.0".

Ok, we for sure need to integrate this somehow to compatible string, since
there are at least two incompatible versions.

>=20
> I believe these boards are two different revisions and the one with=20
> AXP313A is a newer one, besides incorrectly label as v3.0. Sharing=20
> common configuration between boxes is also a good idea but for this=20
> specific configuration I would be cautious. From my experience with this=
=20
> board the default configuration for X96 Mate is not working at all. I=20
> suspect because of the PMIC and DRAM differences.
>=20
> Memory installed in X96 Mate is DDR3L and in mine T95 it's DDR3, hynix=20
> H5TQ2G43BFR, that requires 1.5V to operate.

PMIC is important difference, yes, but not DRAM. DDR3L is completely compat=
ible
with DDR3. It just additionally supports lower voltages. Additionally, Linux
doesn't care about DRAM type and all. It's firmware responsibility to prope=
rly
initialize it.

Best regards,
Jernej

>=20
> The rest of configuration for both boards, like HDMI, MMC, EPHY and=20
> audio codec seems to be the same across almost all H616-based boxes that=
=20
> I've researched.
>=20
>=20
> Moreover please let me update the patches and send v2 that aligns with=20
> mainline branch. I've incorrectly assumed to use sunxi fork instead of=20
> master. Sorry!
>=20
> W dniu 13.03.2024 o 19:00, Jernej =C5=A0krabec pisze:
> > Dne sreda, 13. marec 2024 ob 18:38:08 CET je Andre Przywara napisal(a):
> >> On Wed, 13 Mar 2024 18:25:14 +0100
> >> Jernej =C5=A0krabec <jernej.skrabec@gmail.com> wrote:
> >>
> >>> Hi Kamil!
> >>>
> >>> Dne ponedeljek, 11. marec 2024 ob 18:47:47 CET je Kamil Kasperski nap=
isal(a):
> >>>> T95 is a most commonly known for being a box with a pre-installed ma=
lware.
> >>>> It uses Allwinner H616 and comes with eMMC and DDR3 memory.
> >>>> This device comes with two versions - one with AXP305 PMIC and anoth=
er with AXP313 PMIC.
> >>> I have this board and it always felt like a clone of X96 Mate, which =
is
> >>> already supported in kernel, except for broken sd card detection. Wou=
ld it
> >>> make sense to unify those two boards and just overwrite or update par=
ts here
> >>> that are not the same?
> >> I think the box you have is an older one, with the AXP305? IIUC, this =
is
> >> about a newer revision with the AXP313. There are quite some differenc=
es
> >> between the two PMICs, though it might still make sense to share the D=
Ts,
> >> see the OrangePi Zero[23].
> > Right, mine is with AXP305. It has "T95MAX v4.0" printed on PCB.
> >
> > Kamil, does your board also have "MAX" mentioned somewhere?
> >
> > Best regards,
> > Jernej
> >
> >> Cheers,
> >> Andre
> >>
> >>>> Kamil Kasperski (3):
> >>>>    dt-bindings: vendor-prefixes: sunxi: add T95 to vendor-prefixes
> >>>>    dt-bindings: arm: sunxi: add t95 compatible string to list of kno=
wn
> >>>>      boards
> >>>>    dts: arm64: sunxi: add initial support for T95 AXP313 tv box
> >>>>
> >>>>   .../devicetree/bindings/arm/sunxi.yaml        |   5 +
> >>>>   .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
> >>>>   arch/arm64/boot/dts/allwinner/Makefile        |   1 +
> >>>>   .../dts/allwinner/sun50i-h616-t95-axp313.dts  | 138 ++++++++++++++=
++++
> >>>>   4 files changed, 146 insertions(+)
> >>>>   create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-t95-a=
xp313.dts
> >>>>
> >>>>   =20
> >>>
> >>>
> >>>
> >>>
> >>
> >
> >
> >
>=20