Received-SPF: pass (google.com: domain of linux-kernel+bounces-103609-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <c0ccaef6-44eb-4851-b336-cdb06647e1d2@criteo.com>
Date: Thu, 14 Mar 2024 18:10:52 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 iwl-net] i40e: Prevent setting MTU if greater than MFS
Content-Language: en-US
To: Brett Creeley <bcreeley@amd.com>, Erwan Velu <erwanaliasr1@gmail.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
 Tony Nguyen <anthony.l.nguyen@intel.com>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
 intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240313090719.33627-2-e.velu@criteo.com>
 <4e203331-62f7-44e7-acd9-f684c30662de@amd.com>
From: Erwan Velu <e.velu@criteo.com>
In-Reply-To: <4e203331-62f7-44e7-acd9-f684c30662de@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NTN6dzg5cmpVZHF3eWM2VTA2UllyQ01CNStMcHZYaDFkaXhZZFFhSzR1Mlkz?=
 =?utf-8?B?RERMTWlnTHJOYmM2V0phV1RqQVVSQWlrcjVJQklFTCs4eFduTWFIdHhFYWJP?=
 =?utf-8?B?UzVtMHdCNDZZV0VZNFl4bHBjSmdPdENlMUNrdGVRU1pZRWU3TVA3N2RCbU1l?=
 =?utf-8?B?eHdvZ3pZRVlQakduQkhqQTZEUnVjek9FYWZraVZOL2ttczVTMGMzSkJNMERu?=
 =?utf-8?B?eklydnZhYWI4UXBVZS9XWUp6WUhuRDJYTURibytreHVIem5SaE1FNmZWN2sw?=
 =?utf-8?B?cTVUc1hpckttZHV1VnJVRFMwTXFjbEdvQmlWV0tJT3ZsNURvQTJXeU5iRmdU?=
 =?utf-8?B?VGZCVWRnMyt6ZnlSSjFqdG5BUU9TOW5Qa09rQno4OE5xQ3dVNW9ZY1ZHVkta?=
 =?utf-8?B?akVIa1V6U0RMR0pwOURoK1lOZkNOTVZSaFEySTh1Y1Y2VGx0Z0MxU1JnYlQ1?=
 =?utf-8?B?akR3cVYzakMyYUkwV0NQTS81RWdhbU5sczRRTWp2S0p3ZWZ6cTZRczBWU3M2?=
 =?utf-8?B?eGZEazQyUFNlL2V3SGJKd1plQ1Avcjd0OHBtemhxUVplcVhBS2srUWlLZ2di?=
 =?utf-8?B?bUNib1QwL3M2UTl0TjNEdXl3OUtEMmFDQmEzY0I4OE5JTDFCV0RlQWNoSHF0?=
 =?utf-8?B?YStCTkhFR0lLMHdta2NTQThrVTN1czBzdWFjbjd3bm9sL04vMTlwaGdyY0E4?=
 =?utf-8?B?aGJVa3kyR0hXemhXcTdBaFhIQnVXRDdTVi9UazE1SklyaGh4cWhxT3ZRV1hP?=
 =?utf-8?B?czZueVlBWXBjbVY4R1hhTHhiS1hlOUgzc2xrc2tIVkMzQlBPbEZIdTNBNmZZ?=
 =?utf-8?B?NVhyWXJXUmVOaEJkMURlalJwVTBOdzcyQVlHMWdIeSs0ck5hay9yRW5FTjZH?=
 =?utf-8?B?Q0FvUDArVkZXWmlLSW5WODVlWWt0amx1Wjkvek9hRFFvUnNpU1FodmlQU0RG?=
 =?utf-8?B?RVNqaERqYUtGdk10V2ZwWlEyU2xNR2RJM1VYRVpuNkxReGJCWUx0WXZ2cEVE?=
 =?utf-8?B?V013QWtnZHNWeThMbHBzdlB1Tm9SR09udGx4WjF1Z0ZRLzBNY0IrVVhSaXRj?=
 =?utf-8?B?MnJERytrek9OMnV1MWJBSjdkb2NzZWtGK2lETC9OTnJxYVZ2bDB4amNpaHpV?=
 =?utf-8?B?N1dUNjdXWEVnR2hMajEyQi9Ya0tJZG11SjRsWWE2NFo1SHFQK3pTeW95eDAx?=
 =?utf-8?B?SGhua3pySE10TDdabU5jd2tSQUtaNndMZXVXM05VMFNTV0RqaU5wNzkrblhJ?=
 =?utf-8?B?SkxqM2VYbDBhSXEzNUNVWVl3cGhITDNoTE5JT2UxbTJtckpnOStpdU12YlNs?=
 =?utf-8?B?NTFaODR1QnY1U09FeDA1bkp5WTdPbndKZHBlUVVocVR5b3JUVk50V3BXRmlq?=
 =?utf-8?B?SkdJQnIwV08vREdDTzdTNHBLMkFaVWNtVFdZb3hCVVJRcTVaNjRJNjZFaHNa?=
 =?utf-8?B?Y1pXOVpjMGtUY2paRFNaUEJEc3pqSWdxaUEySzd0N2NvckFBWGZIUCtNVUFa?=
 =?utf-8?B?VDdBTUJ6SmRVVGtpTnh5dUJxeWFhM09PcEhwdGhXOG1XYnFWaDBjbHo2cXRW?=
 =?utf-8?B?Z0xSaGx3OWxvYWhiVXdXMjdlODh4QVc4UkVCZTY0MnZxa1RUTStpOW1oT3Bk?=
 =?utf-8?B?b1JRSmlkUTVOQW1oNmx0S0MxWHBMZ1VRbkpVU1h6a2hRWkJNQWNRbGFiN1ln?=
 =?utf-8?B?SmRwcm5wTGh6NWJWMEMzcCtERGV6UW83d3BHSXoxMjN4bUc0Y0VpS0VZam5F?=
 =?utf-8?B?MDFkNjlRd091R1FmeDRsRXFGVUFlZERVYjVpR015aHA5NlhmbE1UTTdmK1k4?=
 =?utf-8?B?bWlOblRzc0g2N2hGaEpMalpFMWpCWjJxbUNHMDB2UWYzeHlXbzdwcERLTHdw?=
 =?utf-8?B?NUxYR21vNlQ5ZStCblNRUGFHeStYZnBFVjc1bTM1L0hZaHRmVm5na2ZmNkR4?=
 =?utf-8?B?dllVRlBWUHhjVE5wdGVHMSszSG5zNUU3ODllaXRJc0lUTjczakF6NjBpK0tm?=
 =?utf-8?B?azNTTTVEVlRyazFPYnAwc1hRb1VkVUk0TXRzcGkxZC9FNC9zYUFBVjBMendz?=
 =?utf-8?B?aW1mN3hEQVIrQkZyU2FhclRVRmpqNXc1NUtLcWVaZ05iSWF5RjYrQjRpclNK?=
 =?utf-8?B?NzlFN0dsSXFKRC9EL2JGeHE5ZzMzYWgzOXpIWmVTODJkekdlYk40UnpQUmVO?=
 =?utf-8?Q?sQeEcSKr3qHrkU4xSbKVt2Fq19uDlTMVYGyBlPwsugPf?=
X-OriginatorOrg: criteo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48bd102b-5909-41c5-00a1-08dc4449b586
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8989.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 17:10:54.9657
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 2a35d8fd-574d-48e3-927c-8c398e225a01
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OehxWiFxaBNFccW1Ag22wVGbM9C+twf9Ytj7ITxQ5AbPek++9o3kTaaa1PN2He26cr75DYhDpjI6OyfpvevzDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10177

Le 14/03/2024 à 17:10, Brett Creeley a écrit :
[...]
> If this is how the max_mtu is determined, does it make sense to set this
> before registering the netdev, i.e. netdev->max_mtu in 
> i40e_config_netdev()? 


The absolute max is properly set but I think that's only true if we 
ensure the value of the MFS.

So if with another patch to set the MFS to the right value when asking a 
bigger MTU, having this value makes sense this is the absolute max for 
this device.


Erwan,