Received-SPF: pass (google.com: domain of linux-kernel+bounces-103640-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <d16ff01c-4a01-4871-93de-a5c26a352301@amd.com>
Date: Thu, 14 Mar 2024 10:55:02 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 iwl-net] i40e: Prevent setting MTU if greater than MFS
Content-Language: en-US
To: Erwan Velu <e.velu@criteo.com>, Erwan Velu <erwanaliasr1@gmail.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
 Tony Nguyen <anthony.l.nguyen@intel.com>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
 intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240313090719.33627-2-e.velu@criteo.com>
 <4e203331-62f7-44e7-acd9-f684c30662de@amd.com>
 <c0ccaef6-44eb-4851-b336-cdb06647e1d2@criteo.com>
From: Brett Creeley <bcreeley@amd.com>
In-Reply-To: <c0ccaef6-44eb-4851-b336-cdb06647e1d2@criteo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OVh5clQ0ZmdDRTJPSXQ1TVlLLzdUTFg3NWY5VHZzVnVSNGhWTnVzQjNuTlVU?=
 =?utf-8?B?cy9GNE9wN3JqbDhmK1Y4UmdWcW9vWEsyc05xbmJQeUMxTk1GRWFqbTM1dVo1?=
 =?utf-8?B?NDNQWmw2cTVmWGNCN1VxM0tEdEVHdVpHWkNSY0M3eXJISDJ5ZUpON1FNRGFr?=
 =?utf-8?B?QWZkeDNrZGx6QWJWL05IaENSa3VMOWZlaWU4bnA3VnlZKzJSVGltQlhjTDhE?=
 =?utf-8?B?dTAvaWU2ZVJKdU95L1VTUHRldnhNRDNab0VyZXVXb0xMT2pYYjhIWFZ1dThW?=
 =?utf-8?B?dDRTZnZ1aHJ3dDBDM1BUUkFYY29yd1hNd25OQUNpN1E1REp3bm5jdmNlN1Bo?=
 =?utf-8?B?d0J5ZnJsUHZ6d25WWm10TzhMVzRQVDJVYkEyODJteHFSVHdSRXcrdnF3emI1?=
 =?utf-8?B?K0NmZjVUYUhZZlNsdk1zVTBpalpOOU1mSXNoVCtmVVJ3UG9TMTNGUVFCcUd3?=
 =?utf-8?B?NmNZK2FOTVZnVWlneUtrcVRCZ0Z2OFcrbHVRQWlEVGNKd1dxUGJIbXI2UlNC?=
 =?utf-8?B?M3N2bXgrNy9aNkl0NHQ2SW9lTVJtOUtkWFFuWVdiMGdrWkRxdkFRbEMwcFlm?=
 =?utf-8?B?WXlkcFRXNEMvb1Z5bkxiRktBVGQ0NzlUZ1JtemZvRGNZYUVuaUhPL1BYSWN4?=
 =?utf-8?B?bklIbUU1djFZWEp5UkNnMnFxTHdqazZ0enNwRlQvT21MdVd3cENjRFZDV1FE?=
 =?utf-8?B?cVlDVnpoaElBd0VuZFM2QnJ0ek9zOGNvazc5cFJBOFBUUC9KcXlPazdYY0RR?=
 =?utf-8?B?OHQ4bExrOENaY2pZa1R2aWhvVlhVdEZmdFhsYXVRbXN4UmJSSFhHZDMydU1E?=
 =?utf-8?B?L1RWNEllYVduK3RQSnVTcFk2Z3pQdjQyR3cxUHdtVGFyY1FWQkkrZUoxVTVl?=
 =?utf-8?B?NlZ3VkRlNThGeG91Z1pOZ2RMemJRL2krTGpyelB5NHY3b2kvOXhBV2xCbHRk?=
 =?utf-8?B?d093YzJmcHJORFY0MWd0RHl0LzNDWUNUV2F3c29kMUdqVktITFdYcmNiNk56?=
 =?utf-8?B?SWFCVk1SZGE5Wk1HRkpDa1RBazFMSXZSMWpnd3gzandsRjdLQ2UyRllQV1hv?=
 =?utf-8?B?SHNJN3EzZ2o4NDZ4VDJSL0VCVnVBVWpseWYrM3AySmwyU3J4QzFIK3J3alp5?=
 =?utf-8?B?WUkzeERIM3o3VkFNaDkrMDAyUUsxOFJFOXdOQmF3UWhOR1ZuQzBTWGtvNXdJ?=
 =?utf-8?B?dWlwaHo2WVNMdlZyRDdXUnVsSHRrbWZTT1NSV21tN1FxN1RGcXIyWVJtd0RF?=
 =?utf-8?B?bEZLblR2L08rTTFoQmtXR2NUcDZ5YzRLd3VYVjVxbUJ2S1ZpZ1hGUVBXTFhj?=
 =?utf-8?B?dWZNMUF1ZGQ3TXZFejZOaWVFdkhkKzVXc0sweTZiSW5vbG9EcHl1d0R3clFy?=
 =?utf-8?B?RS9wSlhBUitvcXBqRGF5T1pkM3czZUZPV1V6eEs1dmFUMnlLT0VOdXFaK0lw?=
 =?utf-8?B?dXZybU4vOWJGSVR4dHpQUjBjWURZQXBIVnBaNnR4VDd2WlRBaGhOMmdhakJU?=
 =?utf-8?B?bTIrZFdia1Y2b0FBaEc3L25FcEdJenJET3pJNGYvNC9jcUtjT1pQbzk1K1E1?=
 =?utf-8?B?WURsL2JhMUM1TTNsak5kSDcvQXM5RG90S1lQOXRud2NJWXpvUWFzbWFtWGV5?=
 =?utf-8?B?ckI2d0Q0TmpMakVYVTgzajdGZXFSZ2IrUXdVc3lFQm1qelVReVluTy9HNzB5?=
 =?utf-8?B?QTZDS2NJbUF5MW5XL1RQVmZvbEJwa2J0dWtRbEtHQSt5MnU3aStYYklWem90?=
 =?utf-8?B?bTBxN2NpS2syYi91eHdnWHpSZFlQVndpNWR1dS9LNUkwNVlMblpzeHFEQ0cz?=
 =?utf-8?B?bHRIT0dXNHlBbHRndEhDYWtrWERmT3VkM1gzV1UxckJ3SVovQ2RkaHZpbDFt?=
 =?utf-8?B?SGphdHdPZjV2aEk0SmpjdTc2eDdzM2RrTlhoWUhnYmdCbno0K3FwRnYvdHpQ?=
 =?utf-8?B?Qy9saWh3d093VHdQOUhYRXRtL0RvQkpYV2ZqTEIvTmxQc05kYllpMDFHaGhy?=
 =?utf-8?B?N3I3QVFOTjF0SVJGWGxmdHpPSXlQZWc5ZUZiY1R5ZXZ2L3BOL1d6bXhVUHli?=
 =?utf-8?B?T2EyMlVuclFxdXIxTC9rSmM1c0c5eVhvRURsTDlzTnhlc1hycER6NDlmZGxZ?=
 =?utf-8?Q?lgnNW6x+Fz3KAh0SjqNvpWa1M?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66187f94-b92e-4f45-a9c8-08dc444fe13b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB7982.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 17:55:05.3054
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1H9SH7N1n7dxCPeM3b5ste5Y84zUr2pyTVAR93VLxtQlCNKkM+vJN5eKcAv6AfU/j0kuBQOl8Vwm+p72daCPzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6921


On 3/14/2024 10:10 AM, Erwan Velu wrote:
> Caution: This message originated from an External Source. Use proper 
> caution when opening attachments, clicking links, or responding.
> 
> 
> Le 14/03/2024 à 17:10, Brett Creeley a écrit :
> [...]
>> If this is how the max_mtu is determined, does it make sense to set this
>> before registering the netdev, i.e. netdev->max_mtu in
>> i40e_config_netdev()?
> 
> 
> The absolute max is properly set but I think that's only true if we
> ensure the value of the MFS.
> 
> So if with another patch to set the MFS to the right value when asking a
> bigger MTU, having this value makes sense this is the absolute max for
> this device.

AFAIK there is no API for a user to change the max_mtu, so the only way 
the device's MFS would need to change is if it's done during 
initialization time, which should be done before netdev registration anyway.

I guess it's also possible that the driver's XDP configuration could 
cause a change in the device's MFS and netdev->max_mtu, but that would 
be under the rtnl_lock.

Seems like others are happy with it, but FWIW that's my 2 cents, 
otherwise LGTM.

Reviewed-by: Brett Creeley <brett.creeley@amd.com>


> 
> 
> Erwan,
>