Received-SPF: pass (google.com: domain of linux-kernel+bounces-103643-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7b612db6-cec6-4873-8a38-fb4c97192aa2@criteo.com>
Date: Thu, 14 Mar 2024 19:04:17 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 iwl-net] i40e: Prevent setting MTU if greater than MFS
Content-Language: en-US
To: Brett Creeley <bcreeley@amd.com>, Erwan Velu <erwanaliasr1@gmail.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
 Tony Nguyen <anthony.l.nguyen@intel.com>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
 intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240313090719.33627-2-e.velu@criteo.com>
 <4e203331-62f7-44e7-acd9-f684c30662de@amd.com>
 <c0ccaef6-44eb-4851-b336-cdb06647e1d2@criteo.com>
 <d16ff01c-4a01-4871-93de-a5c26a352301@amd.com>
From: Erwan Velu <e.velu@criteo.com>
In-Reply-To: <d16ff01c-4a01-4871-93de-a5c26a352301@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VHMzbW8ybWZ5TndnVFNhbzNETFpyN2ZaemR5MWJua2xCVzRORjI3S0xxckxs?=
 =?utf-8?B?RFordHBtQW9xV3k1aXhZaEJpcmszdTNEUE0zSThuVTB4OWdaOGVKZm5MZm9i?=
 =?utf-8?B?U1FLdTNBYjhGeDFWUGlkRVB0WFlQWlM1ZWJqTFRxU0tSQXkrNExkamsxbDZn?=
 =?utf-8?B?QjJiNjR1LzdLYzU0YVpUVnNRYm0wL0tPY05OZ0ZCM0I2WG5tcWxmRVJWSVZZ?=
 =?utf-8?B?Y2NHQzVTa1ZrOUUreWJBck1senpibzlBRUpuY3JEa2FpZTlhL1htYjl1OTB1?=
 =?utf-8?B?Ry84WjRRekZ2eDdGSG5rS3NRZm9KYThWK1FhV0M5Q3hLV0lVaHVDbEFsZWtI?=
 =?utf-8?B?Qk9pUXpSQVcvM3NldE9wZ2wwSDFqSms5RVI0bkp3VGQ3N2FSMEZOMzhGSkM1?=
 =?utf-8?B?SGFNR1NJVHVpMHI1VGFSMndjZ0FHSGFKVGRBZEtZN3ZHUlluWlFPdXYydHRp?=
 =?utf-8?B?UE5QZDVKcnhQUU02TG1uMzJKcnA2ZitlN1g2eGFlVXJQZkRaWUlRWm9JcUpx?=
 =?utf-8?B?VWsvcnF1Wk1LM09vd2p6L0IrOWZ4eWovZjRWU09rdFZldnprV1BJRHhaSTlL?=
 =?utf-8?B?WUw1SlY5UFl4U3VoeGcwNEJMSTE1Ull2c0kyb1p4cmUzeCtQaDV2TkRITVRs?=
 =?utf-8?B?cWxwb0hnZnM2MkpZbVg1UkdyNGVXRHAyOXBxb3NTYUZUbEJ4MUN3YWhGRzJh?=
 =?utf-8?B?N3VWVjl3eVNROXNKcUdLSEF0VW5IUDQ2Mm1RckNvVUZjbDFVeWRydTFwWWVr?=
 =?utf-8?B?elByTDh4c1hvV21OQ2IvaWJsT00zTmRwRzFCaXcyUXdlLzdvVE9QVitjYmFp?=
 =?utf-8?B?Z2piU3EyWUZYWnpGcUZLTGVQbTdjTHR1TDBWZCt3YjlBZUgvSXZWZUJNdURa?=
 =?utf-8?B?VWFkZDdIaVZoWkh5cWpXaXhkajJWQ0RHRFJqVExYb3l0Qi9SNXdMVGgzSWNu?=
 =?utf-8?B?anh5bEJYc214dDZVOVFvdURXV3dtcjg3RGUwNjFNV0VOOGIzUllDQm1FWUZS?=
 =?utf-8?B?cXdJcHExWU1lZ2FUVlFhUmZBRFRURmlYaDc5RkYwaDJST1hXYlYrSk8ycGxT?=
 =?utf-8?B?VjRDdyttZFZDUmFteU5HZ25qUlNPZ0I0Q1RTN0hPZ0hodXQ5cnUxUVpJVGVY?=
 =?utf-8?B?d3IzbTYxY1R0a2hhdzU2VDBlcG9JTEszd1huNERtdzF5VnVvOThtek9zT2Jq?=
 =?utf-8?B?TGZpWGx6RDhNVEV2OWR5OWp3S01ZSkxFbWNUSnNCZWxKUkFPMmFMY2dTeS90?=
 =?utf-8?B?aW5OYW5tY2FJZ2p5SEJyNm1Gc1RwUlZla3dzQklYdVA5ME56RUp3bzJ2eXBO?=
 =?utf-8?B?VFJzVFc5cVZQbWJjY3d1d0pTL3lNdklJVDVUZEhxSVF5dEpaYTBxdXBRUmVG?=
 =?utf-8?B?SnY0STR2ZVZWSkFZK2lPWm5oRndjclJXWjhEdmwyTDNFTGZNSXRZR3hJbW9S?=
 =?utf-8?B?ZVpXU1hJck9ZUmJZbVdzaFNJanpVNmViODZVWGVPd0FpRWprL1g3M2hVRGNo?=
 =?utf-8?B?eDV3eGJZZy8wVDFMV3JkTndxcFJUdVRvSHRYM2Z4M3Y3TFdBTGRIMVBmaG85?=
 =?utf-8?B?NEFCdmxXZzY4VkNsOXg1eGU2NlhZRFV5M2MvRXF4azlQZjZCeDAwQ2xEZitM?=
 =?utf-8?B?Zk8zZDYvOVYzWHlKZzNrRm1NY3dXRVV4bFVaQ04yZEJHNmd1cDhYN1JrOVJY?=
 =?utf-8?B?eTA1Tjk4czFHT2dqM3VpdTlvZ3NVM0VVUzhsc0trQmNEaG5SRkxrTVFFSU4r?=
 =?utf-8?B?NFBNYXVTS3JISFZ3ajRXUXlnVjIzbXd2SkdPWWxFbzlucitxN1BoTDh6TkIx?=
 =?utf-8?B?SDcyVjRxeEgzVUE4aUVxbVFBc1Q2czNDOE8wSC9CeGw4c0pVcUxyUEVvbno0?=
 =?utf-8?B?ZWtnSzFkWS85S2dTL2V0UnNVSStXRXkwUExPaGNCUEE4VFJudkJVSjM4VXhD?=
 =?utf-8?B?d05jc3dOeEJGQlRLVlJYUlR6THRPWVUrSjZ3SkZ0N3RKUjFvNXZqajg1dVRQ?=
 =?utf-8?B?WFp2dUVMb2MvSUhiR2pnR0RKbGZ4dGtSNTNLK3E5dEpBa1MvSHEwNER3NTRh?=
 =?utf-8?B?b05hNHdPYjNEZVk5dXBOU0RNSTUvVkh2eGszME56b1ZodXN1Q0cxd0pnbnhH?=
 =?utf-8?B?T3FuaUhUc0E0aGwyTFBUcW9qVzc5ZXZMRzJuZ2MwL1lhRDZjZUNNaTd0U3Fl?=
 =?utf-8?Q?b92th+kZzWdnHjottPO7ZxFXsLVSWyv2RdlxW8E3HfPZ?=
X-OriginatorOrg: criteo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5fdcd62-6f44-40a5-bf29-08dc44512b0e
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8989.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 18:04:18.8658
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 2a35d8fd-574d-48e3-927c-8c398e225a01
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cwb+Xws/MF3bCtNsK2L297GLIybtz15bGOgM2mAjJ2Rt4QewvEGeW0RlNVAnXof93ILg4GG6WoX9Mq9osvugoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8691


Le 14/03/2024 à 18:55, Brett Creeley a écrit :
> [...]
> AFAIK there is no API for a user to change the max_mtu, so the only way
> the device's MFS would need to change is if it's done during
> initialization time, which should be done before netdev registration 
> anyway.

Sorry Brett, I was probably unclear and please note that I'm not a 
network developer, just a user that faced a bug.

My initial though was to check the mfs size in i40e_change_mtu() and if 
mfs is too small, then let's increase it.

Maybe just resetting it at init time to the largest value (which seems 
to be the default fw behavior) is a best approach.

I'd love to ear from Intel dev that knows this driver/cards/fw better on 
what's the best approach here.

Erwan,