Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp285229lqb; Thu, 14 Mar 2024 11:06:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXC9H3LxhADQJ1kqaqtuBe4GhPco5/v9c5dD9D3vBmXThdwTQfKNXyOuOYffraAOVKRI5/2vPgCY2TQEawowRgssyi005+leHzgnr86qw== X-Google-Smtp-Source: AGHT+IHE6nsKjxxhnsjGuGfDU+oBwqb3jjKH1fRAc1ojOiutVYRI8U9KE+UTTS4IjNijlZoo8Yyj X-Received: by 2002:a17:906:2b13:b0:a3e:6aae:d342 with SMTP id a19-20020a1709062b1300b00a3e6aaed342mr1575832ejg.47.1710439616991; Thu, 14 Mar 2024 11:06:56 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710439616; cv=pass; d=google.com; s=arc-20160816; b=ufwuHclt4W4fh64KtPKgGUFUDIh1l1DV27AW134iVf9sU8V3+dEZHfIZq8kKYDx63d Khjhb237DljcZ7wzIhY/znRoi5nIebpaBqmjQvexwqTCIsCrtuNckSI1VyBj4MOBkHWY SVYMbaC7sA/bauesgES9ebw1fkd2DV87LFteUjUhLrtGyL7G2C1zeY3DhDCp0CYLg1eq hCb6fL3hDkjoyeU/7XPcKy1oDle5NsjW1BsgygP7DsjJRN1Btd4pvdwJNlp72op9CjFL dcjt2Z6XevjbBdSSaEujCHvk1kf2hfWhgSI//J21l5M1TyYmT0XV1j73qgJ7smorA80O hGQQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=dFDNZyuAIw8aoddhMktOJ3szGAzk6RfcWq45ln5FMe4=; fh=V46wgF11vVOv71zhuLDLISq1d/+Bw5pvh++GK+Qb2js=; b=oZd8LXmbDvz68bxgyiWs6gIAVCMHpnKjLWB3jJ0EWFN1Zx3Wdi0AnHiwKGRUfZCPEw Y2PrDJSM5c/zDA+43tyivlYtXyQf96AExiJbQGYgsXb/6rW4RjlIRV8ykC8insn/x0sQ CCdK38uiDeb67nw+6qb4U6RlBVq8p/VMrTTok8VzAqdYu2SCQ4fJqcgLS9+phAn1QMUL VKfD5IMX62dlf0M8k+tF8IgSaFgTdLeBLtEmQY360IzTan8P8E8HVS5y2Apdqn/Kj0NP DooxwO81Q6VptDpnJ5NeCiHvnpda7xhhTrk23vM5zJpU2dy9m7gfNPDSHVh9GGMpkt+n 7kNA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=twFNsMJC; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-103641-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103641-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id pj7-20020a170906d78700b00a4427d8ef7dsi892277ejb.225.2024.03.14.11.06.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 11:06:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-103641-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=twFNsMJC; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-103641-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103641-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 59BF31F22D0A for ; Thu, 14 Mar 2024 17:59:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 50CDB74C01; Thu, 14 Mar 2024 17:59:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="twFNsMJC" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CE51745E0; Thu, 14 Mar 2024 17:59:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710439186; cv=none; b=QAttnJo2Ec6UVD793CbvaBUwaao0/OWz4tYRoO0VWyMuCbCtloIvGQbFGYJ5MpO8vszT0oO43hzDzfDdNjo0Xg94rf3C+Iims0lHhTQ3S3fDxpIDYbWl7uVGBMSYSQZipk31BgobJiYSMh1ywtaLWl2g5qpHZzpNIvUEkNtCfJ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710439186; c=relaxed/simple; bh=dFDNZyuAIw8aoddhMktOJ3szGAzk6RfcWq45ln5FMe4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UnauaqID28UP9cMQuCtmlBZ6lnYj6bu2iiSnzoF5EBqmCn3wGCZx/c/MoV3SBf3apmyjuLGDSLFCDoSKyZzZOHQC3+OMspUXWpgRH/DwxbFB6w6Aodk32qnjLMItPXPoJMdyqv0rPiAZtOdRLIoiP9nJIwnvrKrxqxIkLfMmjcI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=twFNsMJC; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CF39C43394; Thu, 14 Mar 2024 17:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710439185; bh=dFDNZyuAIw8aoddhMktOJ3szGAzk6RfcWq45ln5FMe4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=twFNsMJCiGgqQPBRH+4sna9vJbTvsAR38YxtKDQ+ZH5WcjXKioLnMbjIf3WDstNJ9 NJn10+85Xa/qTS+9L8JgsEr6LGCKo8apeMrSirXG4EPi2MH/Z0Edo5Dei+yebWQUWn tkNhWqnx4c95ip13RpDX29NlV6kqskruuw42KSg23kquOGEqWQXTuXA1CNPGcg+fUj y/qB86vsvzqaOb6aVbYgORyujsX/klDB4BT0Wz3tbpG7dGbfHpRy8e6qIx/lKQwT1n viAklUi8yZKvPahjV9AeN7Pc7k3nlQkcn8dUbwHlVMlmD0WvqcEUCFc5vETrzonEAq 0eWENzM0L7qQA== Date: Thu, 14 Mar 2024 10:59:43 -0700 From: Jakub Kicinski To: Rahul Rameshbabu Cc: ahmed.zaki@intel.com, aleksander.lobakin@intel.com, alexandre.torgue@foss.st.com, andrew@lunn.ch, corbet@lwn.net, davem@davemloft.net, dtatulea@nvidia.com, edumazet@google.com, gal@nvidia.com, hkallweit1@gmail.com, jacob.e.keller@intel.com, jiri@resnulli.us, joabreu@synopsys.com, justinstitt@google.com, kory.maincent@bootlin.com, leon@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, liuhangbin@gmail.com, maxime.chevallier@bootlin.com, netdev@vger.kernel.org, pabeni@redhat.com, paul.greenwalt@intel.com, przemyslaw.kitszel@intel.com, rdunlap@infradead.org, richardcochran@gmail.com, saeed@kernel.org, tariqt@nvidia.com, vadim.fedorenko@linux.dev, vladimir.oltean@nxp.com, wojciech.drewek@intel.com Subject: Re: [PATCH RFC v2 1/6] ethtool: add interface to read Tx hardware timestamping statistics Message-ID: <20240314105943.7bc6f2ef@kernel.org> In-Reply-To: <87v85ovj4d.fsf@nvidia.com> References: <20240223192658.45893-1-rrameshbabu@nvidia.com> <20240309084440.299358-1-rrameshbabu@nvidia.com> <20240309084440.299358-2-rrameshbabu@nvidia.com> <20240312165346.14ec1941@kernel.org> <87v85ovj4d.fsf@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 14 Mar 2024 10:01:49 -0700 Rahul Rameshbabu wrote: > You need the pad to match with ETHTOOL_A_TS_STAT_PAD (which similar to > other ethtool stats currently defined). Otherwise, you run into the > following.... mm-stat and fec-stat are good examples. I don't understand. Are you sure you changef the kernel to use uint, rebuilt and there is no ETHTOOL_A_TS_STAT_PAD anywhere, anymore?