Received: by 2002:ab2:2994:0:b0:1ef:ca3e:3cd5 with SMTP id n20csp302370lqb; Thu, 14 Mar 2024 11:35:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUTPwK2+SZdYwVVk2AxKwBG9LLg1aScqxh9Ar22cwLLkyxBdd/YZTrXYhJygiUsxZdT+OZ1MNXD9vTVqRLbY/80W0WeLMqgUa47Z9MAXQ== X-Google-Smtp-Source: AGHT+IGUcbpJ3D1Ngj8bsvzMyBtKy+EeC1CznBQl+tbH9C7FTgzYAs4OmpubnnErlsLStedsVEhm X-Received: by 2002:a05:6402:3998:b0:567:6a66:d101 with SMTP id fk24-20020a056402399800b005676a66d101mr2224581edb.31.1710441309616; Thu, 14 Mar 2024 11:35:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710441309; cv=pass; d=google.com; s=arc-20160816; b=YRZrrnwDvkUWnNPuiFFIkcfcCyytJ//v4QWX2PplMLfdOciKCqaQBZQM5sDSheSBnC 1mLI+jGfgsbpHi3W717lgc+PHiPAhlXAC7I9xnpdEngC21mtUhvNG4dYTC7QThgOzGhJ z+di6/5zZUwsf7u6cQk72enQHj9+2+RzLYUCM/SelrbI3FHDw8/dDWK72m+M6gazkqp8 fvoWGaC8/Wi5GCCv8xFlE++9XnRceKhoyFPVvPNbgFRJ9tZd1UNM9uY9Z0K1DlAPNbMD FGGZyE+s4friLUPUe9YWaPCHBvte/rQNfv7lh8Fn+8Q3VZRnUtilfOxWR3YwjkFmskoT xwdw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=V4E/JI2WlzgjNFeY2gp8djSK5DarS7CxAdF8F4JLHg0=; fh=pPQyrnIyNyY5gdkxa/ZgkX263IGCPupDlG7PessB5uQ=; b=u6P5UapeLa1d0OXKHzINZ3Ds09coOpS6qC8Ouu5MmxDV2VXn3tfvxA5QnhynYE8Rx/ d8EDqPbhhjLy8RmXEb9fjPtFRt8tMf3iBKXPmNMlx9R0NtjAe1cqeAJ4ejR/apGZgHg5 BDjrgIchL+D0+tMWsKoyen5VwvgtzGSqb4vn8HbJnomoywLz3TzRZPHXq+uX3JoHBH1o coV6+8pi2hvuupqq2NEo1ReliDVKpUhK1nMF7vPtixdYYqazHpYaNsBKnKc1trHrftGY 8dUeuqW2/756UP+2y182Nr8LdC5Z2q96U6i93If6unIn88YfyuotXnJTGU5hp6aKZIiX 2ubw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a+jUWnHd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-103673-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103673-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id b20-20020aa7c6d4000000b0056881f32339si963624eds.374.2024.03.14.11.35.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 11:35:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-103673-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=a+jUWnHd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-103673-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-103673-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4BE1D1F2206E for ; Thu, 14 Mar 2024 18:35:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 77A8674C19; Thu, 14 Mar 2024 18:34:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a+jUWnHd" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CB3B1A38FB; Thu, 14 Mar 2024 18:34:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710441297; cv=none; b=ctjqf5udzvARO1t2iCgg82LvhB3uXrzV1+hVc28B2HspZIsDq90EJE0PBXfhzZIemLHdW3MRJcYAce5+Wm5aAXkq5dpKj3bdoPbyjreO9gY9IXpSJNb48YTGKPXkTCkHU91QNC4loGNx5NSy7cmne8+D6FEZOMlaCXeffwR2YUg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710441297; c=relaxed/simple; bh=/Vt9G3MB7vSqqQzVnMSe8pAnjzC1rvozbwallsCWSnA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZBxNSwI5Mz6pwMxD8gGh4mS/IdnAoWnb08FgYOHBPRzrG2H5F8RSFfN80xqy6VbJHrx6RMLu3BGjR+pD0W9esvTJN/OabTY1T1eydEtuKfsp0WxGwiy3xAigIAZ2YaE5+VRGp1voCz3O4MaRKDVNU4bjl0d5h7KXfpMPypKu8ZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a+jUWnHd; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A675BC433F1; Thu, 14 Mar 2024 18:34:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710441297; bh=/Vt9G3MB7vSqqQzVnMSe8pAnjzC1rvozbwallsCWSnA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=a+jUWnHdjSstOKo6slsJbBzqxJg2KgOYE/LzwCAW2IuXyAwhdvx47cUSqsngKZq3m RdvP9biRaZOiTnYAfdIQisCrNjHDVrLWVgv1wkwelsR6sr3Z0uYkf1eXfBCcWz6cDs UAxcE1R0Jk4GCLHj3EZ09u1xvmfbMC/UGNzu826vgCpSY9yVc0OXFgWq8ej0nNPZRH 3h34o0IMd4TmrZJbD8Q4cBytN/Dsda9wO06QVg7pk1hhZ2QqkRT28Shj5Zkg2H25j1 VVYx2NCdutNwOmdrD/Y1C9pMD5astVeTjJtFS9bfdqn2HOtrD2xpMV+hx1VlLPWbnv MiC7WP6z0ouew== Date: Thu, 14 Mar 2024 11:34:55 -0700 From: Jakub Kicinski To: Mark Cilissen Cc: netdev@vger.kernel.org, Hans de Goede , Eric Dumazet , Breno Leitao , Ingo Molnar , "David S. Miller" , Paolo Abeni , linux-kernel@vger.kernel.org Subject: Re: [PATCH] netpoll: support sending over raw IP interfaces Message-ID: <20240314113455.152cebc9@kernel.org> In-Reply-To: <20240313124613.51399-1-mark@yotsuba.nl> References: <20240313124613.51399-1-mark@yotsuba.nl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 13 Mar 2024 13:46:13 +0100 Mark Cilissen wrote: > Currently, netpoll only supports interfaces with an ethernet-compatible > link layer. Certain interfaces like SLIP do not have a link layer > on the network interface level at all and expect raw IP packets, > and could benefit from being supported by netpoll. > > This commit adds support for such interfaces by using the network device's > `hard_header_len` field as an indication that no link layer is present. > If that is the case we simply skip adding the ethernet header, causing > a raw IP packet to be sent over the interface. This has been confirmed > to add netconsole support to at least SLIP and WireGuard interfaces. Would be great if this could come with a simple selftest under tools/testing/selftests/net. Preferably using some simple tunnel device, rather than wg to limit tooling dependencies ;)